From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCC7C54EBE for ; Tue, 10 Jan 2023 05:08:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B6548E0002; Tue, 10 Jan 2023 00:08:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 540388E0001; Tue, 10 Jan 2023 00:08:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E0F68E0002; Tue, 10 Jan 2023 00:08:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2A86D8E0001 for ; Tue, 10 Jan 2023 00:08:28 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E939616071A for ; Tue, 10 Jan 2023 05:08:27 +0000 (UTC) X-FDA: 80337708654.07.03D142C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 0B0CF1C000F for ; Tue, 10 Jan 2023 05:08:24 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XGJEFCmW; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673327305; a=rsa-sha256; cv=none; b=DFXi9FQGQgNEVDUO/Z/7cRA2Uwi4Dh0WUoa+mWyy9Swq5y0gSAj+Fuhs+i60d4/2aKvIOt cl7Rw2pC1b0qc+e6garjM8IsOXld03EmigzVrkoQTC32WwQYMcLzZnL6NrW/YQJxXkaocr xuVknauq4iblLRKIoBWDtP1iHBCZcLE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XGJEFCmW; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673327305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s3eeXxhx4tpS7pmZqfCJKqLGMlzmrOgdka1kjKMznI4=; b=fSQPYoDdW6wvDde9La+CJF8vZqmVDVBJjMTEpIGXdo0WYJJdHWK/fxKhrIJ5K1T4D0+OIQ Lqf8Hl3VdLkZTyDwNM3jVppci6qIMECmhObR+Miczvk7ylIUgHR8n+vtWRWk/XFCEb910t v2LLNFUrGMKhf88mFIBjvbUr/FoAL28= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=s3eeXxhx4tpS7pmZqfCJKqLGMlzmrOgdka1kjKMznI4=; b=XGJEFCmW/g7ojPqXxDzSIo/bZf 2a1smaf/JQQz3olueaj9Y/Wc9QEAHCtgcy/b088rjTbOT7NQvB4EWdhUDrvh4EYj9IicLMmUDh6vF 3eMwCkdKa3Sa+CQyan10aMktrXtIQ7GNYZ+mSs2eNJcC1xWRHZk5YgJJYlST66qQAoRpxqTROL8T4 T232bsST3sdD/CpGNKEQBwDYVhkPgZSp0qRqj4Srl4tvHyDk0aiaaaw47+4+cCxG1s5iLl59Km8fF EHw2/n22dBHQXzTjC6VfjYdPM3tnT5jcbbCsn50bm0zeldFCJaFDuJAFwM1mv61F6FP5s0EHEoIWN ZRBIX7bQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF6s5-002w7R-Jj; Tue, 10 Jan 2023 05:08:25 +0000 Date: Tue, 10 Jan 2023 05:08:25 +0000 From: Matthew Wilcox To: Yishai Hadas Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, jgg@nvidia.com, axboe@kernel.dk, logang@deltatee.com, hch@lst.de, alex.williamson@redhat.com, leonro@nvidia.com, maorg@nvidia.com Subject: Re: [PATCH] lib/scatterlist: Fix to calculate the last_pg properly Message-ID: References: <20230109144701.83021-1-yishaih@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109144701.83021-1-yishaih@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: 0B0CF1C000F X-Rspamd-Server: rspam01 X-Stat-Signature: jnrkcsgugh97wj1neomu4cyfoezi9c8x X-HE-Tag: 1673327304-755229 X-HE-Meta: U2FsdGVkX1/4VTwliFbvCIZxWAcMX2XHGI2EYCo4CSo6eny37zcgjgtC4xL6YzY24svjbXAV6hV1uzxzhf2dOMnWRun8Z+QDTKFBBVD2CBuDVoxt2eQhmmtzT3pkAI4Q/FfkvzoUO4z2yheZ0hYba3ZCbonPxfSSvKG5pzMX7uctMIkpnsi8sZrjPoJEdrRwMZ1e2Vd8x3J+08yX+Sg7+IXc803KR1je8dcZ4CHi8kAXfinh+aL2L4JMR/OXfG1YcI9jF8E1oORwd4p5aowwTF4H+1dmOIONqNKZJpKroqFTFH0X9ZV7jhftcin8M/8rnELdYJ9aBT2ysjhE5Y9h0W/tTkGHUfnlVCudMHmvyRPdGvSg3mWNBQuq2dc9SOqcThe+vBwu6Scq7KoMoVAevGMcB6lCYO6F+9h8nQwdiPJQhFcQoIu+MOFqbPnIHqeHMZgl3Fsc+mr6wSh11zK77ug4QSpiPUWmKDOwkF8ckSbmX4BuMpL/R3nMY5s22P5Nv/Nt3xmLqbEq/fHymD32py+DD7ox3nFKeARMTqTqjeuisHWjd5/RSezg7ljzv2nuSPFzl8QdRGidzkMuQcahvcifKR0d3hqcvENMnqZKNiDnRQoKu6tfrkgZZ31R1Sbhr5z3NwNYqWzKU5GGaGaX8uIVKLlvInJd20YR9fFTgCXeC1eliz6EJm+2I0m0Uzncdm+rDQqKWWvd+K0ToRbEuXsdlt075tUJ08IYhtdNNL7tB63F+SuEeKZOOz8aMfBIEKVQC/RgQoS4Cki8MamsszuDbVx3sdKttyegccQw4eR7bjyLujlwKdCugLg1k3SHMVlbLv7BSco7J5zlCikq9gdeDgvoc1f5I9/8pQwHFII= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 09, 2023 at 04:47:01PM +0200, Yishai Hadas wrote: > if (sgt_append->prv) { > + unsigned long paddr = > + (page_to_pfn(sg_page(sgt_append->prv)) * PAGE_SIZE + 1. page_to_pfn() * PAGE_SIZE is spelled page_to_phys() 2. physical addresses have type phys_addr_t. Oh, wait, paddr isn't a physical address, it's a pfn because you divide by PAGE_SIZE at the end. But you will get truncation on 32-bit, because page_to_pfn() has type unsigned long. Anyway, this shouldn't be called paddr. Maybe last_pfn or something? > + sgt_append->prv->offset + sgt_append->prv->length) / > + PAGE_SIZE;