From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4529FC54EBD for ; Mon, 9 Jan 2023 22:18:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A45058E0002; Mon, 9 Jan 2023 17:18:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE588E0001; Mon, 9 Jan 2023 17:18:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 847758E0002; Mon, 9 Jan 2023 17:18:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 728E18E0001 for ; Mon, 9 Jan 2023 17:18:37 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 435DC1211F8 for ; Mon, 9 Jan 2023 22:18:37 +0000 (UTC) X-FDA: 80336675874.19.403998A Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf11.hostedemail.com (Postfix) with ESMTP id 2F31D40009 for ; Mon, 9 Jan 2023 22:18:34 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cWFBiZsx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of gorcunov@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=gorcunov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673302715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CgbO5/6E78JCLwQiRJ+GU76lb3E80co6aQPgv1Rwx3Y=; b=YB0w9jiBm61C33uomRpf1i5cHzfbQBuwFs1Qr566G/+KyAYLjqWS4OHPU33kbN6YYF6QO4 2lyAJ61kFifxq6Kp2xlNBxKTk2JmOa56wSEmKOZ9aEmjE6cYorsha1OLMTFRlmBEGwgNZv 3HIQNFUDUNf9nGuV1e4r1xuINz4+8ho= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cWFBiZsx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of gorcunov@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=gorcunov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673302715; a=rsa-sha256; cv=none; b=mrhKJCUkrja/XkCzqvRF58xmfNR9woUr5uVcZ18YVk9zkwQtvERx+Zcy3sMutwKjyywhM5 zPWFcGvBgi5jZVFuyEfFYpS2xTlsfdFR68wc5rK9REQ7kA/+Q6r6Fsld7szDJWwQjopW6+ FR12HLccRBtDUNSyFtxjK50WX4wLs18= Received: by mail-lf1-f42.google.com with SMTP id m6so15296332lfj.11 for ; Mon, 09 Jan 2023 14:18:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CgbO5/6E78JCLwQiRJ+GU76lb3E80co6aQPgv1Rwx3Y=; b=cWFBiZsxJmt7+Mr0gxTH1fT682fYZn4nDLSPHWboy0Q+UYXTstHpRkaGBdq/1mvXAZ N388+BelXTCuRWYsiegdu4V9/Yj+DXsVD5S7kr6gTACp5oileN0NxVRIl4MxHMvXntwW AzyWkacDaj4OMwsjs8ljwc6J07NO76YhYAS8/jcH5klUnKa8dFdR60hYCzZe30rsJXyj 6fmbwdWcOZ9f3+osuGvy0EVnnTNll8P51LnBoIj1QlO2FE3m8a8uNX9ly1e+jfi4MwMp 5lebH+h/v8uPxA4K2t8dQbwvj1LagszbLmId1kdgs2KbHby0lYpDxKX5k7wqaoxdsv8t sVDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CgbO5/6E78JCLwQiRJ+GU76lb3E80co6aQPgv1Rwx3Y=; b=XGJqR+Lvpmve7z2EbymEac0iMSkpQcWep03CS1dZKpkV4wk/ET6gNDsQnMdw1gFTBS M/Z9AcWe40EeKomb1Ghh+V7KYvCpKArdLRmwTmfTbAkJw1BqA9pTyaggycJDESzHdgwe 6eyTRwBPx7Gyd0+cF8QLAh5ypdHhG9UKB7cHlscrMML8WS4P7EXdo0136Ge8bL2yS21l +g5Q1P3fzc3Bqry58xmzmrCSMJ1GHZmP02e3Apl+ZhKeRlktAgzkKpodcYrtP2qEs+LT PuhTlQ+1gXkJGbJ+V7P6GtGS0rouTfUnkQWKDz9qa6pIW/9uU2J2XpuTqoZkFZ3HNabl myDA== X-Gm-Message-State: AFqh2kqDHx26NsXdIXgRmvpsgGUY8o+NVju5OTuvDI8jtUJo8rdzi7o8 20PKHy1L9BtBkFVdau7VhWo= X-Google-Smtp-Source: AMrXdXvvuTXTdr14JdOozdCOiEcAiGITq24w9ufrrPr27Oq0YD+fW7BIb1ASJXK1NPFAzalX26yLYw== X-Received: by 2002:ac2:43b5:0:b0:4cb:40ba:4ae8 with SMTP id t21-20020ac243b5000000b004cb40ba4ae8mr5990424lfl.34.1673302713261; Mon, 09 Jan 2023 14:18:33 -0800 (PST) Received: from grain.localdomain ([5.18.253.97]) by smtp.gmail.com with ESMTPSA id w6-20020a056512098600b004b4e67c3c00sm1818091lft.53.2023.01.09.14.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 14:18:32 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 8A7B15A0020; Tue, 10 Jan 2023 01:18:31 +0300 (MSK) Date: Tue, 10 Jan 2023 01:18:31 +0300 From: Cyrill Gorcunov To: Muhammad Usama Anjum Cc: Alexander Viro , Eric Biederman , Kees Cook , Andrew Morton , Steven Rostedt , Masami Hiramatsu , kernel@collabora.com, peterx@redhat.com, david@redhat.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] mm: implement granular soft-dirty vma support Message-ID: References: <20221220162606.1595355-1-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221220162606.1595355-1-usama.anjum@collabora.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2F31D40009 X-Stat-Signature: hkkqac6wspqxf71bffgukzgijmjprxcf X-HE-Tag: 1673302714-902230 X-HE-Meta: U2FsdGVkX182CNOSyLsPOn0MVAfQ5UYys8y4CWCVFxXPojl09pjmmoSJUa2Wv60V+XqTAlZzmkOFBA5EHwdPyc4Buyj8cK6es/TXYlE4hxWUzujBcZfW8Ek0nTDP3Qhc4I7KQLkw7bEPy88hiG5XVnrkxMKVPW+6jhaJT7yv28yaX8TbcKrt79tVIajuuyJvTYZBLkqvmeQgal3IM07SCd4VQjv31iHY67/9pbHqJTOsWfWC4KJIet7gRGq05LmiR1grFaY5aWHAPaJQ313L24YT3T5CzPkhFlJUi2iGYStI8GmUzrai8BmOU6W8cNxhu/A4emV504+b/KZXBnMIUW9Kdnrxcv3S0cQxgraxTHDXAIVPNtxd4AfEGqojsvqceqaHODThRygDijhhvP/teSr0W/PDiv7EFRlylj0E7szXEIex7onrbzcS75fGXs05L/QjMRxtwRB4dMiarc6YKxT87Ehh1MY0zAJTmCSjaOiWBa2rVEfHt6ptgGf9aOYsfXsQECeoVesZlIyXOpVWqgLIlV1jn+0vvWzXfonTl/xlx/zm/2LisjinRYLiY2lvKqOMqTe2ndIwuW3acffq+Pvpb27vRki+x8lWw5usmBBWN9lonMqdsAz4wzwBx3L0H3b/kkQJtjMt5i41n7JFC47nTuK54raelwH02JJXL7gNBP/SN6a3UMpQqPVx2c5n7uvzE8crl44CPJrYUPsL5HzJZeeLLHyeIxlNP1hNYhgbkEiSO2QLRdX4x27rqCVy1xNpCgHCP6lfnAzoIXCCtrt9QN9Ke/LKEZLp2y6/qX000bcUw9vhZiqx0S/skuFLXxxksopHQKF7gclVF+IPK90mmxbfsPKnMACr/X7Ak+bZ4IzSPVGb1q58EdhGHHQsaCQ9BNAtPjK810WMK6LD34QNOxieIfg6DQpH6AIhvyyf/iwk0M+nHJ7E0gVl1WH/aJvwstw6ba/vqOYLNxm O4TJAlSQ dbLPEGDU4rLufmHdhOB4sTcP4M0/FQ3pDGBL2aCXssZ3eb6pjD7BcbSsVlllBQuiLG6nYYLbBTRw7s2ZtgbVuz9G0vI785Vb5P6YBJWCozMyx68TEU3cNArdgP0xtn6GXsSJ53GRhWLXQhlg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000048, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 09:26:05PM +0500, Muhammad Usama Anjum wrote: ... > > +static inline int nsdr_adjust_new_first(struct vm_area_struct *new, struct vm_area_struct *vma) > +{ > + struct non_sd_reg *r, *r_tmp, *reg; > + unsigned long mid = vma->vm_start; > + > + list_for_each_entry_safe(r, r_tmp, &vma->non_sd_reg, nsdr_head) { > + if (r->start < mid && r->end > mid) { > + reg = kmalloc(sizeof(struct non_sd_reg), GFP_KERNEL); > + if (!reg) > + return -ENOMEM; > + reg->start = r->start; > + reg->end = mid; > + list_add_tail(®->nsdr_head, &new->non_sd_reg); > + > + r->start = mid; > + } else if (r->end <= mid) { > + list_move_tail(&r->nsdr_head, &new->non_sd_reg); > + } > + } > + return 0; > +} Hi Muhhamad, really sorry for delay. Please enlighten me here if I get your idea right -- every new VMA merge might create a new non_sd_seg entry, right? And this operation will be applied again and again until vma get freed. IOW we gonna have a chain of non_sd_reg which will be hanging around until VMA get freed, right?