From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3073C54EBD for ; Mon, 9 Jan 2023 16:30:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68D70900002; Mon, 9 Jan 2023 11:30:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 616388E0001; Mon, 9 Jan 2023 11:30:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B834900002; Mon, 9 Jan 2023 11:30:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3C78E8E0001 for ; Mon, 9 Jan 2023 11:30:23 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 11B8C160AFA for ; Mon, 9 Jan 2023 16:30:23 +0000 (UTC) X-FDA: 80335798326.06.CCF255C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id EDDFB40002 for ; Mon, 9 Jan 2023 16:30:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JVVg5ZiQ; dmarc=none; spf=none (imf12.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673281821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o2/WdWh0APeupuPh7RKLqwpzddI4XMgnRH0Srb3bBA8=; b=QuphvVGq7zOM8MbWXDoYjzhEmBhmtYxfoBL1MGeZVH2Xx12EUF7Ukq1KMqTWkZF74EPs+e snIAJ+tJTWcaRAy0bKwa8l3sJ5WdZv0usnahHklZ2RdQuNx2KqV0HMAzWbHo1telTkefXm 6YVxpF0kDsQP4ESBs4FMJ0GiJKjXKyU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JVVg5ZiQ; dmarc=none; spf=none (imf12.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673281821; a=rsa-sha256; cv=none; b=KUryxZAT+O75GlS2MnDd5SPj67v6vJuJOna8/2tnn/qfZ0nKA+IlhH37EgBPXBKkFmFBCc dBfDWcYF14odmt1CPvHuApi8fbYZdhX4VMIbDGRPFIB3wf7P7TLz1Sx3HNLRSzpLhbrryF XfJsSZtzPy5+5JORqz75g7PcK4XCxiQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=o2/WdWh0APeupuPh7RKLqwpzddI4XMgnRH0Srb3bBA8=; b=JVVg5ZiQ5EwX/bJmzcBrm5hQRZ /FzNMH+VKS9Uj+oKG55AthoXByc4rsJne2KzG8AGcjMmoP5h0WqErzYgDSN+WUQKzncqgpwuFs1+7 1M6D1dFOaXVUOKeggVpP3UtCWrl5p5Ztj2Lj80rGwv2HxiXqq7hDuP/8BUHSrJZWBfuL6Q1X4nx1p RS1CDqZNoCvrBjNAChCc1uvqKPHUBlUFMKbqG3LtFI8xHtSyffujWEPx/nzLx/hEe5qaX301iKJnv lPtarK9OheMMBqEx+eJIz+xyn512CYwoPVvUtrlL1KlwNB/M9NxcRuX/KVZUMniyhSoP3acYxTdvd rpTqYc0Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEv2H-002QqF-Eb; Mon, 09 Jan 2023 16:30:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 13FAA3001E5; Mon, 9 Jan 2023 17:29:56 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 02FBF20086EAB; Mon, 9 Jan 2023 17:29:56 +0100 (CET) Date: Mon, 9 Jan 2023 17:29:55 +0100 From: Peter Zijlstra To: Heiko Carstens Cc: torvalds@linux-foundation.org, corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, Herbert Xu , davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org Subject: Re: [RFC][PATCH 07/12] percpu: Wire up cmpxchg128 Message-ID: References: <20221219153525.632521981@infradead.org> <20221219154119.286760562@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EDDFB40002 X-Stat-Signature: p7kju6tc7bwsk1k6ahk38i547wz3zgbx X-HE-Tag: 1673281820-691886 X-HE-Meta: U2FsdGVkX1/D1ldSYm3zfPc4Iz1hEGE1MVkLd+iMyNnA6Pd0ud/tAgoq2cEgct47WfmOnWCzrE1/RShjHXpSI/5Yi7DQdjiujuHunN+549fsNmf3Vrqv981Lt3WmNEAK2hiBxJuG3c7DPL1/xIh21BnogufrSJHsia38JQdQR4R1zg/0hPP5kbl5H4psE89OCH7RngwApy23MITNAeXFPXHslyN9xchOy4LLlN/m1/Hf6gGsRw1vcMuulsH9MjdIxEN/xV6GeeoFeN+J9B8lsehlbQ+1SvHyNj1wEcwDn76fO+HotT/kPVxVzKe+EoQHIbpWmyEvDJNYu/p8Ab78bxZp/c836ptztM7EzGOqTnDbCUW5q30mLm7TqOv0+xemn73KR3NhB6kx8u/YbTVw/y3Qp6Q0mz+zxup6+M44Vu90gsi6qvqhl8x3S4N4m1Xl1td4Q9ym/GRzYbYzIhxoWgaxgUC3j4axSThnUUHOj9w9tfchvkT576bfj/+alKWf17Smbnybb2w18UY6yTQqJ9ZytuftokQ278k9dHTBpxKn9+MBxkAQu0BS7efUBb74sw9eT7n09TkTS23uvjcPtPDciNnuXRnlKknE1v/ZYUcKp7ryH/lGfCLQMzhyjakA+m6FPC03LJfT53VF3eMTze40vixrI55BKmDvrCW0RBiCJwU/TuZwFT4687WKlq2ls3nz4PjJ9Ce/N3HinqqIlrfXEYOeLLvXbrR9JRM/ph9lQkflGTSHfCEtDIW9PMrLy24qwPq9Z3go/Ycogctphz5mlyOMPNQmCz0D6tHXJtKGSFPNypyJdhXwm9Nwp+vRA7KZFUe8r9p+zrBrvvpI24WhEU7RciR3171JGnDGCM/WKQ1e4JZvE9p4jFopkVKbGMQuWaxBni5vPzczwYduFJ+mRlV4Lu3deO3WVasrLy8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 04, 2023 at 01:09:16PM +0100, Heiko Carstens wrote: > On Mon, Dec 19, 2022 at 04:35:32PM +0100, Peter Zijlstra wrote: > > In order to replace cmpxchg_double() with the newly minted > > cmpxchg128() family of functions, wire it up in this_cpu_cmpxchg(). > > > > Signed-off-by: Peter Zijlstra (Intel) > ... > > --- a/arch/s390/include/asm/percpu.h > > +++ b/arch/s390/include/asm/percpu.h > > +#define this_cpu_cmpxchg_16(pcp, oval, nval) \ > > +({ \ > > + u128 old__ = __pcpu_cast_128((nval), (nval)); \ > > + u128 new__ = __pcpu_cast_128((oval), (oval)); \ > > spot the bug... please merge the below into this patch. D'oh, luckily I got a fresh pile of brown paper bags for xmas.