From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F11CC54EBD for ; Mon, 9 Jan 2023 15:07:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08D4C8E0003; Mon, 9 Jan 2023 10:07:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03BD38E0001; Mon, 9 Jan 2023 10:07:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6D188E0003; Mon, 9 Jan 2023 10:07:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D6B878E0001 for ; Mon, 9 Jan 2023 10:07:39 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4BD48A30B5 for ; Mon, 9 Jan 2023 15:07:39 +0000 (UTC) X-FDA: 80335589838.04.631E59D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id CE9FF2001C for ; Mon, 9 Jan 2023 15:07:37 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nh4Y1aUg; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673276857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ur7C+W2r8wDUsaTYPPPMV6CzMQmfkaZSRCKEcopFFQ=; b=lypKcw/aI1g3QEwGa9pWPv26+jbXs7m8iX9lW1SwSWNrQubn3jBqazxW0eozFsXwjQw35g CKsOloo95EbfttA5TqLaDvcSsgffhYFbEMqoYgyyXG8v2Q5alBRD/zXxkmUIpVekx4APl6 RY3lDq4yKAWLZKXp9zZVfacEsjdCz/U= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nh4Y1aUg; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673276857; a=rsa-sha256; cv=none; b=YI/1OxqYNWzcnv1vZbO2e4mlU2B3DBslDwRVJptjwCD5J9QuzmHMcj7k5h++LOj4g1WByP zJbQLtmJvKW18Xn5H+fs9NU9sKpXsdQ5lo3xIjU8HIFyDCPaOeq8wNj5dzuKDsToP898Y1 PJB8pfdRIErhjKTuxiltYlGsGR8VPzA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3ur7C+W2r8wDUsaTYPPPMV6CzMQmfkaZSRCKEcopFFQ=; b=nh4Y1aUgxZvfFlpIE1QZR9wDiq /r5xjZ2NMM7L6Y36kwT/MLtlC8F8AuB/KtP4F4v6S3SRt43AOrUfGVVzVfiM20rDZwkvdoJScmbAw HK3wU1/SdXYDsDkI79q+B6cxODNDyPwuZ4YLzb3v0Dj0OyVZmXDiYSigjVdO6bf/XW7rjl6NUhzDB F2e7GUTNuL4A9QqGrKXFiiuqb5wBwml+3ess0bGcAZNs1ruHFShbBv13oC2EruTOqq/3jsUt69RFv kpTieWrVuEpi8yDQxFVaz9G0qsGraRybQUlNsjn8N77w+fArKfx1w5BhAggxcCUU3Q3uIusyPxfF+ RSOcf2HA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEtkW-002NXd-N3; Mon, 09 Jan 2023 15:07:44 +0000 Date: Mon, 9 Jan 2023 15:07:44 +0000 From: Matthew Wilcox To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 08/11] cifs: Remove call to filemap_check_wb_err() Message-ID: References: <20230109051823.480289-1-willy@infradead.org> <20230109051823.480289-9-willy@infradead.org> <7d1499fadf42052711e39f0d8c7656f4d3a4bc9d.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d1499fadf42052711e39f0d8c7656f4d3a4bc9d.camel@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CE9FF2001C X-Rspam-User: X-Stat-Signature: 31shxh5ntrz99z4mmkfpwbqadj6gtbcu X-HE-Tag: 1673276857-931840 X-HE-Meta: U2FsdGVkX1+Hra8onwjARLzFa6wnsXr2q8I0MPiitJnNQF5pVJvj8mUxTuic9OyyXR951tedq+uO2IFYTrRM/9FqectFkvWJfLO1YqnN6XqKjrbdX+p8rsQaoAitM1i8Ax93lC8qNOGplj3R7bBtnLSwhKkrpTXD3VdGWatiRluvvFqP5v5X+NbiS7DDWzgH+G/K1sKUNp5EjVND80IBSU7x7M4aQu96+tntE6Vcxl+r4MlJd/1TeIMO4rl3C8NaPryIWMCWPJ1fWjpqcO2e5vyHMl8Htkkj0BHklHgCptZ+E86+ML7XjdhH7ao3kuQQnXcGv6esgHuB/frtvHdj2zOfrIYJO5/s6Y9624rDbFUJOwL/yEqeM8zAK2c0YAoKOGmHUQZ5GEOOg+qsaYQsXF4VNS5eru+SWBSOSc4silBnZqLGuM1/xaGOqGfCiuFKh8ciklhbv7efhFMNV2oP5lAqf8Ws0qE9zuRJMYzea5B5AQalHHab6MhI4j+sfplGJCMjRYDY/Ra6WFKK/ATslbKGNUaFc1v35SomIzaRY2hWEFC+LEwSJ5qSOObfu2HJ1sfvwO7iwlvveYojfku0oPL0AokshH9iXP057QsmGVI5iyZmQgnj9e2UA8autrZ6L18fN9AlfuEhak4ZvX60miyZwBNIy9hOXbd4vmlSvHuVCAnybhKFFZP4GlOXD2mxqNeYHaacu/KptVBU1rM887PG1ZFTymlUHfAZEL6C2fEbzkNMAfr7oVMnVd4h/ddXxpmFt1M6oX/zSPTp5eSW0jhuGER3XD65zyoFfwEY4fuuj+kBvSmRgdngny8Z2GsX5Jc+KaUzBpF+ElGpNpXN1RdNJ1zX24ma5bHQaCgxM8etc/4mlHAFzRl8IZCWcMIHDm65+qXQ+/kVFejEzdaD/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 09, 2023 at 09:42:36AM -0500, Jeff Layton wrote: > On Mon, 2023-01-09 at 05:18 +0000, Matthew Wilcox (Oracle) wrote: > > filemap_write_and_wait() now calls filemap_check_wb_err(), so we cannot > > glean any additional information by calling it ourselves. It may also > > be misleading as it will pick up on any errors since the beginning of > > time which may well be since before this program opened the file. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > fs/cifs/file.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/fs/cifs/file.c b/fs/cifs/file.c > > index 22dfc1f8b4f1..7e7ee26cf77d 100644 > > --- a/fs/cifs/file.c > > +++ b/fs/cifs/file.c > > @@ -3042,14 +3042,12 @@ int cifs_flush(struct file *file, fl_owner_t id) > > int rc = 0; > > > > if (file->f_mode & FMODE_WRITE) > > - rc = filemap_write_and_wait(inode->i_mapping); > > + rc = filemap_write_and_wait(file->f_mapping); > > If we're calling ->flush, then the file is being closed. Should this > just be? > rc = file_write_and_wait(file); > > It's not like we need to worry about corrupting ->f_wb_err at that > point. Yes, I think you're right, and then this is a standalone patch that can go in this cycle, perhaps.