From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF7FC54EBD for ; Mon, 9 Jan 2023 12:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BE068E0002; Mon, 9 Jan 2023 07:49:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66DD98E0001; Mon, 9 Jan 2023 07:49:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5362D8E0002; Mon, 9 Jan 2023 07:49:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 442348E0001 for ; Mon, 9 Jan 2023 07:49:39 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0C5A3160606 for ; Mon, 9 Jan 2023 12:49:39 +0000 (UTC) X-FDA: 80335242078.05.9CC760C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 0891E140003 for ; Mon, 9 Jan 2023 12:49:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HRuz0dmq; spf=pass (imf26.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673268577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LwhDO9hieIsVo3qlSVGIThrVfpxjel+wqnVT2UQVflA=; b=gycXun4R/8QYOCu8QOIRXuFCpm72+n6uP0pICT7Cm4tH63+nTTfrfax7RmS+7fNGOTZgfk PqofmzHxussIo5hsjMb0KUSz4k8kIUrPjwfJNFbtl6lMThuqseSHJBFYbhBA+vsF8cjFTh Zu/iBzwNFGozTW772LRNR1rIv9vFrrY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HRuz0dmq; spf=pass (imf26.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673268577; a=rsa-sha256; cv=none; b=hnXajJZR5MSTISN3ZfWHtyzXOBWRZwPi05P6ZZRwyQZ3Zmt9X7WeldJdxE08vaQl2wprd5 POJPK5K6/OS5sGXarr4GBaCQh8wQLFyHTy8f7W7upZOLUUCW1eS1ivcSVKqDq9odfAolEk qlE6fY+v10pPhQn7FRCwZGhF8ZJFLPQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673268576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LwhDO9hieIsVo3qlSVGIThrVfpxjel+wqnVT2UQVflA=; b=HRuz0dmqUuINqGEIt8/q7pFMEZbJqUvL0gxx1NxYHiYk1Z3YOfokGaFbctr+IEKSFH1b/K O/04vRDSoFw1goLupTV/lIEKmZZHp2HiQVFySLY273Otbt6FoPuzQwiWZAVdn9TI2q4f+i NrSyTVzUuJ3vaUguAMhA2lTA+ppW16c= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-213-8ESDBqPiPE2lYi__J1m1ng-1; Mon, 09 Jan 2023 07:49:33 -0500 X-MC-Unique: 8ESDBqPiPE2lYi__J1m1ng-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B8F7E1C07541; Mon, 9 Jan 2023 12:49:32 +0000 (UTC) Received: from localhost (ovpn-12-124.pek2.redhat.com [10.72.12.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA6022166B26; Mon, 9 Jan 2023 12:49:31 +0000 (UTC) Date: Mon, 9 Jan 2023 20:49:28 +0800 From: Baoquan He To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, urezki@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v2 3/7] mm/vmalloc.c: allow vread() to read out vm_map_ram areas Message-ID: References: <20221217015435.73889-1-bhe@redhat.com> <20221217015435.73889-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Stat-Signature: p9pknt1ecz94xgxt4npgwrzc8hnmk3dd X-Rspam-User: X-Rspamd-Queue-Id: 0891E140003 X-Rspamd-Server: rspam06 X-HE-Tag: 1673268576-29224 X-HE-Meta: U2FsdGVkX19DZ1PBGsXTvMu7QUUCe0+9kvxohT2sW2XXUvs3JiIhfUAWdGN5TlkWkj6Bv9wx9HqQFHO/xJxV7Q3vRc7lJH6MX6JsZZ8m1uoe49EoEDI1jnvGD8Zx0zrEfZ4+0SQVxOt7Meb+dZ3LqIUGuu0XLAwuB41mfLMmGlOjHyXZ7Ff/jeBSdWqW9yprAXT1dqB1Sw/zG/h4TqggyJKkJaClkX+g0dkgXWsuoOfMI7lwnj/rR8lh2UMZMFoaKa4gjX4Q7cadbA5vLbAJHsq5mbiCpPH85MY7Crl6n9O59LPsA5NZPc38/a/SyZqvotnhKSLZuJkdkwS6V26DJXnfOo8PmW6r8xXE/1aULsSX2deOsVuLpYJgerk+sYSY1iUe/kiWodha8ycQAYNC1veA0t+IXarSl24F/grGgJ/rwL8CWm4ltTj9C46ZjZIUGee5e83fsRsTMdIsXPGmv6X3AzXhqAhc3Wxiu3Ir9SHOb6JLQ6G8JD2Aj4+jWqlVZjiwshYTnwjA7YJ+/MgIdX2zufK4OSUZFCbj2092RENu1fgdFVJgakk+7iXe8mnSCSB+3uxwF/fqprdgS4YAP/lDkSPfKm5KygAxTUQWVPBszOpViblsewp0iLcX0RiWN8tCqWvskaGkKHBeDuwx61/JaxCXOqPOwnpNefefSLUB6r9fj9MV9dO+KR4o0UWQU7WF+ZCeKMlVoXmoTxFCcn7YCShDow3AzGppxfyX6K8ypo02labxNmNbFU0ARtebsh9YYPHJdUvZ76SLuHzq6OrkZ+OR540fxi4vA+9AJO21vNVnlUscD7hyGV4RemKcgsKbo/ZIqI+uXphuwh5/D3d/yHIFt5rb+26xNeUwoK+ZF6fXMs414uKG3L6OW+/UEXaexGVjp2X7uKdlCvPMcs2rCyfP8QqGCpASZtFmoOk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01/09/23 at 07:12am, Lorenzo Stoakes wrote: > On Mon, Jan 09, 2023 at 12:35:04PM +0800, Baoquan He wrote: > > Sorry for late reply, just come back from vacation. > > Hope you had a great time! :) Thanks. > > > > > Lei + mutt sounds like a good idea. I relied too much on mbsync in the > > past. > > > > Yeah I'm finding it works well, > https://josefbacik.github.io/kernel/2021/10/18/lei-and-b4.html is a handy guide! Very helpful, will try. > > [snip] > > > Maybe let me rephrase:- > > > > > > - We want to read `count` bytes from `addr` into `buf` > > > - We iterate over _used_ blocks, placing the start/end of each block in `rs`, `re` > > > respectively. > > > - If we hit a block whose start address is above the one in which we are interested then:- > > > - Place a zero byte in the buffer > > > - Increment `addr` by 1 byte > > > - Decrement the `count` by 1 byte > > > - Carry on > > > > > > I am seriously confused as to why we do this? Surely we should be checking > > > whether the range [addr, addr + count) overlaps this block at all, and only then > > > copying the relevant region? > > > > I guessed this could be your concern, but not very sure. That > > code block is copied from vread(), and my considerations are: > > 1) We could starting read from any position of kcore file. /proc/kcore > > is a elf file logically, it's allowed to read from anywhere, right? We > > don't have to read the entire file always. So the vmap_block reading is > > not necessarily page aligned. It's very similar with the empty area > > filling in vread(). > > 2) memset() is doing the byte by byte reading. We can > > change code as below. While we don't save the effort very much, and we > > need introduce an extra local variable to store the value of > > (start - end). > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index b054081aa66b..dce4a843a9e8 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3576,6 +3576,15 @@ static void vmap_ram_vread(char *buf, char *addr, int count, unsigned long flags > > + if (addr < start) { > > + int num = min(count, (start - add)); > > + memset(buf, 0, count); > > + count -= num; > > + if (count == 0) > > + break; > > + buf -= num; > > + addr -= num; > > + } > > /*it could start reading from the middle of used region*/ > > offset = offset_in_page(addr); > > n = ((re - rs + 1) << PAGE_SHIFT) - offset; > > > > The difference with vread() is that uses a while loop rather than an if clause > so operates over the whole region byte-by-byte, your original would only do this > for 1 byte so now things make a lot more sense! Oops, that 'if clause' is a code bug, I finally got your point until now, my dumb head. > > This approach makes sense though I'd put the count == 0 check first and nit > 'add' should be 'addr'. > > I am happy with either this or a while loop instead of an if which it seems is > what the original issue was! OK, I will think again which one is more appropriate. > > > void *memset(void *s, int c, size_t count) > > { > > char *xs = s; > > > > while (count--) > > *xs++ = c; > > return s; > > } > > > > > > > > It's the fact that blocks are at base page granularity but then this condition > > > is at byte granularity that is confusing to me (again it's _very_ possible I am > > > just being dumb here and missing something, just really want to understand this > > > better :) > > > > I like this kind of reviewing with careful checking and deep thinking. > > For above code block, I think it's a very great point. From my point of > > view, I like the memset version better, it's easier to understand. If we > > all agree, we can change it to take memset way. When I made patches, > > several issues related to patches were hovering in my mind at the same > > time, I did not consider this one so deeply. > > > > Thanks :) I have a particular interest in vmalloc so am happy to dive in with > reviews here! > > > > > > > > > > - vm = va->vm; > > > > > > - vaddr = (char *) vm->addr; > > > > > > - if (addr >= vaddr + get_vm_area_size(vm)) > > > > > > + vaddr = (char *) va->va_start; > > > > > > + size = flags ? va_size(va) : get_vm_area_size(vm); > > > > > > > > > > For example here, I feel that this ternary should be reversed and based on > > > > > whether vm is null, unles we expect vm to ever be non-null _and_ flags to be > > > > > set? > > > > > > > > Now only vm_map_ram area sets flags, all other types has vm not null. > > > > Since those temporary state, e.g vm==NULL, flags==0 case has been > > > > filtered out. Is below you suggested? > > > > > > > > size = (!vm&&flags)? va_size(va) : get_vm_area_size(vm); > > > > or > > > > size = (vm&&!flags)? get_vm_area_size(vm):va_size(va); > > > > > > > > > > Sorry I didn't phrase this very well, my point is that the key thing you're > > > relying on here is whether vm exists in order to use it so I simply meant:- > > > > > > size = vm ? get_vm_area_size(vm) : va_size(va); > > > > > > This just makes it really explicit that you need vm to be non-NULL, and you've > > > already done the flags check before so this should suffice. > > > > Sounds reasonable, I will copy above line you pasted. Thanks a lot. Thanks again for careful reviewing and great suggestions and findings.