From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84FBEC67871 for ; Mon, 9 Jan 2023 10:13:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53E58E0002; Mon, 9 Jan 2023 05:13:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADE208E0001; Mon, 9 Jan 2023 05:13:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97EDA8E0002; Mon, 9 Jan 2023 05:13:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 83B838E0001 for ; Mon, 9 Jan 2023 05:13:36 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5C5911A066D for ; Mon, 9 Jan 2023 10:13:36 +0000 (UTC) X-FDA: 80334848832.06.0FCE525 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id D96FA120002 for ; Mon, 9 Jan 2023 10:13:34 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s+SOtO+j; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673259215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZV+JkOkDUdXoz1Xwl2jY1ZImcg5kAVtxDyqct6SLCcM=; b=eYkjQnmWoomYeh5qf61rGsXmKqVq6YhcZtKhgPgRJ0mTm/ql/UBRb/95nR/CNKKadj7uzW quQB5GJjM2DcC7Bkd4BG4KzRfutbkjKE9y3kDYO7sIlOFCKA0qhgI2vfrpwnfAaefXUHwh yAcB3l+XrFl+DZy/TFhRBgzYktc4JV4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s+SOtO+j; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673259215; a=rsa-sha256; cv=none; b=inBaZ2ajLP485zNFWmhJuX5UwqE06VPiwZQ4gaD674kmGcThWII2gPJ1dl7mxRf6mvoP0N QJi1asbWMaTClMBkQbW7jOEHxyMKAyH0u5shktjNXAa0QCnlIvydMQg9PnsXfHB2QV6Lj/ 54hVOua3d9zU9AreVbMh43bLwN93nkw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC41F60FC5; Mon, 9 Jan 2023 10:13:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5FEEC433F0; Mon, 9 Jan 2023 10:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673259213; bh=bBwhSeT+JGNEfjV7E00KqOlZWo3oUuYiuv0f29tscNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s+SOtO+j04XaDuEXDRO/osmTvKXwZ5L+qemianRk2qVVN0LSKeW4TRHr5P6SHI8lg SUmD5jmkaA766mzP8FmD+oLfs42KvxAu/wXtZJpJnPghpV0bOibdeKev4jZhPnimO0 2P/rnm8OJa9b3kXSav576snRJIH0ovlx/gnBcBF7S6+cKMEupiZNxj+UYu3fSAQ8Gl 4g2UwNO/OJsLGh61sy3rjXhwPRRvetXP+x2PopakMu/slqthqDbes2mHNrfb4P4aNI 4AXBPIGtX7/4LCS/w5FPr0qv0PiEuDQgHTcsOs8x3rcC+Eb1965jy5LiwnoixeC98N CR/hIP0BhJ7AA== Date: Mon, 9 Jan 2023 12:13:25 +0200 From: Mike Rapoport To: Alistair Popple Cc: Andrew Morton , linux-mm@kvack.org, John Hubbard , Ralph Campbell , =?iso-8859-1?B?Suly9G1l?= Glisse , Ira Weiny , Jason Gunthorpe , Christoph Hellwig , Mike Kravetz Subject: Re: [PATCH] mm/mmu_notifier: Remove unused mmu_notifier_range_update_to_read_only export Message-ID: References: <20230109012207.79457-1-apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109012207.79457-1-apopple@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D96FA120002 X-Stat-Signature: 4yjwaw9pwt74rmixda7pigdeycqj3wqa X-HE-Tag: 1673259214-633077 X-HE-Meta: U2FsdGVkX1/7nnI7wE4sL7aYL/m7s1p31RQ0Y10nH7kSrs2u2E3ngDkaDVuez2nspfUmJqafMp09B9GkVGCasCqbjOeSiyl0oe77pV3OSEAn6iqMSOkDKCFbvTFr4o0jjKy5eqhnGYSfg7VDuJ0wOs3qT19G3z7I7eIIXbGFwIak6Z+Zo3nZ54aaAuyGAMXYrkaIZeZtoFRxMEjXw4N6kWpmKnPJSSqvqURlpw/hZSGqvOrYmQrH2PY6pKrm9QgCEmlEbXWY6yc2sxDPEARqkYOYxMQ07T93zdKyB0YYe+AJbsed3Ku6GaPxfGPnvh1zDpd3Ee9QRb/ELEcsdW5QcApgA8bH/LjYNX7jQuMm8qj65nU1t9uDCVfxxW8LDD/GrqcGjBeIh9l5Vq/5coulKlprcadjx9Vn46ZSkXBJAubUY7ncONcry8JgpnaV/fCmufWA1h4Xv9k/Uxqrhpsjlm5AP7LP3UNbh0iyvhVN74vwGXfEMfZOW2N2oJC2x0hzxCqTeWK4H4hwqFOzBAnjTRTcn/Oiop6mGnjskUkyzqUrb4IqrLg0xbj5c4+HlGrH7wLKxuCExorRG9I19/x0hCSPJSD68N2cGT573F1Uqayl6Tc+iv2mm6B64m+SjCDOnsUCfIcxVza8itSZrjCYf1ccp4Auic2VfhiXzakpryRor7LSK+X23P/KjMQDFEMRE/1wHsoqO4k8sfiUxb4cPZbvwG1wMqN04XAHybF3ZZyxNrl7F8KuytSSooBXdIreUSpl2Csq5kK1SC7/r2qINJdo3cZYtNM/1zc/SsT19EUNNKeSQYyPmQDNpB1FIEwxxrCV99A4J2jChHgXFewDu+SfwqUc4Ao+/pt+gsaLbL0ryPJmSEqtaJDzKLuyAy1WgJmEqPGUKp3CQ07wUsDPq7KwykAUvHcAS7Qpjz3CoLLM1AUG7zg3vtDTeW+KdN4XdkYVIGI9/Y5c5nFDvrZ ylxYEmk6 SxgEPhfrLc/0rqn+zWD62Ho6kQJ1spY7uMyGX9++k9nFytvXVHj+qqBEGco7JBgwP9Uhujrouror2qoo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 09, 2023 at 12:22:07PM +1100, Alistair Popple wrote: > mmu_notifier_range_update_to_read_only() was originally introduced in > commit c6d23413f81b ("mm/mmu_notifier: > mmu_notifier_range_update_to_read_only() helper") as an optimisation > for device drivers that know a range has only been mapped > read-only. However there are no users of this feature so remove it. As > it is the only user of the struct mmu_notifier_range.vma field remove > that also. > > Signed-off-by: Alistair Popple Acked-by: Mike Rapoport (IBM) > --- > include/linux/mmu_notifier.h | 2 -- > mm/mmu_notifier.c | 10 ---------- > 2 files changed, 12 deletions(-) > > diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h > index d6c06e140277..252e44afcc70 100644 > --- a/include/linux/mmu_notifier.h > +++ b/include/linux/mmu_notifier.h > @@ -269,7 +269,6 @@ extern struct lockdep_map __mmu_notifier_invalidate_range_start_map; > #endif > > struct mmu_notifier_range { > - struct vm_area_struct *vma; > struct mm_struct *mm; > unsigned long start; > unsigned long end; > @@ -519,7 +518,6 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range, > unsigned long start, > unsigned long end) > { > - range->vma = vma; > range->event = event; > range->mm = mm; > range->start = start; > diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c > index f45ff1b7626a..50c0dde1354f 100644 > --- a/mm/mmu_notifier.c > +++ b/mm/mmu_notifier.c > @@ -1120,13 +1120,3 @@ void mmu_notifier_synchronize(void) > synchronize_srcu(&srcu); > } > EXPORT_SYMBOL_GPL(mmu_notifier_synchronize); > - > -bool > -mmu_notifier_range_update_to_read_only(const struct mmu_notifier_range *range) > -{ > - if (!range->vma || range->event != MMU_NOTIFY_PROTECTION_VMA) > - return false; > - /* Return true if the vma still have the read flag set. */ > - return range->vma->vm_flags & VM_READ; > -} > -EXPORT_SYMBOL_GPL(mmu_notifier_range_update_to_read_only); > -- > 2.35.1 > > -- Sincerely yours, Mike.