From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD1BC54EBD for ; Sun, 8 Jan 2023 21:19:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9292B8E0003; Sun, 8 Jan 2023 16:19:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D9168E0001; Sun, 8 Jan 2023 16:19:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C7708E0003; Sun, 8 Jan 2023 16:19:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6AD448E0001 for ; Sun, 8 Jan 2023 16:19:30 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 35F89AA1D8 for ; Sun, 8 Jan 2023 21:19:30 +0000 (UTC) X-FDA: 80332898100.14.83B30A8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id C9944C0005 for ; Sun, 8 Jan 2023 21:19:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LwRCSfg4; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673212768; a=rsa-sha256; cv=none; b=R9Q70XGMnEBL55uFq7RtWr0M898qbB8s5Eg/tOv2OfhV8ccLUGAma5MSAOqIa/fT/uHpqw oHKBv3JvdIDjTphtrOZXCqS7m80ESaNIR0Xn/emU0JkQuOV1mvmVKgQgwurqbtz/rKrQBq lbS6ru+VF//TPEN/wiRWZXTOMtISwvI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LwRCSfg4; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673212768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=smtf3b6c0YiLyegeGcE2QFdIpMIIUxY2QjH9VIZPeqs=; b=eS8oynFXk1rKYFK1qq2S0a7XDtxQ/oWG58fRwyuOhIkAhL2K0Ckr6DrXALE1didNuCRx4V n76aFjfxe8YJ7Wp+Dl6Sy3sF6jj05ACqfg7b1p0pXoGEfMfn6vuiVa17frNXNrP26gAM/M keVtxEPjfj/vJkBtj0i8xbyAw/Ol37w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=smtf3b6c0YiLyegeGcE2QFdIpMIIUxY2QjH9VIZPeqs=; b=LwRCSfg4lurhfJplbjaoasx+AK i9NeK9Itn6mhZyaQBDGH8TsyNknvvOz6OzxmWVVH2jlqc/3k/698PgjVLLVYaPEjFaZdELofoEm8c w4wtquN4FxNlPO/Tyk44scz4/CWeWCVw2QzvSZmJwjvQ76VjjJJkcBRdiiH/CGf5OOsRAAp5NVqPF KodMj3MQOePSeDYwwAhqMQA7DCoBX9hicB1aN6THIdKISHSSVBQVgxGVetK6Oy18dlTXXLTtq7xk7 wQSlhxVeURFfEUK6vyKbQgKfXUvkaRIuXkjROCzDp83BpM0eSnokETYF8b+nY1OpbJXqWeD3RaIoF zcJMPD6g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEd4c-001khF-Q6; Sun, 08 Jan 2023 21:19:22 +0000 Date: Sun, 8 Jan 2023 21:19:22 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/7] sysv: don't flush page immediately for DIRSYNC directories Message-ID: References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230108165645.381077-5-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C9944C0005 X-Stat-Signature: zhk7kk9nkrenzqcapx199i1d3emb5wek X-HE-Tag: 1673212768-335372 X-HE-Meta: U2FsdGVkX18Bu7YkGY6fRF84ReMZrT0SqReX4RJEnUEEMowD0gK3lhwqyrrr4AoaRHdIGjhdRlDMs/HQ8AIjzDW/SmvqgTUaXoIDlyiHdwCpH7KSx6OjoSH9GyWDfsadrYFo/UjSpMVCJnoAVfingr3U7MbOUrMhJaoa0q8+N3djF5vHJr9Gc+jM5WNEBH2miBDqyGG0VNIl857Tw/DlBX+3Id6Vd1O2Wt8PZoGg9fPxNfNDwPFd2GxFYpkQrKGJmqGrm2/JuuHs33l7xkRT7tMc8PddPHv9Un6ELAmjC4RdjvFm3a4ZDGen3gI/lS/uiJBo/qIDPiWbjXn+WDVOu/FoifjkHveyqlQkRy8tIobscIlJVfJsOiMvti49dBZKsqPihWVh40OQ/mFWkS7mJkRqcFkFKS8Bno2Krr58ox6bdtUUSBGiGtBNnOLgyMVKU9cr55FN6KN/jVtxCBlzdWZP0crAwFFo8us2Bw8zUz0BH2llA/7rlxxH7skIyEVX2G2pJIOgx59+WLWjmV0ng34O/iX9h94zMVeGQHabfXjUcMv4yYU570T2YTVDvQkzNrXi45FYvLRHqSshalj3b0wgkmhMid9gF7Tpet3F94OYM9pDir0lKxbwoHMm5jLOpS3nOiKtc+cDcfX/IifTItKeWXDJjsRJf/pK8uAZl+4wps59Mv/OY0RWAKT0SUuT+S+ZQ/3pH5rIZYTDvoevhuy8nzQJ75AMm7+uKNVmCvo1EoE99W76IKp7iGANKsxwwC1FuMA6toBb4AJ8Jk+//REmzRAtQlm9pPHXST6NI4rvWAQ/HqhGp3fgpJ3FljPhJgkl8D4olkLiRCLFZTv7hLa9R/mYcUuFSU3T6Uf30Os= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 08, 2023 at 05:56:42PM +0100, Christoph Hellwig wrote: > We do not need to writeout modified directory blocks immediately when > modifying them while the page is locked. It is enough to do the flush > somewhat later which has the added benefit that inode times can be > flushed as well. It also allows us to stop depending on > write_one_page() function. Similar concerns to the minix patch here ... missing assignments to 'err'.