From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B2AC54EBD for ; Sun, 8 Jan 2023 21:17:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B4F58E0002; Sun, 8 Jan 2023 16:17:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83E178E0001; Sun, 8 Jan 2023 16:17:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DE8D8E0002; Sun, 8 Jan 2023 16:17:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 59B1F8E0001 for ; Sun, 8 Jan 2023 16:17:34 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2CFBCA43BF for ; Sun, 8 Jan 2023 21:17:34 +0000 (UTC) X-FDA: 80332893228.24.FBEE3C2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id B5890C0007 for ; Sun, 8 Jan 2023 21:17:32 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=byUKNGet; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673212652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+fTNevAqKk/KH5jQmB577WyYwIjJaGXSYo1Kkw8//U8=; b=UFSVUlJ4+alk6ZnExtWQXWmQFX7Z94bRLCw964pwITp8Y2V8kNOE4GDW3QpyX4tDzE3UXk Z01lNX6kfsNBqD+rzH+aQ2o5zUNrKqynQibubEVO5ciyxhp9s+664noxhMB3NiUyorG6sb /aU+k4Jjz2M2Om1v+SDx49vXv1/j6HI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=byUKNGet; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673212652; a=rsa-sha256; cv=none; b=Ogw/1F/Gc/ouH3DfqDEelkkClCLkyHGjiycAtMOkjCCDZhtEDTmzY1TaWBGTZBZW9jZw/K zKP0cUQa8HQxt33gk3Zgb0HI/IH8IWsI1LM0GCqK9Jc+/axbaPIyWuEp3nozIh+kZwXXHU RVuBv3mGNMmovtAfBPLsnXDIhk/xwSw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+fTNevAqKk/KH5jQmB577WyYwIjJaGXSYo1Kkw8//U8=; b=byUKNGetm3skpB0osIZdzjmVcj gX2dVF3m2fMEnkOaV+kh6gvARpBZ7AFyfxgY+L1iGfpdfGfjVTHL9xxoF4NlkjqYeIaQLwOSl+Mtl 4Sa3NFJyeX0+o+I3BQS8ART4Ltabft8TVIJwxwfwQ9nMYccsrJmcldxE+CTmKur3Bs+uvJ+oF9CgA aPIoqFVfFK2QUuQ7BDYMSYt74tm/fN5lm2i7/Za+hVv4N+RLcV8ktrebKs/bSETE8RZTA4ZxkhNE0 u6tAe/HAvZcOUtIpTcGGV/A/eQ1GwLN3mPr8I1VwHlpv4keaJQ0vmIEQNNgsdYSo1bq9yynXC37jl Eu6oRbmw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEd2k-001kcp-D4; Sun, 08 Jan 2023 21:17:26 +0000 Date: Sun, 8 Jan 2023 21:17:26 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories Message-ID: References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230108165645.381077-4-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B5890C0007 X-Stat-Signature: jpbparg986wp4rzpm8j4k9jxgm1ffctp X-HE-Tag: 1673212652-808696 X-HE-Meta: U2FsdGVkX18WvDF85EEFBye/IhahQRLdBAJ/QUmSkps1cjRJlseta2CbAfki/+J4bvjZoMFpHh/tVmFMtCWiw5Da+gre+N2ekFjZABy5jjR97GveXEl94xiMDraxBrSekMjN4l+ULWCatyAGHr5Xyb8ZS4dynfslyAW0/lSp5sBSVSQbWtwEDMgfUBI9G8gwQECdZIiXbELY/VMrC+Mv0Me3NVSCk4FyfbTO+UuYI1rq7X7Zh/4Z+ihgGaw/vhdGGAtMYfqQFeX9GEeN+284zKZI+9JG9vZ2mt5YlC67OL72/5yQNWx0km2pPYDqKUARNCnXQEVoq1GpDtMFGmwuqCeFRsqE+H+xvlfPgZKWuc2ILq9jUxDPvTGP5/DQq3Bhe5A5ZNLCUUftBF4MDPJnUl2UCJnSW1IeDDZcWwcvyfXosCM1NdXYGylOfLHPKl7bl4KoPFqqYAUX1i098DcsjI2+8MSdsuXcieI4OkSBqF7qxyYVXGMYP6wYGH5J40CrX6sXd7FjyhmRz/nT3X6Bzl1c8IzLFP/4RRu9l3rTslcnyeXbL+JX4yK5CfIhdga0HE1/Y2cRlMAylVwEnfdJTTiBerDrbK8cXDy3jwn8ny/R2gsyJXuLf3IWTRh7EO56ZSJ0K/ZGsR3upwB8fRmYG+bLVm3FhBkwKcOcqC5lBb5F93PCI1RI/UQw58Zcev9xZ53kcRfX3z+hQjUz73G5a6M3KarlaBp1+u8OKZyZnqPzZK7c9FC+Xj6oBn2Qqq4HU1eFSmptRhsrQY39EQpfRdNI42SCmlFq2x3d/Z1stakxKCGt41hdntBSvhDkbX5B7wHghp64ktJw/F6vBUs8IqhF2jRcIJ0uZ/mFv1QR4ew= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 08, 2023 at 05:56:41PM +0100, Christoph Hellwig wrote: > @@ -274,9 +280,10 @@ int minix_add_link(struct dentry *dentry, struct inode *inode) > memset (namx + namelen, 0, sbi->s_dirsize - namelen - 2); > de->inode = inode->i_ino; > } > - err = dir_commit_chunk(page, pos, sbi->s_dirsize); > + dir_commit_chunk(page, pos, sbi->s_dirsize); > dir->i_mtime = dir->i_ctime = current_time(dir); > mark_inode_dirty(dir); > + minix_handle_dirsync(dir); Doesn't this need to be: err = minix_handle_dirsync(dir); > @@ -426,7 +436,7 @@ void minix_set_link(struct minix_dir_entry *de, struct page *page, > ((minix3_dirent *) de)->inode = inode->i_ino; > else > de->inode = inode->i_ino; > - err = dir_commit_chunk(page, pos, sbi->s_dirsize); > + dir_commit_chunk(page, pos, sbi->s_dirsize); > } else { > unlock_page(page); > } > -- Aren't you missing a call to minix_handle_dirsync() in this function?