From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B0EC54EBC for ; Sun, 8 Jan 2023 21:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC5EA8E0002; Sun, 8 Jan 2023 16:13:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B75D38E0001; Sun, 8 Jan 2023 16:13:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A66188E0002; Sun, 8 Jan 2023 16:13:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 975468E0001 for ; Sun, 8 Jan 2023 16:13:42 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 67FAD160900 for ; Sun, 8 Jan 2023 21:13:42 +0000 (UTC) X-FDA: 80332883484.02.7318BF5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 250D6180003 for ; Sun, 8 Jan 2023 21:13:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=McX6ybvW; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673212421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D7a/bf8y+hnf1vOEi6y8Co5HNDUBH87eZ629Edw7Kh0=; b=k8pgSxdZxDZZ4WSJLa438tzSw7kdmPBSJpmYRPJ9JmaDUSnhYAEpsgqDaqoytpLvNYiYq6 Hsnu0OESpGtsnnD/5KDf1D1kylL6vW1VMQ+qBYBc2IXyQipBMJnmbn/AdpIswvb2QqkXHC WyKZS1hVJCPWAufpNK3eAJE9ipVfRAQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=McX6ybvW; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673212421; a=rsa-sha256; cv=none; b=SUIEXDtYgwYm2OVV/5ZoAQX4PVo1ZckWJnYZ1MH+UIQWtFWUefN3TScxyXalYpOyM/c4Gh arPEbwE1EumlMBj0Hp9wj9KWHraaXieDwCObBz544pejMwi05hRtuykeX8kkRZqQLgtbwu K4dRMkC9ZE9n5YaRYkFvPdU5+T2h13c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=D7a/bf8y+hnf1vOEi6y8Co5HNDUBH87eZ629Edw7Kh0=; b=McX6ybvWrIyBCWgMTSn5LSbdcf 7APZ7yKaIVqF9WLPgmBfFbu/wtlzNoBbY3ROyGkglp13HbeM8A3oRGzZ6+BMUEJAH9bUrRjg7h8j8 jlnuRAO9JiYK8ahCVcAo0iRZvTw8+YYuRObTqFzqJfpZ5rtMal8H/6UlHDqwwJ9BjjWDY6MY8Um8Z RCcqyZQ3VCP8EXQQaWkalNAy69z09vzVgP8+buH64VUk2Ecs+reZ1w8LJ/kyj4Yx6OXcjCYXMg/bc tRcKu3lg1ysgOGu92TcqM9e5zmvEvQWgQzxW0kHHAQ0eTN+XvbnRUBtGnPKh92rTN4Dj7inDMKYkO KwSoeuvw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEcyg-001kSO-Ug; Sun, 08 Jan 2023 21:13:15 +0000 Date: Sun, 8 Jan 2023 21:13:14 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/7] btrfs: stop using write_one_page in btrfs_scratch_superblock Message-ID: References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230108165645.381077-3-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 250D6180003 X-Stat-Signature: xw3g1oedspom13yjqcrqb9awjsy9czz3 X-HE-Tag: 1673212418-723555 X-HE-Meta: U2FsdGVkX1+EIMzh6ogUyFf+TQK/Pig7WawzFaQKEd+pRmbqxDai6vxVviWzUgkoSwtjbONlxYnf1r6r87NLDMpJiPmcARKsqZNrjZfkDDeU+ouTklJh7TvCAc/98sAzV9lKr2sFIVGS6/8fApDm17B9AeM2q3J+FP8qZWutVNYGKS2bHmc55jRjkqgemfM1hYpLWwUQVaiH/Mj4isBAIimMw/JpU4tZkmDa5yLwqQ0GJGsjeZVIsInAHzGAlxuGqXvS0fNF33IP2wNCR2iq7Zq6t41kWZ+jxzYaBqgz+gy/9InDLEN6TFMHtOpRuqhjeJhUe3dDywFwBA4BN4dFKXEDJMv9OJdv/GviI0CYaAioZyTLgzvy3jnGOxUyje+3dgKnIJs/2tpmZQ+u5XJwjtlXAVE00Ifb/ny38WPwjHwQvt6okjNkfh8CQVFbdmvny+lkgXqyRriIgeeRbtYaYTgd2qAm9XSlqFA1uwnGjbP56ATkMIip/xsu/bZIkNortek2PLIGefl0DuDZkOTZosu5BQAp/bQj/fI4MxOwtPsJnnWP3+xHpx9fYK0DM2NTktV45itSK+Ujt7IgSIbxmgs5pmYCZ7pazSKeYq5PN8BjrB3BowSfvUKfD4DarzP3yQI4nRkDP7ZSRx4hKlPF2IpUekD7mxl7LDWbRIP6hn43q/vwTpGAx9NkFWXsNMEkHaL6Gpkiygo2iKIc2FJ5kcEaYzNIDiRXzC2ldstTJdKgzNxDXtZfMFUK9C4fPSae5WmEPijEZywJPlju4qfi5+TqkOwuPaqBzUEMqE35y2vdUUPQBiQlWIgFjNGMhCv7EsvP7rTuJ6jLDpMA1DpPoUUK7r1Xmm2KWUciMGZIyz+zLc8j7gA52dwW7o5iByDqflWMqeAk9qAI9CcNfxLwAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 08, 2023 at 05:56:40PM +0100, Christoph Hellwig wrote: > + memset(&disk_super->magic, 0, len); > + set_page_dirty(virt_to_page(disk_super)); Could we make this: folio_mark_dirty(virt_to_folio(disk_super)); Other than that, looks good.