From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E7CC54EBD for ; Sun, 8 Jan 2023 21:31:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6606E8E0002; Sun, 8 Jan 2023 16:31:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60FBF8E0001; Sun, 8 Jan 2023 16:31:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D8428E0002; Sun, 8 Jan 2023 16:31:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3DAD78E0001 for ; Sun, 8 Jan 2023 16:31:40 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D3DCCA011B for ; Sun, 8 Jan 2023 21:31:39 +0000 (UTC) X-FDA: 80332928718.11.0CBC764 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 6D0444000B for ; Sun, 8 Jan 2023 21:31:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="dm/cLFNa"; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673213498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=++R3apswKn917ceG4txQXiZ1LJjLtj+nBEmEVXkWhS8=; b=gw43vY7xd5pP9eKIZwkcXTql+FN63idZGCsrEZTnvutPnkzj8mukXePzqPBSWqRZI0WAof 3z4xmD3hb5qzlm7uqcnqvGN6ui7cCmvr3HPj8etWkyw9uUQMFQNM9V9i6697cLSY47gwZx AwUsaINB2iwcTpJJGWzXSwYXGXNwP9A= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="dm/cLFNa"; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673213498; a=rsa-sha256; cv=none; b=MefBfHs3J7kf7QX6AqWvwZGfK5oTkSwwwC0eVTd7TxU1RjN0Vu8Em4TDLK6U5Dyy3oSEqI 96f8f2BEgoZZ+Nymaad1qHw7HaIioD0v5VMdwP52ca0BCVkiSOZxEtYF4a8QaGREpoc22x tPNvaL9kxeYW4Xsq6NuCOZC1LQ+rz4Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=++R3apswKn917ceG4txQXiZ1LJjLtj+nBEmEVXkWhS8=; b=dm/cLFNaKZAOrFlytHsOvTk2Jr ez8yteUWEcM+9Gvjd7lmrZYc8XtHwp9CxOiARQuiTXyFgAsjzy3BvOKdi6Oqkw4uYoM5bx9Zhquvd CfqTrxz9e1zrOlo3uKseyW7BDZTUKqM93uHTKqr+TKAQdIWYJ1GpWrZKrdQzGnvUt1TA+wb8u28/V qfs/1IGoaHoVjwdS40H5YXZN03jNyFQ5Ct+IpTy9QHadGXXKZIlrIjyAJVKd/VvXA+Njjonyf3h/h mavaFrnmkentZmOxii9RnnHf+WPa18T290G6Rs7XdgCFtfqKtR3EsibJzFKgmY2YydLv7S0chGUn7 WdsGGqeA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEdGM-001l4v-H0; Sun, 08 Jan 2023 21:31:30 +0000 Date: Sun, 8 Jan 2023 21:31:30 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: remove write_one_page / folio_write_one Message-ID: References: <20230108165645.381077-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230108165645.381077-1-hch@lst.de> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6D0444000B X-Stat-Signature: dttwu5faqgqbyezugw53b8psjyfj5ym1 X-Rspam-User: X-HE-Tag: 1673213498-859952 X-HE-Meta: U2FsdGVkX1/rF3liq+nvAFMid9dpmclr9GS+BgxvN9Jqs7UsTyxtWJOD19/3bLAWWGw1PB69aWkmqVVMY+PXH81Xj20qaM6K9Y37pIRvQ9HDO4x5edlIGxSlbz8AXj9pjZUO+jjUlSuJBXdQtqmEDDfN6ir1nY0WmJjtvkIlgdS04NQIFbYHxouAGNmSCv+aOoUjcYCwhWODB5Vdt6d7zG1OObIhz+yXPEuelP3avg5tqsTFTZ9lXjC7ZE791evmNnUGk0MGO8vBm5AqFPdYkXgLaU7BIrBPItnrgQ6DOdmkJtXO7CUmd1PBSnwZ41WZfismkKEMmzAqFeJc64sOy5T/+mxoiRB/1maDkyY+lXXePtHhnkrlF0GmHH3ECvHmrHPOt+P3TG9ESPCBoj7MoatiDgSDuBEz8V1XnUdRAiKVXoTXeAs+k2a+3Ef0ZtlRjiW4DyKa7fjzHy7kUG8UeaGc1aknyn6cXHAXNvcSG7l2xLqURWAYiC/unbXddOMkuobYC1QMCfSDi8iXi8BWTjH+tF0OjvGjZKaVn++CtHM364LeKqWYK+4L9rdcNvKY5zs+amS3n5MrIqgiG/7ic6I8jYENYtBFcCfLNmA8fz43/ETKxWIvUfQJiKJlscVLTXBtXvRwqvRCAr4oGdGDVHdiXAk8mOgb2wFUXRDtPQzLtorbU+6D13tAa+/V5chqve5fQTzxCHJwzaMmRnGiyeN6AgMU+HWpTYLm3ZXIEZk86qK4BwYx3NkF2JdyRt0XQur4h/8WhgberQi99wUxzz1tZGgu0CY6Y91u9f6bTZuSbmmNO52MRubgkDmW1eulteiO+0GO29PCegYWWr0oyxArTSrJ/WDF4b/4jDgyOEnDgdUbtY319QaXGVtTT4vaRxxQjtG95m1mYjJEZl0hZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 08, 2023 at 05:56:38PM +0100, Christoph Hellwig wrote: > this series removes the write_one_page API, and it's folioized > implementation as folio_write_one. These helpers internally call > ->writepage which we are gradually removing from the kernel. > > For most callers there are better APIs to use, and this cleans them up. > The big questionmark is jfs, where the metapage abstraction uses the > pagecache in a bit of an odd way, and which would probably benefit from > not using the page cache at all like the XFS buffer cache, but given > that jfs has been in minimum maintaince mode for a long time that might > not be worth it. So for now it just moves the implementation of > write_one_page into jfs instead. Thanks. This totally wrecks a patchset I was working on, but it's definitely the right thing to do, and I'll rebase on top of it once it's in. Looking forward to v2 with my niggles fixed ;-)