From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCFBC53210 for ; Sun, 8 Jan 2023 17:36:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00BCC8E0002; Sun, 8 Jan 2023 12:36:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFE2B8E0001; Sun, 8 Jan 2023 12:36:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DED438E0002; Sun, 8 Jan 2023 12:36:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D0E5D8E0001 for ; Sun, 8 Jan 2023 12:36:13 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B04D120625 for ; Sun, 8 Jan 2023 17:36:13 +0000 (UTC) X-FDA: 80332335426.13.91B80DA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 3109B1C0003 for ; Sun, 8 Jan 2023 17:36:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=FUO2WOCC; spf=none (imf20.hostedemail.com: domain of BATV+58c3238fb6e66237551a+7077+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+58c3238fb6e66237551a+7077+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673199372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uKx/6wNbKp0TIcFEhLz5OI0WO0orOz47Y6mrSwwiEyQ=; b=QmDOpDY/FdRB0yqeO4qPsyShVJGEBCcBdrF3vD5AzeuvBPAZyNB2Q8zeX/IAG+Iu3CaVy5 +wowsBzUCdfGK6ZSdQ6ja9DYwC0scRf0yDVeTTUZ7jUBOjJvotkTdZ+4OE5RkB/eynfA8q c1I1CuWW64IoDTqtx0dMUaSlCRHYiCU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=FUO2WOCC; spf=none (imf20.hostedemail.com: domain of BATV+58c3238fb6e66237551a+7077+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+58c3238fb6e66237551a+7077+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673199372; a=rsa-sha256; cv=none; b=6dIjv5kpc7ANP8tY0pNIqQldBnQV1RBnrhG9Zn8v/BSpBXCZoFEfWTXCqg1paikwIWyZyH a64JqKYl6Fy8MXPNxJ2c72FE6mm7s8r9+ifF9AkgJ+Nv1OIZpH1FXD4FFds5esQX///cgq HtpiRm9VGsijzAk+VigLSarVbkaXlrs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uKx/6wNbKp0TIcFEhLz5OI0WO0orOz47Y6mrSwwiEyQ=; b=FUO2WOCC5NyD8C6UPyz9qvRX1H XgVBb53AjH0CEyKrTTMcnLzi38cTJH25rYeBhkaRv2X0t2bkfq1cLJiNTm5NIEpNb4My3CdXIZGv1 OGxzNG3KLF9iMEZAW2GcerJXSXUqa5U19oiiwK+/yJ5wIHPO8Hl4MI/zdGSc/JjzFJTcm6EieDF5+ 5eoTHY7aeOwzuf+771xCGw1DhHwPW63o6qjj1HCr2kvrWisXHVfJ7Vo2AA4fkEeIa9zCMhrJ6B6I0 c56rMi3b892tWAPwwYwzQH3zdI4CtZ9r8MBsdUzFirEA9wE9WK97PA3+d982oH5cdSQXUnrc4ZYuG exQE58Fg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEZaY-00EepB-Bo; Sun, 08 Jan 2023 17:36:06 +0000 Date: Sun, 8 Jan 2023 09:36:06 -0800 From: Christoph Hellwig To: Lorenzo Stoakes Cc: Fenghua Yu , Vinod Koul , Dave Jiang , dmaengine@vger.kernel.org, Tony Zhu , Andrew Morton , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH 09/17] mm: export access_remote_vm() symbol Message-ID: References: <20230103163505.1569356-1-fenghua.yu@intel.com> <20230103163505.1569356-10-fenghua.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 3109B1C0003 X-Stat-Signature: 9rsntjmbm65bm5ibb69wxgncfxs8pd7x X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673199371-704000 X-HE-Meta: U2FsdGVkX1/y8MK+mzWmfpQEp8PlepzfOEMksHNDQLro0gb112cruJywwonWGZnc3ENaUV96KXlIUH9NPFvoE8MeY+PyS2zw+2aBs7Nm6DM7BiIyNKATyjh9IxK10T1CVbXfPLax7HSE6WcDnqcl8wCDUloeWCecSKgezIXTX3j8UOli5l7pLzDG4IEeIdfWVd5IQ74QL7v7HQ83HeBQEP5TCA4ji5yuABfe0Pj3cMnDTkRvAUXv6Na6YgUwXEKB7czXMgfQOjAdVFjeMRqHp2JMnOUpqVNi9b7bTuvwcqBuyI8u33IGMvgg7mZzYizs8A4glZp03tUcfRx7lBjXuTmWbW8g29O2Q0C7O6jNU7olTncl62ZqpG13YBqY2h1PvuIZl3BAHci+v9tBwebICMPm/qQjlaCMuuxwv8RyfzG3+swWqmlT/u6AcXxciqxX5Ji8suSAQKFgyne3L12qZIFHc39L71PHV+EwktpE+9ygBK6DYXl1wTy7xvYit9dc7Zye5IXB+1daaqil8yuuW9UCKHcYgg26ZU8TFrOmMRqNvnONTRCw9wkwQWYxZx6naTReuSK/HfzIdV5K3CB+8C4n0d1uKOmMbXtNFmc59nKhc1LatMQI+W7w+2BpgZFVF2iNwEOrcZJx5PkFzlehmv9cR8HyTmu/uQtA91Dm6QMzjxc/TGq8TVAimGDqaX9o3l7JJPha6qn+5VPIXwbtmjxQvXRyoO5ue84TwG9sNmg9Ys4trDlwwaNArWa+FB+POQgBA4yF4bC77ksNRfSKJbpiKT2G01zywDFAYn3QuUjWoIlLcihmC3oknAc0iJfB7UR9cU1r1WxIkfDla2CUCc7MQ+iFMvVOi3z0X+I+/+K8VaYWva9q6N4WBrz8dNLh/JsOumdbNC6k/0RNZS3AUXxOS/FmDR6z7ZLyNjgOz/+zX7gp6WoYMm1nUiYgv2sYnGbLr+YXrFB2kJYoMn4 KWMA4Vvu sERxZ38BW/sq8TSrKgOvVfqfi0QiPb4MsO3i3L3Rn1EtYAPOUe8qK1AUrqrl/e8gxGaEeV+xCjqNcaNyT9X/77BeJng2Slx1p2sOmPPsZsmYBhb/eGPEhE1U8LcVAzfjydkcKhhCT1W74Faxtn9WGSNd8r2bhxMX2Xb4CkESJ5gjftsTao3xc5dxbVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Exporting access_remote_vm just seems like a horrible idea. If a driver needs to access a different VM from a completion path in some thread or workqueue (which I assume this does, if not please explain the use case), it should use kthread_use_mm to associate the mm struct and then just use all the normal uaccess helpers.