From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E58F0C5479D for ; Sat, 7 Jan 2023 01:31:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F7968E0002; Fri, 6 Jan 2023 20:31:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 480288E0001; Fri, 6 Jan 2023 20:31:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3489C8E0002; Fri, 6 Jan 2023 20:31:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 217528E0001 for ; Fri, 6 Jan 2023 20:31:02 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E9246AB5DD for ; Sat, 7 Jan 2023 01:31:01 +0000 (UTC) X-FDA: 80326274322.26.3170724 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id B17798000F for ; Sat, 7 Jan 2023 01:30:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PZfCfbmC; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673055060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iUFnnXUqgMwIg2qA00uRPnlekCgES3Ipud2o4OQ0dCQ=; b=j5X75/Z9QZYLlnIgi3wp/adSraBobUtw/H6kyrEFZB71nLWiwljFzXX+b18+I5+/g8JIx9 bxms5HhBj1fW9aaVMbsjMOyeGItptsgSZrfRBrqf1e7sTeJS520dQ5p151rd4bsMkIYQ3/ Q9mAPwcEISs2sJ/TWArnI8Suq3xJzlM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PZfCfbmC; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673055060; a=rsa-sha256; cv=none; b=dj2+IniGs+nQzfWJbmjNLVTXrJbPj/+JTqsbNtojn2Xb2KN0qsrHWFvvZ48tNHG6O+20WN aWCSJ0cDjEbgNUO7afa3OVqukRCoIE7J2F8iFUVQnhxdhARqBNEicAECHZFbd56UtMbhMV y3He6WQj42WOVA3NxF/6iqGjLgLkQU8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iUFnnXUqgMwIg2qA00uRPnlekCgES3Ipud2o4OQ0dCQ=; b=PZfCfbmCnVy4+gQSFnFUcJt1rB z/1suDbY3soWCF+/jGKRCigg9n5MToaGpmfusJOKoloSbH1q0mQmDkPoaMbAXIDAIYLWhfnv0SgFd kJDFqJ/YxFRS14jjuTSDAdMj6nGUpyy6EsuFa84bQPnvNUDGyFE8KzVzA/Q7v4yLGAspw9EJ+M63R b1G1TGHL3wScfi3nhgbE3U/EU02CgoPXgXGCqwdDCONtJVc2uQZsGUi3+je3ocwRPMzJXz6z7YGiy gOvRpiljOwSeWIzzmD1QoK6toPMJZipQDY6zj+TmIVyhVCj2k+zUhJpSHFFxaIntC4F4afVArzp6k kvfXRDuA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDy32-000AF3-GX; Sat, 07 Jan 2023 01:31:00 +0000 Date: Sat, 7 Jan 2023 01:31:00 +0000 From: Matthew Wilcox To: Mike Kravetz Cc: Sidhartha Kumar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, tsahu@linux.ibm.com, jhubbard@nvidia.com Subject: Re: [PATCH mm-unstable 8/8] mm/hugetlb: convert demote_free_huge_page to folios Message-ID: References: <20230103191340.116536-1-sidhartha.kumar@oracle.com> <20230103191340.116536-9-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 4t6cdo51imyed6n981hwj3kp1xpjankw X-Rspam-User: X-Rspamd-Queue-Id: B17798000F X-Rspamd-Server: rspam06 X-HE-Tag: 1673055059-959035 X-HE-Meta: U2FsdGVkX18YEtaVIl84E9PswoAb9eTB9rg39jVlsc2GYLNSxyYDxFu5I1mIlFNlzAVYUeGz8vkxVIMFWlvGpffDaYmz06xmpkE0XknWTVr4qRf2HpxO5mGZa7FwOsHtfociXK6mniaOUJO1UeJwwjnfzRIB1OU67zgv6/TDm5g+7Vt6BpRT+boyTzeCoAt4M82hjyQ6vdqf404Q6RyfJAAAkjms22gjMGFksJK3Zb8YBw/gD3KD8P1qA++i09MdzRaZkBcrC2Ib3JS9eJwFQseDEpLfmgHoPVdMjHKTobArDvPJuPmxwYijsgFCzSUqhRfzs5HPQd6a56TDHmullqqDDnfycRrLtYJl5FAeCnGNyC3DL5OLHRKbjglaXiInV6JpOwzLqkwCHwcnHC9weHAOM9uhcOPNbSjfdvlUyJX5brczO3D8jqFdni6J/b0LsVUbLCNPtEji+HTdH0iDnXffFvz+qFMa0w1rdWsyFZ/IsbXPgFsumX6J1K8jnsVi6g00JHcxZQZCOSLyUUX1AKtwyMMBoIOzWgNp1dIYa6YQKbUEZIX/DsASfBCS4AWDyr1gjFu3kyh2D7FNqDqFZLOBsnFphmzlo/6Ds4m96bzmHhiT6vnNUOgr9bztQcchUWUZ2Jyg/dQJixcmBxAB5MdGH1zdAp9LqWXZ13koZMhdGbsMqdp8SKRYWNgFzoEctr4CYh4yxe1o4WLf3gYjl+ODwHkDYO2Vwst/3BekA8HY4dJVhjMxggDSFiEk/zoSOgKGJlqMlXmjHJfbSoSsK6AqRxwMvVV8WBmeL2aGOBXhYeFwfFl/EUP4oUblQYmQVPvUugB44AEwyw2+uSZNOzLmPMj+nlKnnqplXGsxsxb0mtaqNaf1smNvRKpKF31iiCVcRIpk5pJ8Fz9MkIobfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 06, 2023 at 05:11:36PM -0800, Mike Kravetz wrote: > On 01/03/23 13:13, Sidhartha Kumar wrote: > > @@ -3477,15 +3477,15 @@ static int demote_free_huge_page(struct hstate *h, struct page *page) > > mutex_lock(&target_hstate->resize_lock); > > for (i = 0; i < pages_per_huge_page(h); > > i += pages_per_huge_page(target_hstate)) { > > - subpage = nth_page(page, i); > > - folio = page_folio(subpage); > > + subpage = folio_page(folio, i); > > + subfolio = page_folio(subpage); > > No problems with the code, but I am not in love with the name subfolio. > I know it is patterned after 'subpage'. For better or worse, the term > subpage is used throughout the kernel. This would be the first usage of > the term 'subfolio'. > > Matthew do you have any comments on the naming? It is local to hugetlb, > but I would hate to see use of the term subfolio based on its introduction > here. I'm really not a fan of it either. I intended to dive into this patch and understand the function it's modifying, in the hopes of suggesting a better name and/or method. Since I haven't done that yet, maybe "new" or "dest" names work?