From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B8FC54EBD for ; Fri, 6 Jan 2023 20:07:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA8478E0002; Fri, 6 Jan 2023 15:07:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A581E8E0001; Fri, 6 Jan 2023 15:07:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9468B8E0002; Fri, 6 Jan 2023 15:07:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8913C8E0001 for ; Fri, 6 Jan 2023 15:07:02 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5227EC0EE4 for ; Fri, 6 Jan 2023 20:07:02 +0000 (UTC) X-FDA: 80325457884.02.4A29EE2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 2AF9240014 for ; Fri, 6 Jan 2023 20:06:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BQ+cI4rZ; spf=pass (imf01.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673035619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=782xKD92TRBAnQZNDD+gjmN9QEeCF70KQdy4tyYVbXE=; b=yUXvvgMJT6Nxfkzq679DmdBWmDNzMS4Ika8mHAlCL0v9BWpV2BYPUeK9S8pdPwkFNY8ldX vR04w6DrJ1U7kQ/WB06iEHlfOHUNFYrWyDtZRmvQhGSKc/D5CeP7NT3KW/4XADrXtchMBM PtpaIfS5vIAKipTV8zqrs5SEpQlagpM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BQ+cI4rZ; spf=pass (imf01.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673035619; a=rsa-sha256; cv=none; b=LGr3Rzgxrl7tOEUugCfiZEDsOAOVHBO8svrupVWf8ux8vpT3daU6B32kbGiyIdezBpwBtX VaGXdTYah7A9c/WycUum+8Ea+8vla77RflCsesHAZkNcTtHfZyueGj6VxXjxMF6Z9ephE4 Mh+oYdLFwlqcNzulFrsvQFuo1i3Zmjk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673035618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=782xKD92TRBAnQZNDD+gjmN9QEeCF70KQdy4tyYVbXE=; b=BQ+cI4rZmIY4MBeXm0GMeeCrEwBPJNfgYP4RkJefsD/EUdfcaRuvcvKxMh6amY+hu5QMIx eIA6jQgtzpgv/K7raKsiNayMiN33l4qE1UEBAw6WTeb+g+Y3GnsnM1ITJDq8BWRmUswLnN 5oF01RQst1RIGIDSdADDy8P5Dbm+Tmg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-n3xa0o0KNtq6AzivjTnSgQ-1; Fri, 06 Jan 2023 15:06:57 -0500 X-MC-Unique: n3xa0o0KNtq6AzivjTnSgQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D0DA03C0253D; Fri, 6 Jan 2023 20:06:56 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-2.gru2.redhat.com [10.97.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70A611121314; Fri, 6 Jan 2023 20:06:56 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 1072E401B7EC8; Fri, 6 Jan 2023 15:16:23 -0300 (-03) Date: Fri, 6 Jan 2023 15:16:23 -0300 From: Marcelo Tosatti To: Hillf Danton Cc: atomlin@atomlin.com, frederic@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v13 3/6] mm/vmstat: manage per-CPU stats from CPU context when NOHZ full Message-ID: References: <20230105125218.031928326@redhat.com> <20230106001244.4463-1-hdanton@sina.com> <20230106150154.4560-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106150154.4560-1-hdanton@sina.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2AF9240014 X-Stat-Signature: 48d14jo3eg5nbsbw4bui5k5s6bccejzb X-HE-Tag: 1673035618-922600 X-HE-Meta: U2FsdGVkX19+Y2VzIztQmj+VWnKuKOgPPJpUWzY22noBfIwef1KSKPKQBUs8BjWJhOkjZ+7cFFmtwjt084yJBpRHaq4qhVf1ix88l3FL2rz59+i90s8koiW/Z9eYJn5etARZB/8y+FivvuQeBXkUrDT7W4KbEJRt/Lp/EZyctLhLhg9aZnSjkDJ1ZFLEzX0/BXekBTUltnOWEGKYSYwVwAZlM15BmzJeRbjWgt2bZQvjhiZBleDGYFoSXLpYCLDnoLLtcqUe7aU+S83cTTuMh2mCOB5EU9uCgyBNCBDdyGQ1EXeVSCKIHJN4bBRE/Lx9JrerS3RBjHLtfmz0zem/QxGF99O6KcY3bmsyrBlq1XgV32zp69wWRTXswagSTiMqkaVTdHzQ7kmNYAZybITEgRLCT4IFtO0LPh98x9rOElf6yVBFf3uChtPzu1gZ4vMcx3Qq5697lSkUise89xFGjNyBwurXgHBDn0N9HK85mDOPL5uQ9B+qAeVxP1rPaINzM6tcsKLpdoNxEqWwHCXj8jv9tCfR2zhnf0h9F9BT6pbPIfLd3kWdDJHN0e0NrTzqcWTAUYeUgdu9MXQoPHkKF0++ndeOwa98SVCqHPDU+g+H7Kc+JaENABbdAg5Y9nlSD/nuAqeNDFavWArrpQpfuotlGzkHKia4oXlQbbFM1gaKZUd3b+Q41Hb6vb+wCmYtYYFd33COEG1dIWpn+dEMcxh2l5H+4QFzKekUJdVyjgg7GP8Oac0IG0MhPMQE8eEHuXWALP3niU1f+WwvoAXlF/IvxKm5a7y4kRvG7KdqHox+6IPz2KNyzTMiJKCJ3OM5xXJT7tqwVuxjQsqO+AIGY1Id+BHshpHeAS4vgWzPkQYGpPASISHCmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 06, 2023 at 11:01:54PM +0800, Hillf Danton wrote: > On 6 Jan 2023 09:51:00 -0300 Marcelo Tosatti > > On Fri, Jan 06, 2023 at 08:12:44AM +0800, Hillf Danton wrote: > > > > > > Regression wrt V12 if timer is added on the CPU that is not doing HK_TYPE_TIMER? > > > > Before this change, the timer was managed (and queued on an isolated > > CPU) by vmstat_shepherd. Now it is managed (and queued) by the local > > CPU, so there is no regression. > > Given vm stats folded when returning to userspace, queuing the delayed work > barely makes sense in the first place. If it can be canceled, queuing it burns > cycles with nothing earned. Otherwise vm stats got folded already. Agree, but you can't know whether return to userspace will occur before the timer is fired. So queueing the timer is to _ensure_ that eventually vmstats will be synced (which maintains the current timing behaviour wrt vmstat syncs). Also don't think the queueing cost is significant: it only happens for the first vmstat dirty item. > Nor does shepherd even without delay. And the right thing is only make shepherd > leave isolated CPUs intact. > >