From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD90C3DA7A for ; Fri, 6 Jan 2023 19:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73C538E0002; Fri, 6 Jan 2023 14:37:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 712AC8E0001; Fri, 6 Jan 2023 14:37:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 601C88E0002; Fri, 6 Jan 2023 14:37:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 52B078E0001 for ; Fri, 6 Jan 2023 14:37:44 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 26E5540EBF for ; Fri, 6 Jan 2023 19:37:44 +0000 (UTC) X-FDA: 80325384048.22.F3E80BA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 4389C180005 for ; Fri, 6 Jan 2023 19:37:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="otkWWnw/"; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673033862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qd3gcQO/dsMwm40vSdJDrJs6x0c/1tvVsSQuZfcMBco=; b=i5KOgZe6ZnhnDQVlcCS30EHr9YxqIKu2DLDiykpDjBpMe7VqzFPCc5v+nesl/j95ne5kF5 Uzj6+PzTAFQP4c5igCofreVxc8OuE+brg78MPaDyk4dvFPlC4Zmz3iOcYWVAcU1t9kaAEI tthxcbsFy9BBhbg0if0Voa09wuEG/AU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="otkWWnw/"; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673033862; a=rsa-sha256; cv=none; b=qdqcP8qSspgAPN2MEz7HoHHtwFEbeZ2LpdJAtCqVX5Q19Vai2cAhZrfxrqEn4c05BAOId0 Y3hPVKdHqQDAlvZ6uoy67e/zPfTIgt19z+W6uJ//1VSbV+RKnIeLwtqhAXBfgbFSOCJZcu 3q9YkpDyvZkRpWjIItfrssOXZTuXe58= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qd3gcQO/dsMwm40vSdJDrJs6x0c/1tvVsSQuZfcMBco=; b=otkWWnw/kS3HCith14QNhH1zyy ZxVupAUZLtwaY8cmQ/tpvupVcu4V6wbxTsSdvqAsZpg/ZxpMBwOTB6yKoYz4I1qcCGzTmxB285DoQ VwFdxCn7nd+WeTLGzTbjf9hCk9HXUJ8a0HGFueHEXViZllUVG2Y2/te++AyLYjKsUjHliGmUavKqZ kwNRklhkaKFddZNcDVWkknOIyu6uas7zb2PNTwQAe5YKztPctyxQOH9rPW8bLc5WvMpe6bQTV8XKt Jf+ziobT/clE+GzYpaIK9DiabT8RzNCRVav9VRkJ985HL1N1juWu0Rl7egIgy7c/UFUbvaPXkbuao R9Th1+8A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDsXG-00HRj5-QG; Fri, 06 Jan 2023 19:37:50 +0000 Date: Fri, 6 Jan 2023 19:37:50 +0000 From: Matthew Wilcox To: SeongJae Park Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: use folio_headpage() instead of folio_page() Message-ID: References: <20230106174028.151384-1-sj@kernel.org> <20230106174028.151384-3-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106174028.151384-3-sj@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4389C180005 X-Stat-Signature: s46q6abi9expk1e6h5t34jb5gt9tz38h X-Rspam-User: X-HE-Tag: 1673033861-95188 X-HE-Meta: U2FsdGVkX1+DLngP3QhcPBDFweGcAm32rIpN6fOy8q9iCbA4qt8bD8yUJclU1kNg4iEwiycs94TIYX3FejEaTsa9km5Anf4c6eTNiNjXzNIUEklzA0p/LBjzkFclSd2tHn+XkBPQW5oMhh2d6s4FRSCjNinydCbesceKfOIE6e3rHsA9v8v3vx9OeK26Y5HW6PnNWo5EbjyPDKIRISEDXdKDy6/JnJhJFxIIY4J6jS6X6U9OOFtj6X3+xXFelfUBv1o3+AiFEn9l3qYrbyj6UUe/b9wVkjRN280eE+n6t5emY5L/xxj6SUPmBN9CCWAEvRk5u0IfRUhPY6NA1a2qdxZcrDJ5PhrlrnsR7WSgkxgIq1gzj0MEk6zqhaRrjCq8IiLKrBR6BvD0lOthB99CFkvUXlTGVQ5x5vHMWxCl19+lKQg8rsb6BcSvjzO31VA90q2GdYNdcW0n0MNvQ85wgviA+FeBB5cgkfJdaVyZr4lwZGcQWI7YitfvFK47SHxbR0Nk35q09WxaktWj8/c9Li3vtAdNWul1D+Igao7nhysMYs9DAJD5gV7bJFxwfqIYUQK+2k0ipSsRbPD51vNauInAqPA+1C10xFHA9ApWx+17n4gginf1lTLpaFnpTLP9qRYAuvd6CR+PBz93xeDrWNikOqFlJvQXFumbwnIJgM0hctGJLjcwjMuqWztFlaVURfI+fTZeESljIZwJgWz5dmyH6WVptz4Gl3jqs8CB6++oCiX+yA+b0wwOQwZ/LuXQfPyjsoF7plVBNTvglSCktcqTEbvg/ldUgTsaF0gk2WJ89TrWBArmRxewe3ULg6WC8SehDcig5L2/y0XVS+WROAd6slQlb/frsSqKpk90RVduqUtgUxtm9sDx1h3qQx9czfVXPwh3ESnL7EsPYKKT2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 06, 2023 at 05:40:27PM +0000, SeongJae Park wrote: > diff --git a/mm/shmem.c b/mm/shmem.c > index bc5c156ef470..8ae73973a7fc 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3211,7 +3211,7 @@ static const char *shmem_get_link(struct dentry *dentry, > folio = filemap_get_folio(inode->i_mapping, 0); > if (!folio) > return ERR_PTR(-ECHILD); > - if (PageHWPoison(folio_page(folio, 0)) || > + if (PageHWPoison(folio_headpage(folio)) || This is actually incorrect. We don't want the head page, we want the page at index 0. It's a subtle but important difference later on. > @@ -3222,7 +3222,7 @@ static const char *shmem_get_link(struct dentry *dentry, > return ERR_PTR(error); > if (!folio) > return ERR_PTR(-ECHILD); > - if (PageHWPoison(folio_page(folio, 0))) { > + if (PageHWPoison(folio_headpage(folio))) { Same here. > +++ b/mm/slab.c > @@ -1373,7 +1373,7 @@ static struct slab *kmem_getpages(struct kmem_cache *cachep, gfp_t flags, > /* Make the flag visible before any changes to folio->mapping */ > smp_wmb(); > /* Record if ALLOC_NO_WATERMARKS was set when allocating the slab */ > - if (sk_memalloc_socks() && page_is_pfmemalloc(folio_page(folio, 0))) > + if (sk_memalloc_socks() && page_is_pfmemalloc(folio_headpage(folio))) We should have a folio_is_pfmemalloc(). > @@ -1389,7 +1389,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab) > > BUG_ON(!folio_test_slab(folio)); > __slab_clear_pfmemalloc(slab); > - page_mapcount_reset(folio_page(folio, 0)); > + page_mapcount_reset(folio_headpage(folio)); This one should be &folio->page. > @@ -1398,7 +1398,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab) > if (current->reclaim_state) > current->reclaim_state->reclaimed_slab += 1 << order; > unaccount_slab(slab, order, cachep); > - __free_pages(folio_page(folio, 0), order); > + __free_pages(folio_headpage(folio), order); &folio->page. > @@ -939,9 +939,9 @@ void free_large_kmalloc(struct folio *folio, void *object) > kasan_kfree_large(object); > kmsan_kfree_large(object); > > - mod_lruvec_page_state(folio_page(folio, 0), NR_SLAB_UNRECLAIMABLE_B, > + mod_lruvec_page_state(folio_headpage(folio), NR_SLAB_UNRECLAIMABLE_B, > -(PAGE_SIZE << order)); lruvec_stat_mod_folio(folio, NR_SLAB_UNRECLAIMABLE_B, ... > - __free_pages(folio_page(folio, 0), order); > + __free_pages(folio_headpage(folio), order); &folio->page. > +++ b/mm/slub.c > @@ -1859,7 +1859,7 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, > __folio_set_slab(folio); > /* Make the flag visible before any changes to folio->mapping */ > smp_wmb(); > - if (page_is_pfmemalloc(folio_page(folio, 0))) > + if (page_is_pfmemalloc(folio_headpage(folio))) folio_is_pfmemalloc() > @@ -2066,7 +2066,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab) > if (current->reclaim_state) > current->reclaim_state->reclaimed_slab += pages; > unaccount_slab(slab, order, s); > - __free_pages(folio_page(folio, 0), order); > + __free_pages(folio_headpage(folio), order); &folio->page.