From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A021C3DA7A for ; Fri, 6 Jan 2023 19:39:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95E4A8E0002; Fri, 6 Jan 2023 14:39:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90DB78E0001; Fri, 6 Jan 2023 14:39:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FC968E0002; Fri, 6 Jan 2023 14:39:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 71AF78E0001 for ; Fri, 6 Jan 2023 14:39:03 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4BE81140EBC for ; Fri, 6 Jan 2023 19:39:03 +0000 (UTC) X-FDA: 80325387366.29.D7A2D46 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id C40CBC0019 for ; Fri, 6 Jan 2023 19:39:01 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DyFswvBo; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673033941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WDav2tQX4GhlHIZvFHwLD5Ta1F0x4Q4mp0gqLMjRTLo=; b=FjvfMiVSIQeFHMu+VRPuSTYA53/t0DWtEaRpUd7mx5QtpimtWJlsucPQBklkMMUelDr3I7 97Gtah/Ve3N8IyHBLBNhCIjI48KBYZFhQedM+xryYIZd4WPqwPTAA8EQSSRpVk6qKqmh4K Y6Qb4vCH4gWHOm3Ty5NBcCzh6D6eWfg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DyFswvBo; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673033941; a=rsa-sha256; cv=none; b=oVw2tvC9lvWqgOBeemCyLXzqkgkiSkZrOIByJnDt/8riMzDwJfT2xLm8FdWPUBNvqhXoKr ANS6S0l3LW2jeHMNmxqS7vgra2NmwZaDMsa1SwZzIa8hB/chrn2rpNdcLGjnO5Vb28h5xD m1EyywOHi6u3/mbK2iEjWBxABrm7Gkc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WDav2tQX4GhlHIZvFHwLD5Ta1F0x4Q4mp0gqLMjRTLo=; b=DyFswvBoG8itxv4n8cpLJSuvb3 SdDsVEJOuVuUZmwrvH2iU6foOX8Kn1l+a6FhCSCsUn16wMh7pgQpd7mPvhkitb71EgIHiai5jBAuN 102TfGSJqbJ0VpijiCJAeiI2Mxkb9BiS5z95vTaeBXfiMv+QgQ0hKo3dDrMmwzicEWY7QQv1IH/Iz rzLxBt4HXWG0iuB2zPULiFFdxjNZw3LQMTOT8i2cFuO+OwNYWQKBctv3I5qtYePxkKMbpFQD4AAqN F1J1aneU3inO7/S+WYFDaLQmNQeCv8sQ9NgM7LfWH+lYPjcHcevgoMeFzCCu+OytAynieJkGjYBha Zy/Al2Ow==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDsYV-00HRmd-C8; Fri, 06 Jan 2023 19:39:07 +0000 Date: Fri, 6 Jan 2023 19:39:07 +0000 From: Matthew Wilcox To: SeongJae Park Cc: Andrew Morton , Xiubo Li , Ilya Dryomov , Jeff Layton , ceph-devel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] fs/ceph/addr: use folio_headpage() instead of folio_page() Message-ID: References: <20230106174028.151384-1-sj@kernel.org> <20230106174028.151384-4-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106174028.151384-4-sj@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C40CBC0019 X-Stat-Signature: dj3qzh861hjw8fremsxrpzufka3khohy X-Rspam-User: X-HE-Tag: 1673033941-794372 X-HE-Meta: U2FsdGVkX192cxsCMr8GpCc5BkfDyAcxuX9uHPZE0XwEzWmXeYBMvyTBgT9MLb0ou7LhOph7jNMb/ZER2O0homwWlw2HQrJR4ghOVcavM+II5XZeZIeOiuHaVaPC52rdRYrpBbGOrI4U1zBCtljOzCwCkJemEEUpOjGVsBmSo2HdbMQ9Tc6P3rcI0grL+YdROCMK1hbGEAljw8Wz90EGdvdEVlYL578IuhdC6AotfVJJMKASdSsnkiBQ0JYrob+jR98GcdAO/txbeo1Ck8vpPnYb3GFmBqqTeoQzEo4wLT1vnlgG7j11DGysuo6oywc4zsKtZJqwqiZzfqSq5huyRuPejJ8XdXd+BlewcRbnGbytT4RhJax0OALkNGPyn+G/WXe6Y1cpw7kdt8Te545H17HqhQpKj0+fz20DtcuIStLwtney2EhPqMOKTB6Cx5hUCI3bTlgcljliwxHl77xXv9xo4+DmS3cjh+gqBPU8L7o98ptE7nr5CGnL54/T0L5v6Tv+O9EdRGvX8IYpYYQw+OAIBOVk4ajYuz9y8sW9yHj2EEkfmuD60XtOVT0b0wCqTn7GGESVRZ/ebj/X8PJh9i8uqzvFARHKKn+B81HN5Ivr6jcn3HYt6WIZ1xaAon0xNnWC6cBkJ61PwfH7XA5J18J+hLA/tTfon48hGk6toNnsdXJg/CIvITJpe9eykqGiKkypP4GptPbxhWWY6xN+Itmn8AjdqJWAVeUtbo8Nt5++5hx5On0Z2fjGxQqDyuYMMj2OWa413GovaM6aFXfgCqH5yptwGCaeZ9/U2o55lof4mpc58Arn26zFHKojjAcRgGyfvOpHgHHIxjuUDuJag4SJfQ16yqbMJoO8dlR0PjfatuUWvUnhqteCZNaBuzam6fQSA7fhtD/YjMgKFVr7Cg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 06, 2023 at 05:40:28PM +0000, SeongJae Park wrote: > - snapc = ceph_find_incompatible(folio_page(*foliop, 0)); > + snapc = ceph_find_incompatible(folio_headpage(*foliop)); ceph_find_incompatible() should take a folio.