From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58988C3DA7A for ; Fri, 6 Jan 2023 03:12:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7F6A8E0003; Thu, 5 Jan 2023 22:12:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B2F2B8E0001; Thu, 5 Jan 2023 22:12:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CF468E0003; Thu, 5 Jan 2023 22:12:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8D4E68E0001 for ; Thu, 5 Jan 2023 22:12:56 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6A05D8070C for ; Fri, 6 Jan 2023 03:12:56 +0000 (UTC) X-FDA: 80322902352.29.358CF1F Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf20.hostedemail.com (Postfix) with ESMTP id B558E1C000A for ; Fri, 6 Jan 2023 03:12:53 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aZ44bH1s; spf=pass (imf20.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672974773; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=21zf54EYWZhDQm73m3HRBf5o2in9eTbBIqduSXeMgk8=; b=zjAaLEW/rkYk8LebbuttoQ1BLfPumF/S0Kxku3EVdUyxwEEry3LRJGHxJcmjTGn01cn3LN vuC6QZAAJ+vHM8R/kgMeRelU6MeeZvXOIHI4A/h85/yq+Wpnw4pWwtnZzYDJIctfsFv+Re 0vbYDu9yR7eyCg/f1bnkISOt52Dei94= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aZ44bH1s; spf=pass (imf20.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672974773; a=rsa-sha256; cv=none; b=T67EXJhD8hwDn9VzBkqRgFzR7teH9/hnlwy9qGhQK2CAWR2JebmBxeh5kzVRE2bpKgrucc 8zcbKnu67pngl75sHDk9l9D7paikof0DfPpyaOUaV+rO2qt1Kx9P1VHwIBWTOp87CIwjBO pVruXgebz6tuqR4XPggIeGDKEDBdJAY= Received: by mail-wm1-f49.google.com with SMTP id bi26-20020a05600c3d9a00b003d3404a89faso3086393wmb.1 for ; Thu, 05 Jan 2023 19:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=21zf54EYWZhDQm73m3HRBf5o2in9eTbBIqduSXeMgk8=; b=aZ44bH1sYnQ5JsJWaicvpGtsRM5DotnzGw9qrWsN9MnkMjhlFHk9hWepiejOwWgRZW I8+mM2CLp5LlUZq6i32263xTMJQTPcu/SgYfC9R9cJDmcdv15YWgzye+5pUh7P3kGzR1 smiEj2VLf+hZihLytPT/8uetBwjhUmOMYidBUfo7Tu64fYNKfVPY86KAP/gNW/BxLlwl KhQWSsRSPSOqyhETLgGquudZuGX15ZU4wRo4NRoL15UxxsF6SFkzk4erKklymtLyc11J anAL4L64j3wSDaoWKinZc3dxZnRhWRGMhuIG0pYMQR2OKw13141Wd7SNtBHhJk5aDhEY TTaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=21zf54EYWZhDQm73m3HRBf5o2in9eTbBIqduSXeMgk8=; b=LZfpAVQ2JtMzJ2/DpQ2ZUviTbUOtbDnIPvNABtLT5Se9/rlPO6vEWC5e1Vbc1zsBA7 UyGmf7Ae0lIADkqVxU1fuA9xBXIuPFyLUjN+KaqvscXOM7inq9TSO4/509L7r6lDbSeW lnQxc+42r/LGit6EqTcp6gOnLnsipF7ANyDRjCTQj4OVO6R7E9IznU9JRodggTun3Z8J 0mdjTY7p2S/gqdCXpHgSXPgtYTTBO+nwI0QUq7V69Bqw/1USjrtFGYQOAdhqHzdh6UOq cYTHkjU65wsQiat+J9mnodistRkqdvcJ/vPzq0+MPN+Pf9WbsMQnJqR4NCysL4ZyrWRz qjcA== X-Gm-Message-State: AFqh2kq66N8sweZRJhAhOn2b2BTFFgMiG2zt/HCg4EopfBJFB18WQSQJ Iduk40w1Ux2mBZQ8b0vI+ls= X-Google-Smtp-Source: AMrXdXtR5P+Ujt2kAioRpWXKR1dGUjAnz9UesBoywCFrbsEvTlyXCnKGra1fH0QuZVVUrzDHHyt8yw== X-Received: by 2002:a05:600c:3ca2:b0:3d9:da3a:ef9b with SMTP id bg34-20020a05600c3ca200b003d9da3aef9bmr639110wmb.31.1672974772270; Thu, 05 Jan 2023 19:12:52 -0800 (PST) Received: from gmail.com (1F2EF380.nat.pool.telekom.hu. [31.46.243.128]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c204100b003d99a39b846sm65434wmg.5.2023.01.05.19.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 19:12:51 -0800 (PST) Date: Fri, 6 Jan 2023 04:12:49 +0100 From: Ingo Molnar To: Aaron Thompson Cc: Mike Rapoport , linux-mm@kvack.org, "H. Peter Anvin" , Alexander Potapenko , Andrew Morton , Andy Shevchenko , Ard Biesheuvel , Borislav Petkov , Darren Hart , Dave Hansen , David Rientjes , Dmitry Vyukov , Ingo Molnar , Marco Elver , Thomas Gleixner , kasan-dev@googlegroups.com, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 1/1] mm: Always release pages to the buddy allocator in memblock_free_late(). Message-ID: References: <010101857bbc3a41-173240b3-9064-42ef-93f3-482081126ec2-000000@us-west-2.amazonses.com> <20230105041650.1485-1-dev@aaront.org> <010001858025fc22-e619988e-c0a5-4545-bd93-783890b9ad14-000000@email.amazonses.com> <0101018584d0b5a3-ea0e4d67-b00f-4254-8e1c-767fcafbec31-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0101018584d0b5a3-ea0e4d67-b00f-4254-8e1c-767fcafbec31-000000@us-west-2.amazonses.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B558E1C000A X-Stat-Signature: 88ky436wh6cm4kmc71g4i8xrzryto464 X-HE-Tag: 1672974773-241359 X-HE-Meta: U2FsdGVkX1+SXpqoFZPU0E8jn9RwVaT7KE9fHOXlTsw68d0btLqG/dK9TrSS3b391ghFKSGtTEPmfFxmxGfaRlT6h2Y3JZmdFnFhaDD34Olb4DZ+inJy2NcJUsRvY6tl1x3gfl0wvYbvb+bkBRNCuDtbeYzw0N33c1s2lUIhl8/+aRitg1VgwxJZho+ZjboYuYuHkaq2ILkbx084ExCp4GhyKXk6e1YLDuRR++wodFg2VZNIW8rMg667DAUC8JzgI/aMqrxYj9XQssWLgGa5RYt/3K1kvOfAsAzmhhv9sleRQYWZ5xwJzrj3BbzCFooM2v+tQVrGzbXU969o0FGswmqgVqhe9swddOpqg/zZnm+XwI4OjLmlcGzV15CFQ4ImK4FTpn9EHeIKi0KyZ3eSO6gMlly528ioOMrlaORlqGLUH0NIXTqRePOxVt9bkl5/RjWhmErZCql2grNDx6AjF8yysV/tiM7S2IbCw2tJlFcSepGbNrNQCPJjh0fgHmu5dgUG+VsEUjLL7VquWML7R/YfFcnYMqLw0WKYQYED8lKSryk4yeX0O4VSYfjGSTTFEICGaloTK+os/aXLg1Sndb4lPeFwLo+YZXb9a9D4+akFqjglS6CSZy6DSmsip1Vvnx6rxbH7kISOhW4cAwLKVfDwYlGJ/62bhbEmhNcTpWDgZmpPKInD1bfxedDKOJf+FcGf7VckEt2nVDTggpHsbzXvh4imFPVsERBd3ynMlku2SttvJ2W7pcubScgac6cF+PnaoDfc+mL28sWOS5YGxlYQ4THQnHdYTvMJ9NhS8JeSzipF0rDEq0yM1k6aWagbr+/uxvC1ntj+3bTYx9ymqwyeDA0g70t/G2E7HlSIChQ0fp6RSohqWNSbR+awqRccotNRh4tWfY6y2Zecel5nsexSRF7r12yIs+R6O5yoKCwdn+8O84Wsb3hrJ7K83LpD2VPrlizvQ7eQYgV/hue WZzjxdtP sqeyaYipblqHXBcDaSAdXKw5F6V5PYU2CVRwr7yX6dzVFBYQR4d1Y1xxsG+JVvstW+DSMXDCJ7Rorxm9z5dfn+aMQ++kRcniYL7jJCQNKiPaobPX/GUdyp3zI7zl6aFH7uBkZSPNoUVgno5MR9cOn7dj79GQVq1Qd/P0h9YFBUxAS47LfGZk+f6JSJvY/LlS8r6RuzFK6O2tIBfQZ5a2jYge0kgNS0bXoqLL6B1aaiSbygFacc6xMJv/0RBptnVCtcC709pKmFBdwdxh/pSeACxsmCnKYErKOBYIg4+twCxjT0WHfoLoFiq9kZlPqNctuZc27X9RS6lnFUGogttQutaYJzaBzdEjb3Iv9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Aaron Thompson wrote: > > On 2023-01-05 02:48, Ingo Molnar wrote: > > * Aaron Thompson wrote: > > > > > For example, on an Amazon EC2 t3.micro VM (1 GB) booting via EFI: > > > > > > v6.2-rc2: > > > # grep -E 'Node|spanned|present|managed' /proc/zoneinfo > > > Node 0, zone DMA > > > spanned 4095 > > > present 3999 > > > managed 3840 > > > Node 0, zone DMA32 > > > spanned 246652 > > > present 245868 > > > managed 178867 > > > > > > v6.2-rc2 + patch: > > > # grep -E 'Node|spanned|present|managed' /proc/zoneinfo > > > Node 0, zone DMA > > > spanned 4095 > > > present 3999 > > > managed 3840 > > > Node 0, zone DMA32 > > > spanned 246652 > > > present 245868 > > > managed 222816 # +43,949 pages > > > > [ Note the annotation I added to the output - might be useful in the > > changelog too. ] > > > > So this patch adds around +17% of RAM to this 1 GB virtual system? That > > looks rather significant ... > > > > Thanks, > > > > Ingo > > It is significant, but I wouldn't describe it as being added. I would say > that the system is currently losing 17% of RAM due to a bug, and this patch > fixes that bug. To the end-user gaining +17% [or +3%] extra usable RAM compared to what they had before is what matters, and it's a big deal. :-) Thanks, Ingo