From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C85C4708E for ; Thu, 5 Jan 2023 22:42:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AE2F8E0002; Thu, 5 Jan 2023 17:42:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05D428E0001; Thu, 5 Jan 2023 17:42:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E40F18E0002; Thu, 5 Jan 2023 17:42:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D74108E0001 for ; Thu, 5 Jan 2023 17:42:42 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B1D84C0379 for ; Thu, 5 Jan 2023 22:42:42 +0000 (UTC) X-FDA: 80322221364.12.591917D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id C9142100008 for ; Thu, 5 Jan 2023 22:42:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fMCOpmMH; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672958560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vgUHJzZE66px4h3+wgCbKciUz0W22+aUBNT6U4fGi2Y=; b=AvFnG3wynsyuADnGCwii/aMWwI5Bh5p8S/V+BqYrOe+t4SaZVLlMg1UEz7ImayTLrZrXEq PcCjx0x1PXNTdb8qBaDLShGXpdrx/AyMztyNnmO+8d/LPuDE1nVGHxZRj+g4cu0faWJl+D +hSDy4E4VeJfDEuA8tQszjljxEOERlI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fMCOpmMH; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672958560; a=rsa-sha256; cv=none; b=YH7G7AXrfeiL4GO5Msxg5Y53hJTw5xSF/ht/T33A9II0M+ZF67woMBB8+PvvZ4omCfoCO0 CPT546qv1JfRwyFJIOvweoCk0wAZ6FRJAmMgD4skuWoBGg5hxHjTm8pvjWaHaRbd88RnSU c3ng8b3u4o8R8afnmJa47f2n1izAmIg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672958560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vgUHJzZE66px4h3+wgCbKciUz0W22+aUBNT6U4fGi2Y=; b=fMCOpmMHWS4JXuQB7f2aVTa+YXzXbtVsME1dHH4isLHyFw4n0l+DAnUHdO/Y/2OrvalqEB 06iz7FKroO/+oVhygYGfI/PVmgLtjmavQuRJvpeqQgaVuKPTwaVzov1wEg8SdcT/Wp8ftY TEcY1MnHF1dNNp/W+m09htY6Yyxqx0E= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-616-R_LQsU-uNuK9aybpa2LNXA-1; Thu, 05 Jan 2023 17:42:38 -0500 X-MC-Unique: R_LQsU-uNuK9aybpa2LNXA-1 Received: by mail-qk1-f198.google.com with SMTP id q21-20020a05620a0d9500b0070572ccdbf9so5404833qkl.10 for ; Thu, 05 Jan 2023 14:42:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vgUHJzZE66px4h3+wgCbKciUz0W22+aUBNT6U4fGi2Y=; b=YOfwFQjeR7KPqNIvmv9QsL7bMFEW/Ugo4Y1tbwHikHYS9NochMors4T7Uveddq+pgU bTdtHXQAmBs1LlW/9exFTL7VSd3Xbg6l2xsSL/c5iuHOY1je8Rl6AW7SufF8XNrKwF0J QXl7EFq3AhYUwCTd8KWCIvNPn816R1G6HJELxNAAmcZw0WOl+O8FCjMjW3qOXKKwubso jUmU3bs6aSUT4Ld1gtiyKkWUNzQt3UyX1WvDC/ub4qRtpTmCYFnyrzIIk8fjgdO1aNYS q7NJJQdMXvHRsAJl1u90g7YXj7Ohrgr+SaIPOWB/NCFoGWhyTnNy9SR4b0euOQl788Ki Em0A== X-Gm-Message-State: AFqh2kp4SC5eTUCIG72VubxdNKABxt/BrH/9mJXvcJgrIZ3D3OzXbzwL M7yU8n5vjE6adULi8TX9ldhpL1XwRKxkwUfnenaZZPyuoOIGhD9LMLVreyM3zeCjrTijxD9lJ9d 9tvjrSFR/3OQ= X-Received: by 2002:ac8:7766:0:b0:3a5:f9cb:886f with SMTP id h6-20020ac87766000000b003a5f9cb886fmr72417707qtu.29.1672958558365; Thu, 05 Jan 2023 14:42:38 -0800 (PST) X-Google-Smtp-Source: AMrXdXsb7QMoGw7hkQTzlQFXCKWwVIMRvtRiRSKc80lHWO9Msaear+owA5O3ECrqcaUd58w1BSTVGA== X-Received: by 2002:ac8:7766:0:b0:3a5:f9cb:886f with SMTP id h6-20020ac87766000000b003a5f9cb886fmr72417698qtu.29.1672958558192; Thu, 05 Jan 2023 14:42:38 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-39-70-52-228-144.dsl.bell.ca. [70.52.228.144]) by smtp.gmail.com with ESMTPSA id fa11-20020a05622a4ccb00b003a68fe872a5sm22317208qtb.96.2023.01.05.14.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 14:42:37 -0800 (PST) Date: Thu, 5 Jan 2023 17:42:34 -0500 From: Peter Xu To: James Houghton Cc: Mike Kravetz , Muchun Song , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 21/46] hugetlb: use struct hugetlb_pte for walk_hugetlb_range Message-ID: References: <20230105101844.1893104-1-jthoughton@google.com> <20230105101844.1893104-22-jthoughton@google.com> MIME-Version: 1.0 In-Reply-To: <20230105101844.1893104-22-jthoughton@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C9142100008 X-Stat-Signature: ruddczxz4gaf69bpgp5fkanu9ztpch3i X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672958560-622754 X-HE-Meta: U2FsdGVkX1+UTn7Sewq4K/YCUks4LUMy3auLeP86hFUewSVWYPSuosDHV9ygYVuxHjQjVP0m9bhGnOp04n3g8ZtN2rTTaMUB3UeOOFryB7k0NO6L9kcJ3Tnvx3WDNwg9HHPv/Sp8v+lNri5SzPxmeSdOC1sfkDRwVCzIBJXkc7AfNk3a9nqJZu2xmdzCfml03WGMMVkPgAx/uvbuWdkSlL6ftaStysHoOUZZWAQQp3FAwycaOMjdNuPkSDzPGd7Dne/h6gYuCGWKbjCWTFGJGGRueMRCVFBUuUIXYIivlsu+fW+dTfRPymZpYj71crciIm3B9nh0c51UO4jn0JqgPgiqLeOORQZm724+aNplFcBVXWOjnAR9pXHvJp7PjigBLrEBOV89uYRkp+MLECMCrgyrjjwSoL1A1SxEFTvQGmQjUh+E57D/cMFnyADzaig/PaaF2hjCEe4bSDnqEwXZwnK1NxIs67iLbkpHjVOCctVcs2tfOsPBNKKoTwqU+Mzo24GUhGa23fUxx5HGe24fFFop2WxXsAtW4t8IKvg11l+eglRhVU1bTfWk90d7RpyGyd6jok4/vwFYTVoYq0IiEgACojQaol3mX57+UDTliFmyPufMejqdmiXnivhdaHJVQmuzw/lSKGHXTAUg+l+JoGCxMPGWkUKpYKcnWI1xYHLeTjtao+LnLdzWy3tzZMXTdEsfid61mur+hcrI7Pv1mfIkcNBFAXZf8S28dgewniAcnB71N4M/8SBauTT/efgbMYGLONwi9V6/xzjDRSu1NRrvaH7sg1rYc+1KzMW858nFFVCoMeiRDVhaqLdu2q4iXfsWYAzl1dRsRgUQ9TUQLEAB6Ku1VzojKmxupxgZRqIm0UD3rbHA1rJXFmV7R3+GPGDVISotHdIRvnepH5WIQ6GuQcIc1V18DWEjTOebAULsBVJAQeSIXBneW3ZvJoSSUdzQcY37dvAJFU53IFm EyF5kbPE Evzi+J2CiF6VTzGZnw9dGK51NZQxBnlpX6lVN/R55GiRnN8P6EEaWmD4ngOq7wB0tByjDIpHT0GBFCTWtQ+57cGn9DZmODFF1vTYckrMXP02rcjZ++d2uwnC2+iGPC2f0VWrgd2QW2CosJh74CQ5QNcXgKgWocAa0weNk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 10:18:19AM +0000, James Houghton wrote: > -static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm, > +static void damon_hugetlb_mkold(struct hugetlb_pte *hpte, pte_t entry, > + struct mm_struct *mm, > struct vm_area_struct *vma, unsigned long addr) > { > bool referenced = false; > - pte_t entry = huge_ptep_get(pte); > + pte_t entry = huge_ptep_get(hpte->ptep); My compiler throws me: mm/damon/vaddr.c: In function ‘damon_hugetlb_mkold’: mm/damon/vaddr.c:338:15: error: ‘entry’ redeclared as different kind of symbol 338 | pte_t entry = huge_ptep_get(hpte->ptep); | ^~~~~ I guess this line can just be dropped. > struct folio *folio = pfn_folio(pte_pfn(entry)); > > folio_get(folio); -- Peter Xu