From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0E0C3DA7A for ; Thu, 5 Jan 2023 19:22:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00A168E0008; Thu, 5 Jan 2023 14:22:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFBDF8E0006; Thu, 5 Jan 2023 14:22:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9C418E0008; Thu, 5 Jan 2023 14:22:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CC41E8E0006 for ; Thu, 5 Jan 2023 14:22:58 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A7F78A0405 for ; Thu, 5 Jan 2023 19:22:58 +0000 (UTC) X-FDA: 80321718036.23.0CFCBB6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 9440D180007 for ; Thu, 5 Jan 2023 19:22:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JZnCEWYu; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672946576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ADW1K4PuhFmDUthAnWNZLxX9smSORrKhgThxl96aaHM=; b=INJoRwTnPwI4qu52Ch6hzfdAYkU4NDP97iUYzqsOKp8j1ocOLVXjy8aJUw6NskMsT5Ypbd vWBwxT7T+K9GyHsHrnOIZTY1eURoI3VbjXO7G9pMnn2D8CHZmN0Z/k0SVEUAs0Js7r8DnX bbpE+sCP2x/uQUbcCkfqsNLBdleBMMk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JZnCEWYu; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672946576; a=rsa-sha256; cv=none; b=q/mQDQdbVtDSBFl2Lpdl5wamXcJS3Ivlz+46Dt7FAma8/NElVpizysMXENn36kevcYKood So+WFoK8ARljXmAdgComZIsgsGXKFZ2EjCgiCoFA5tRzCFNurXCn0vSCmMPTm1qtEY4f9e 1USOkyEDM6ztzs3N3vDa8sTuH2A/v0A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672946576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ADW1K4PuhFmDUthAnWNZLxX9smSORrKhgThxl96aaHM=; b=JZnCEWYup9/2vdfPfNee1rxm0EKEEGTJzGrbzihvavyGiJfFTqFZAyv/uKT0xOaw8f9KmO kq46v5/xcQGr1fUAbc6YKRGQqs4YBWaI61CZrWdq9XYwV56IbRZ0qed+TH17NdJ8Hn4n2I xkTpcf58h9VL/WYTfhEwnF/OElp860g= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-272-Xu0ETinYOfWPrTBWM7f-Vg-1; Thu, 05 Jan 2023 14:22:52 -0500 X-MC-Unique: Xu0ETinYOfWPrTBWM7f-Vg-1 Received: by mail-qk1-f197.google.com with SMTP id q21-20020a05620a0d9500b0070572ccdbf9so5097891qkl.10 for ; Thu, 05 Jan 2023 11:22:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ADW1K4PuhFmDUthAnWNZLxX9smSORrKhgThxl96aaHM=; b=WBaaGOyr1BIWVnhixM4kXOgKlHzTheVM/YzrdoBRg5UCYsuqBPYlQCRhM0gQlydWzv 4/vu3/0SH4PlTk52NhpYhhU3EY/+HivioU4h12oQxqxu7qBxNDLDN1bjmjjHQxtOAj5E +W7GLdniMOxqeHOVAl8SYkUCvRDyOZlZL2Qm/D6kRCQJTzxoCYW6ptsoz4h2cXlDqn7Y rcSFZe2l2llZTIS1OnCQL32+TFXGVJYGeidScwDRMv1+cIiOf9azyu7hbvpXIDUIVKpE Or0wdz9ALH83mu9J7v3nKbF3saEHV3eVKytJB1GshhAcDvNFMRNOfSg+wTgFGskOCexS t5Fw== X-Gm-Message-State: AFqh2kqBGoIaeIED7WueJSvvVwow4E3gno4UXq1DDKUa7j2jSyzCqx4C 1yt9Ovs1j9pGge4tqERLzucBV9W/dqD+/R1JKw8Bwy0vOV4RXwQercwEp23UdhfothWh4viCA6J AMnMvFVxy/g8= X-Received: by 2002:ac8:7c81:0:b0:3a8:11d6:2d0d with SMTP id y1-20020ac87c81000000b003a811d62d0dmr72093648qtv.43.1672946572435; Thu, 05 Jan 2023 11:22:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXsM2kmIU2DF0AgxYxehxHQzuVMOGJNoeeqcpmHVgrPJwS2pHkY2LK4czHY0M2F7U0Ty7ZCcaw== X-Received: by 2002:ac8:7c81:0:b0:3a8:11d6:2d0d with SMTP id y1-20020ac87c81000000b003a811d62d0dmr72093634qtv.43.1672946572234; Thu, 05 Jan 2023 11:22:52 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-39-70-52-228-144.dsl.bell.ca. [70.52.228.144]) by smtp.gmail.com with ESMTPSA id n23-20020ac86757000000b003a826e25bc4sm21893373qtp.64.2023.01.05.11.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 11:22:51 -0800 (PST) Date: Thu, 5 Jan 2023 14:22:50 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Kravetz , Muchun Song , Nadav Amit , Andrea Arcangeli , James Houghton , Axel Rasmussen , Andrew Morton Subject: Re: [PATCH 2/3] mm/mprotect: Use long for page accountings and retval Message-ID: References: <20230104225207.1066932-1-peterx@redhat.com> <20230104225207.1066932-3-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: cdc611musrxead4mmpeq4c3bpm9ewsuz X-Rspam-User: X-Rspamd-Queue-Id: 9440D180007 X-Rspamd-Server: rspam06 X-HE-Tag: 1672946576-731943 X-HE-Meta: U2FsdGVkX1/mXvqCdtr+h1sUTN0ztkrXeBpK3WJ3R5CzYQo/4K7+3sg+NWykFwIJ5R8UA/alUSi5mOH2ha6kATKeZJ9/gmvZeI7xYelPVudMr4IlB5w5fc4zdfJN0Dtl8nrfFDjebo6YCGeimX8yNIWFiCODyw3zWEfBZs7KXR/9HoOgLuIbyf2ltzw/o7Iw1VWDD5Cig8niF+qW+OdExneLE18oU7VTYdpqvXdmKmMUanknjvqeEe2SqXLPg8yzXvX1fZAxH/gO0cgtv5Rhq36Xovvl3oGpwnDBdyeKQtTvYURZLoOZoRxPL4oHi4rBR5Ey5r0emuK2IQAiYR9q13EmSbx8OKARxwieZ9XXgjpwWBJJgyVvbwn9ZjKM5X0pYAEuJORpP4vFs11yJdL67mjhgZkoWHByR/Zz8CkIx2RwnNTw4jaWK/1FtXU0YRKdCAND/95JGNpRhPhjjkkpyWMOsP+g5Rd9V4HGb1C1F+VipnqheawlNObATwBxPHW2UxaqvfNBPxVpoAp1GGMht4oLUL4xInW58BFytuiX8AjooMUa5IN2el6HUP74dW38l4LXQTDcmxkLvWBBGat1HWR2uCLMNC58nhpwxUVl64Kg2e8wCsjaLdurOF1iNvrWGY57tKyJqZpagA+eDoVUM844c6pYAX2mR+GnB8Kc8yXOBs3BYouD505abDJCkfl7d8G14VfwcZbZJkOCHkz5Gb1JvOWrzCiHqZ8qGbfQAGuRdhshKDxBTH2hT9J13rDDBNuEHOKmQrBP7Mee2PwgJK6Twwlrqx/Wr4KEEIayt+884+Zo3hinWPyAHSh2OPce1lzoRuTay5GJYQV+G8xAeUq1O4aWMZlrhnRy/xbj6d0OfmXEH/wf0JVbXEw9GPiKVRMRZm+PFVVIQzoG+dLjBzhHVW8/LmHS/VcbPrF3r5ZUQLom9bTXBcV3tHTG6vugZHwtgdAJ3eeUZ5HZ/4X 5lKR+c/J 9CFRi9KSZvpkD/uqoUL+IENxFpJJaFsPZcKGGAJuYvOhjGYgPfyPx+wefPTiZp1JfhWl72e0FTF4iR1tpJj0HrPSXlV1jda8vpedtfrwomt7pjFuSmMga+CRAAr5pY/0SWiHTKhuNXUaJ2lBqjZf99oBSJa+JrFbodzobipJqDB4dXfJrMyxEnOY3XQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000537, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:44:16AM +0100, David Hildenbrand wrote: > I'm wondering if we should just return the number of changed pages via a > separate pointer and later using an int for returning errors -- when > touching this interface already. > > Only who's actually interested in the number of pages would pass a pointer > to an unsigned long (NUMA). > > And code that expects that there never ever are failures (mprotect, NUMA) > could simply check for WARN_ON_ONCE(ret). > > I assume you evaluated that option as well, what was your conclusion? Since a single long can cover both things as retval, it's better to keep it simple? Thanks, -- Peter Xu