From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9C5C3DA7D for ; Thu, 5 Jan 2023 18:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D238C8E0002; Thu, 5 Jan 2023 13:38:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD3848E0001; Thu, 5 Jan 2023 13:38:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31A58E0002; Thu, 5 Jan 2023 13:38:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A57988E0001 for ; Thu, 5 Jan 2023 13:38:36 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 79EB1160338 for ; Thu, 5 Jan 2023 18:38:36 +0000 (UTC) X-FDA: 80321606232.05.F880F4D Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf06.hostedemail.com (Postfix) with ESMTP id 3E6E7180008 for ; Thu, 5 Jan 2023 18:38:32 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=K4Yx7HW5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xSkBwjsu; spf=pass (imf06.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672943912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KUWMGomMuXF9tI6SsY8poBzvu+IZTVGXBDR9YywW2oY=; b=AVI1XJX7Jf4Ntx69qYvzshqRmUQJjX35E8tFWXyUnPVDCbgNQ8E0Zk2ypWuyhVAHQ7vX4/ yP0b/xa3GPsdEO4YyV2OWYbNHCTnyCQ3Qx9llCMsPH7K77707ZoTIfSCsoM+ylriR1b+uQ eXlMMI6DwaOAT6KwoaAYAYrBM0zXgxM= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=K4Yx7HW5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xSkBwjsu; spf=pass (imf06.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1672943912; a=rsa-sha256; cv=pass; b=amt+UvrTnViNuHOKvLFmJuZbswG28bpTuj+GOAqmvyi0ApaOVN+kmdTMfetRiedGZBA0pJ NFZJxamx6tJJ33IJNFDOUz8S5jiGUWjfrx1fNfva9cwq80dUj2vFtpo4UIOkOQKlD0Q56A SGQezeHgaAOpN79ijOWycofPF4RzFCY= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 305IT0pX006625; Thu, 5 Jan 2023 18:37:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=KUWMGomMuXF9tI6SsY8poBzvu+IZTVGXBDR9YywW2oY=; b=K4Yx7HW5SJX239TYLjorMG+T4CqdkZ/zIgHxRhXdaXd/2ZteQ/cusAuITdeWoatzDXIp LFkqCA1PPct37Z1vAZgTAFDYXNjlu1qdpnJ/wHuT0abU9MQ8i3lGxhF3RHKTnEoYcmMd M4cxC0WPoC/ZpqTOFtPVdHl1pa2q0JQ4ZeK4M9pc02pFu25OaNkfwfMlb9gDk5xGSmvo Tyb4pHNUFemSKT9bido3Fb/tKE2UYj26iKE4WBnq5zSY7nQDrSW7nVxtee2eJASNCver ly39dzacCh2lzU0QXVOKTQ98D4SPJKFqCJG7HCFonaEVw5uqNoXt74EIY5bM2j2wrVZe PQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mtcpt9j50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Jan 2023 18:37:48 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 305ICxvX027986; Thu, 5 Jan 2023 18:37:47 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3mwft02jr1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Jan 2023 18:37:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X1ThhYeoydiisS4ho7xcUQw0jVrJfJm0O+RxGgA5nBWoK1BaVQ8S7hYv9GHrUCWiw0KBrXZ0fWPROkDTmEFKISFSrfRCmrtcu9nDMYAprDj5EzMwgK1OCGyVoMNUcFaPoI8KGLEvBH16+LEKpJPsW+eUAZ3sQmfcn6EnkQXmbMJknwX3GLneV3DE7gQpOBHuo3ekZz7mhxlPFp7Xc7HACsCP0ZJxnA8tN3abl7Ek9aqTvux+yt0OIfru0/CgirY17GC2Q0BM3w9NZ16cPv1hXHSEkiZilOwUKYiX7JQjSGedb33Da4jvsRcks0brbbgivRkGvb6T5CaMKoIsNPlu5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KUWMGomMuXF9tI6SsY8poBzvu+IZTVGXBDR9YywW2oY=; b=cgk96ExK/rh/iXyl5No8lF6EEkTb3dnlrTGszpTQCYbEpq2JNId/5ZXpnDA/4sFQ8SBwVLWiDs1cmtvGhFA42NJlssM2vBrksIca6v+uUVHnKFoBD3RhztJ/ulnYkHtXpU2hE578JlIN9VXY5f5nrUq3b44VT9KJkGtXk6wOb7mnAgFT5jTdsu2s1rY96FLhtSgf9JPujmtg+pz8Lx8ftBXqppfjqK+TFE7RAEVZMooEK+WJk2/pTCkkeTtQyvzZSRTCX6CBcq0LnUIAxL2aV+D0YfPik8gm0Ft8Q8cUDdex5J5PKx4avCtl1CFoMxv2421jIgDoLf9c3oXreKtEgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KUWMGomMuXF9tI6SsY8poBzvu+IZTVGXBDR9YywW2oY=; b=xSkBwjsuEiihuIldnRhorMus50jqaLHHwGWJczDggbRhi3GscMCFLPnH0xvrwbBD/AfyWzicMKr1rrsYFXAHwn9VrdGwuo4FR2V0b95clKL9pi0QahHPvYl/1XeZRMwBFPGjifOkgaemtYhx5JUBS7qAgA8RKtImzpmKlxCjcns= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by CH2PR10MB4277.namprd10.prod.outlook.com (2603:10b6:610:7b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 18:37:45 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::3a1:b634:7903:9d14]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::3a1:b634:7903:9d14%8]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 18:37:45 +0000 Date: Thu, 5 Jan 2023 10:37:41 -0800 From: Mike Kravetz To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Nadav Amit , Andrea Arcangeli , David Hildenbrand , James Houghton , Axel Rasmussen , Andrew Morton , linux-stable Subject: Re: [PATCH 1/3] mm/hugetlb: Pre-allocate pgtable pages for uffd wr-protects Message-ID: References: <20230104225207.1066932-1-peterx@redhat.com> <20230104225207.1066932-2-peterx@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104225207.1066932-2-peterx@redhat.com> X-ClientProxiedBy: MW4PR04CA0364.namprd04.prod.outlook.com (2603:10b6:303:81::9) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|CH2PR10MB4277:EE_ X-MS-Office365-Filtering-Correlation-Id: aff75cac-e10e-42a2-c3bd-08daef4befa9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dx/ZkUV98kYnSAc+fbtZVt3EJs0RZSFaucoqTseCeCMtKoDUaerlNVJCMUGHKLuD93gn0A4JQa2d8F1L1sfB8ZYWtsG5ZVgLTZstb2kHYBWen9bmsIdkJykk7QRw95jFb8hvRKQPDfrh5XA8FhgcvYqckvOcWlEx36zMtfwOHGpGhE5NMvjxuAMy6ufDHx+lZKHsERIVLzcljsWVpyEHHYlLDf86mi8jTy+YSz7kCLBicQf70Gpf1wkixniYgRVKaRtK3pV/zx+xRrddOHtvuUcyu6V58OPgsjMSwUAjaVuNMhsMezsJN6EKuE2aC7bqgTIn5M9MeTZsnhZes+k9TVWnBfbxGwTnfFAYNTkZmFiVqfE/X7EqexJpnz8ru2hjOLUbJn7jg2Doo4jLT57zUn2UXE+O46FPyxvlr7XkzDgtQoBrWanGTnVYmnP472QPbNR9ahXqYkmrndDrWheT4Qg8HyIpgwk31T4Spwj5FPzlwgi+S5qxv8WpjDvbMpLEWW07rvqXlt5QOnAs+wMGopb0s0YkdJx5OO+N4QT1g70CO/5IGqmIO9Od2epFFBOzenzhA+13sTQ8LtJg7JyggUijximAYeAfKws/Vr5CsBUsKIwLnIOvXf97/0qJj86yX6GqaKppmDoptOJrametkH67kdMjnMGdSBUMND3H/rYs7KdtjHwTCR7FXSrPYn6P X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(136003)(366004)(396003)(39860400002)(376002)(346002)(451199015)(6512007)(478600001)(44832011)(9686003)(6486002)(5660300002)(38100700002)(7416002)(8936002)(6506007)(66946007)(33716001)(41300700001)(66899015)(66476007)(4326008)(66556008)(8676002)(53546011)(6666004)(316002)(26005)(6916009)(86362001)(54906003)(83380400001)(2906002)(186003)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+bMAL7Xb7SIxOxttWc1TQ5XWwtlT9hg1VVB7EXxlhNcdGxCb8ikOPYuyWA8n?= =?us-ascii?Q?ULI+TbSSS9hqUKvMHq3StHjih4y+UHMrsPfTaQ95HVKWp1rpQa1uljxYJNXx?= =?us-ascii?Q?DHMk4qOIsGdUqFg3x31ld9PNwthgaKLnT+b0tXXIz0JyBliI4i1O1ofCnuSs?= =?us-ascii?Q?AAn6z5E3bBEwgCSPwVn9BX1WP6+dp9rO7OVBVFjXZC3h2O0IOiTup2dtQCCj?= =?us-ascii?Q?byNUjtGGEgI8NlUo9+Yi0lqEwsXTFzc9i8E4zRvYXo1pYngFdiAzgpeX9YDb?= =?us-ascii?Q?ggEPvzvUSe+eOYO7C6WzehXvhZ9UYODWOT9I+FS8LL/eLGnWf4FOCzqjb78f?= =?us-ascii?Q?aJ72J5qSvtzcpgwDjqiuPs+CON4+z4FcvpaoaJhjNLtwd8CNFk+7S/2p8ZlX?= =?us-ascii?Q?geTq1flyxZCS9gl0OqYGFwyKN5ohBYmZxzX9R+TI5LCd8C0FbYj22V+Z7K/j?= =?us-ascii?Q?N2XUfXC9lVlHnyTk+vk1zTpITnRQHbYT6daRI8EI+OyaKqe4UPlkb2TS+4HS?= =?us-ascii?Q?kJWTBd8MguwGEEoumsQ83KflHRgerxqJUSHDL+u4B6aK7QuqINz1CLg+Cmwq?= =?us-ascii?Q?vhJr3z8pv7fBIdHmcF9u1dEBJXr1+CAUt7BRlIaGfQCD7bcuRhBUO21Z7MSQ?= =?us-ascii?Q?vgw0FPKZmbnQ09RHPE4mvF+/FYlPpv9H6+kY1lZL3kxRuPgfhvgu2VvfZidt?= =?us-ascii?Q?0h49h1MVNUXSiDtOuGvpTW2xXNSBYlIepUwcc+VtXifUUpwb8vD+ER/CgNDH?= =?us-ascii?Q?zMuvzDxeSRB4MwI0H4+L+EJNGvENEUBrnwgAJ17YVZIcuJrEoma2U+QrCXlm?= =?us-ascii?Q?7afhOsD5kw4tCmaqhxk95VCJsYR2m96omtccyx+qGVobWm5eNogf9m93nawC?= =?us-ascii?Q?gqFooyn4c6YuHT3i+Coxb3cdhz6rtdkGJFldfaKSxqDIDyJJ/ihlacYXdeWL?= =?us-ascii?Q?+thbSOBs3WqQJ1RATxuCrJBUOE6MXdoyy5Yoctj7uXNYbwE6ekCDMawr6jo4?= =?us-ascii?Q?T1uWRmnIHasHQi7uPJm9tdI4XMMokOlegMw11J5+o4wzAljX5v0rvphhE6Ly?= =?us-ascii?Q?NkEWVvx+hdnEQfryoTtdMB62mEeXqIxvM2yVWxQPy9PkPZPhrqQle6A8Ea7K?= =?us-ascii?Q?Pcz6giDxy9E7MBl7RCb5auXGKLxOYU8ita5mDFOFQrbIFPoGoO5EibRJwW7+?= =?us-ascii?Q?A26sB2sU21TjCcq244lvWsBQjgIDzLuDFLHwygbgue5QFWqvqL2pqledP3O+?= =?us-ascii?Q?1tW8ve7WeElmADTEULHTmVc6VWuXm7Z06LI5s8Kn87dI2W5EAYfKL/Y2Oaa0?= =?us-ascii?Q?8aExaSPfv0szbQHYhF/bAsm8+wmxMDWjuIrtc01gXNjLgUlHGp5whhgmDBzQ?= =?us-ascii?Q?QuHINBRpGqZHKTIS+7YmlzqWfeOGCBH29/Ion+sgp6BsnkwWacApJaMnTnQT?= =?us-ascii?Q?khbW847SEP7DHdFSKZLmYDtjNDV6F8mLrSeOaH8tOi7z6C3M+p3cfs2X8RK9?= =?us-ascii?Q?xh73Jo8Dx8LOeGVow8Kn4HVlNIahxqBj/ntyRPk1hjpW8sJZYxGPM2yu10Od?= =?us-ascii?Q?q2xVGXz41+PavpBaRzx7oyBE/fUYQYg3waTTwJsidsaFgxBZdXAS68WxRc93?= =?us-ascii?Q?sA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?0aC7F4NxP8vLgu334HCPXAIkz2dJqnPo3oEw2wF2CKBNERNpPjaCh8UhWB2H?= =?us-ascii?Q?tKY5xUfFGw68IgbD0/sqSOZBnNJG1+zfD7ejF1ty2Uwr8s9nmqO+GpKSX9/e?= =?us-ascii?Q?R7NnzUxsMh+MqvsLpVms3wo0jaeYzCYNsMfu3RtmJRwZVamIA1x5rmG1SMk2?= =?us-ascii?Q?4t4qMD3JaoiSL6Pfx9mMXJC4bD5PVB2OWPG1KmX1vhYzwSyd4KVtxnka7MlL?= =?us-ascii?Q?1MPCbOKMp8blgkyao6jhPCtH6BqEp8Wq5UEEgRVT6bkk3pxF103JoFbdvLjW?= =?us-ascii?Q?lJcTIPDBT42DS5zwYtduUp7Zct9KSiVN4TvCCAd8LTyczYlegNWY1YWoNEp8?= =?us-ascii?Q?O6NNODnffWdtjMMDVeafxsg+uQoqB2MFR8QfwJk9AXhTzeFiYCxeJEFPQ4+z?= =?us-ascii?Q?Mc/e4CoLclregVwlCUYKj3zA6VrgBZx7JB0W+++ZJJLiciACsv0c1/D0MLmD?= =?us-ascii?Q?3/EI3Kttw4YkpsXRxVVxLKIxwXIYes/G0IRTlHC+Tco+yTBO782adzUfk3SU?= =?us-ascii?Q?noAKR18IBxexy0rMQiuTO++pBzxxOIFDxf8QCcrJUSb6d6afIxFXPcpnctIt?= =?us-ascii?Q?9TDec9RRmrlGUyR7x71QUqeo2zewsQ8smtvX63iZb9blvZQWr0m2TLsYKcg6?= =?us-ascii?Q?+DhznqrvKeYTu6rz1zgXFySAte1VFDzsvwdaoXyZa0oaxfnQOOU3cV7Nb/ys?= =?us-ascii?Q?bxQKX7AI3C37QEoTU3/1082GNANmtESWYuG2FwJnrM863EmDDZ4Jp4S0UB1v?= =?us-ascii?Q?ZCN+A/Y95nF8BMiwxBW9vOv0RYk60ya/lJcwGBVeiZ8kQo4W+6XGuxiac6Q9?= =?us-ascii?Q?lkPW40sesnHr9TZtkPsU5TUwipSIdaXMqTc+W8y0cLPwM6AGotQpp9Pt1+O6?= =?us-ascii?Q?zDluICvHpn1GJBzk4YsVQTI1ogtETztBiHL12yqXUwqMKXw/U+dgoRd7HSTA?= =?us-ascii?Q?6/0L6ZuVqcWifpt34my1e7fxAhzoWUwA6Qb+hZF7xgD8vSm++hYjog5V3TnP?= =?us-ascii?Q?196+sVlNQsWjONAC31R1tABdxLPq2iBERf61ZZMwIhMOl7RtHlftcHqKkyq0?= =?us-ascii?Q?4H37bENu6e3pDj5QBovnVj9T/aWa5Q=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: aff75cac-e10e-42a2-c3bd-08daef4befa9 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 18:37:45.1780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bRKnQWzgSsiMCQOslihvFNPukbJag8QQuPvXqydiha7FNcU8lvi2WIaYAjo8pPGh6OCsIf8i7XtEqIxD7BJsxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4277 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-05_10,2023-01-05_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301050146 X-Proofpoint-ORIG-GUID: _EfQqk_SsORFK8a33fYErqCKVRojCABx X-Proofpoint-GUID: _EfQqk_SsORFK8a33fYErqCKVRojCABx X-Rspamd-Queue-Id: 3E6E7180008 X-Stat-Signature: wraqw4up6p7no6dkk4phosqf7t6syp4c X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672943912-110325 X-HE-Meta: U2FsdGVkX19DSkBP/zoFp/KGHnO44jWTYzELaA8zvY6gLrjr7gX8ptHSLBHpiaZ/KrQO9pXi5SW3MNUGSE4zA4cWVvIUh6rnYq9jJ+mzJsh5BA8222NAN+k3PcYHKfvNPmSE5RWPjlSHpItn6ngCd777XXJGwMUHeXJIXXToAsNnUZsCd7VzgoSXXf9AdO5X/66sXln/fZKbmQroME/wqCKRvj5Gu++bFyn+yiN9ReRo0qNXl5s2oGWKRX1C8EiQcNA69RFVK9651e4Ktq7Ex21x/3hQIsfpSkQq1hAYvS3yDjE4+NANbqknAAX/UEvuPdO7+icjEFhF7YN/olg2KaxrTQQWT59je4r5v1NO04nuHvSYs7yQPdsPqoNuHcy07+sT9Bmz0Hbr4+DXaw1YYZ/PqgYuWLJhInzIXGwXL0AqaArjWHt3SuBtTH3tqL6MKQ/SOpgYNXCclifcvjDBtpbX6hNWDxBS/2Fjx+iFajbAJmqnvt4dHy0YAPMpNP8EEbf1C3oQ0tQgfsQGxTk5IVIDAF8qmhZsY8+0dT73AuPyuE1/zVZiL6jRdAmk84ZSgV2u/kFKJlmtcrk3b0Y4fAf8pPf1d0IOj8ecGWzO3cYfTjQKkkjbAIJYhY6TI5J2aSXBN0DYPtBK27c4U2iUQXdGSC5GZaNEUT9dehYc3MaFOtbu/DZCNaO22AqyKDQabZaGIYKw+X0HsgZACRF3uMKN3FxW+BMxFzHp8Q0zjq7Sj3zrul5YyEcRs++ptqhBLIMphr9jdbIxC4t9njy+GH8/xiteyId2FiaJlP3UJyYsmY4XAoree7SnC/TjSVnXC9gebtGLYM+sGlSNRvb9Utx0qXH4uAzSwt71SZMUv5+NUSpoB++tu6XMohI1A7J4BkSCj0zRPVssh8Be9ZBrLvFezcYoNIfA8tlH0zb4bsmeveei7ZUDrvF43MXtKepu7FQ+Z10gJohuL5Ekf8Q WtgRYYr6 kzsFzhCn82UJMYBhESXnchn+UBKPyOGMDjWsMPhqZDWaqnnlgiboWWDwNvxH+sA2y5TybE8B0jYy9mJwAcJGUxEmLx2hDHzo8BNUte5oXH8N7K7qp2E5GqWXkCfusYLGu7w6F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01/04/23 17:52, Peter Xu wrote: > Userfaultfd-wp uses pte markers to mark wr-protected pages for both shmem > and hugetlb. Shmem has pre-allocation ready for markers, but hugetlb path > was overlooked. > > Doing so by calling huge_pte_alloc() if the initial pgtable walk fails to > find the huge ptep. It's possible that huge_pte_alloc() can fail with high > memory pressure, in that case stop the loop immediately and fail silently. > This is not the most ideal solution but it matches with what we do with > shmem meanwhile it avoids the splat in dmesg. > > Cc: linux-stable # 5.19+ > Fixes: 60dfaad65aa9 ("mm/hugetlb: allow uffd wr-protect none ptes") > Reported-by: James Houghton > Signed-off-by: Peter Xu > --- > mm/hugetlb.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) Thanks Peter and James! Reviewed-by: Mike Kravetz -- Mike Kravetz > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index bf7a1f628357..017d9159cddf 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6649,8 +6649,17 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma, > spinlock_t *ptl; > ptep = hugetlb_walk(vma, address, psize); > if (!ptep) { > - address |= last_addr_mask; > - continue; > + if (!uffd_wp) { > + address |= last_addr_mask; > + continue; > + } > + /* > + * Userfaultfd wr-protect requires pgtable > + * pre-allocations to install pte markers. > + */ > + ptep = huge_pte_alloc(mm, vma, address, psize); > + if (!ptep) > + break; > } > ptl = huge_pte_lock(h, mm, ptep); > if (huge_pmd_unshare(mm, vma, address, ptep)) { > -- > 2.37.3 >