From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25ACC3DA7A for ; Thu, 5 Jan 2023 09:54:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 384538E0002; Thu, 5 Jan 2023 04:54:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 331E48E0001; Thu, 5 Jan 2023 04:54:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FA0C8E0002; Thu, 5 Jan 2023 04:54:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 108978E0001 for ; Thu, 5 Jan 2023 04:54:04 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA3C1A0504 for ; Thu, 5 Jan 2023 09:54:03 +0000 (UTC) X-FDA: 80320284366.08.89C6B0A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 40B3840008 for ; Thu, 5 Jan 2023 09:54:02 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=YnV5FLFl; spf=pass (imf07.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672912442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o7R0dE4bqUw5XfGhYLBT3+4wTfceQ+xf8fK7KLUkqDk=; b=joh3ECT/uxhtHwxHafsOGB1L/RdHbhoukMhUDrZJeexy3Rc1cw1tbXRwZlXX1iCSt7IIbY OH3avlsyTjj3CKrT5ghrz67SA/FKerj3RMC3MlHSEiIXO0UqjHyGHK74jQSmpO1F147zTU tg5oji0F3XAwSa9Tf05U0Mq7uf9d91w= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=YnV5FLFl; spf=pass (imf07.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672912442; a=rsa-sha256; cv=none; b=qDLaqo3cqabw7+blGWa0BXkuhp1rWlp4UhE/EHTBABs2QzEUFjU8tbYI+yvBZHGg5AaXl0 peoU7Zj11H9IUnK1TioE+Mo+4O89Ogkn8M8S7eI4vbFfGGuLgeT1aEkgrCC3oouz16p30E i0mGlVVhyybsrWx53rMJLDJ8Kc5n9rw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A60C61958; Thu, 5 Jan 2023 09:54:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE69CC433D2; Thu, 5 Jan 2023 09:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672912440; bh=FH2IdRVONYmJaCpZAfwCyvQ6r1cU3bykTJdrFIkIfbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YnV5FLFl6ciYvICDm9NbRpvqmPxYg9RRS8ODqfaTxKFCTfAZNfo7G2CQX7gbaBvwO A3MHZ2vwr+HXExWDeMXWsnBoNnun3D5JeR6DwX9o80qiVznpZLUUGDN2v1e6AGHTaO K4Y5ouqJbmgj1+wVsRVjmnCxlfCF7N5PcIzDgFfM= Date: Thu, 5 Jan 2023 10:53:57 +0100 From: Greg Kroah-Hartman To: SeongJae Park Cc: kernel test robot , devel@driverdev.osuosl.org, damon@lists.linux.dev, linux-mm@kvack.org, oe-lkp@lists.linux.dev, Andrew Morton , stable Subject: Re: [driver-core:debugfs_lookup_fix] [mm/damon/dbgfs] ff25f87cfc: kernel_BUG_at_lib/list_debug.c Message-ID: References: <202301031611.c49a0c74-oliver.sang@intel.com> <20230104183539.1509-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104183539.1509-1-sj@kernel.org> X-Stat-Signature: if1jfkhhfke7c1ekhqupy1paw75jh4a7 X-Rspam-User: X-Rspamd-Queue-Id: 40B3840008 X-Rspamd-Server: rspam06 X-HE-Tag: 1672912442-336927 X-HE-Meta: U2FsdGVkX1+Qn8exIwk/a0wLjSmrQP8EcNFtPuVIJDqEJTa+CBsEnOoYPKZ0owOFMVELL7EcZ6SDVezEIV8GCKy3im5kRPFtv9HeGHhxphIRGH0A4iige4MRE0eHCSearvDByPuPt+2H14gfZDuK5ylSJrBVLR/13f9pVfMBm2LSEWH4+BlhR/JB4+O1d32HW9kee/3nWHX8ivoQcYr6Ile7UbvhSt666rsW17yRffWWpctzHAOfV3Z4Z29qhWwM0NPZCqGo/Gspv30D/yVYATAEWm7r3jC6Dq2vc/BFr1dqk7rzmpZrBT49EHKFmWo0QXrfCEBGxOcKSjelpeZkPb4JDLraWRjzblSZcfET9quaHm/brxP9uPdlzWI4p+Hn/jkZaNhLmiaNh9IXq3FATAaLkChU6KTXdVzDhHYmES+r18IONB/KTKXbdpcVphF7OTuFb4JZUXq1KgDBpQf+JpNadd/Ilpurqvo59KPWSgTuzzG+QT77DDmemFxMYq+IT+Y4So+dbZLMujhOtN+zp3AJhtyN0TqVLl+1DjKJpR88huSUbW7JhSU21fb2bfsEy0haQ3iKQGYTXwUlm7/hHM27quHgpDKqT+jQpvLAoUQ0uCGg6ENack26VWtfZnEPRxwPyQH8c6Na+xxzmRYtHANuY4FW4upWfD6Kf+pGiOTiJDsg7SL7ykywT69oFHePOyUl8KECAd2GjhUhnx9MgccLlMLCSRS++i9izB5FNGDSC0Z5PhJX0OVM3DdxVxsXI/KUtk0P7yq3LMdTIjAqTJNMlQSowepHSRluN7mndRFo0Sn39LRcsOAa0dAK9zrZLQcU69uSNkpx1uLsPJjW82J6Xr+cyf+Sjz+1QpDLqca8sPhcgzORIuxdogXu4c4VXdkMY0PyAfpgrh/V36OsFTJ4g5IsqFUf7BXdpgi7oKPTyvqhphMP9+iEJzD/nCX74b0kU5F0f1ZsM6m5dvD OIupU3s7 85rCDQnNWoleyWQHCHb/QVmlDVI/xoeyuwjbutvMtSvow52bYvA8tK3XT9uzp1B9W4b1i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 04, 2023 at 06:35:39PM +0000, SeongJae Park wrote: > Hello, > > On Tue, 3 Jan 2023 21:16:09 +0800 kernel test robot wrote: > > > [-- Attachment #1: Type: text/plain, Size: 7528 bytes --] > > > > > > Greeting, > > > > FYI, we noticed kernel_BUG_at_lib/list_debug.c due to commit (built with gcc-11): > > Thank you for the report! > > > > > commit: ff25f87cfcfc34ebe652987f2a7beb184762785b ("mm/damon/dbgfs: fix memory leak when using debugfs_lookup()") > > https://git.kernel.org/cgit/linux/kernel/git/gregkh/driver-core.git debugfs_lookup_fix > > The commit is for fixing a memory leak due to missed dput() call. The patch > has posted originally by Greg and revised my I[1]. The revised version has > merged in mainline during v6.0 stabilization period (1552fd3ef7db). > > The problematic tree (driver-core/debugfs_lookup_fix) is based on v6.2-rc2, so > the revised patch is already applied. But the first version of the patch is > applied again on the tree[2], probably by mistake, and caused double 'dput()'. > > So I think the commit seems needs to be reverted. > > If there is anything I missed or wrong, please let me know. > > [1] https://lore.kernel.org/damon/20220902191149.112434-1-sj@kernel.org/ > [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=debugfs_lookup_fix&id=5167d3e8149e332204274910da1057e8f907d7d2 Yeah, this is my fault, sorry. That branch/tree has not been looked at carefully in a while, I need to refresh it properly and verify it all is correct. I'll drop this change as part of that work as well, sorry for the noise. greg k-h