From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: SeongJae Park <sj@kernel.org>
Cc: kernel test robot <oliver.sang@intel.com>,
devel@driverdev.osuosl.org, damon@lists.linux.dev,
linux-mm@kvack.org, oe-lkp@lists.linux.dev,
Andrew Morton <akpm@linux-foundation.org>,
stable <stable@kernel.org>
Subject: Re: [driver-core:debugfs_lookup_fix] [mm/damon/dbgfs] ff25f87cfc: kernel_BUG_at_lib/list_debug.c
Date: Thu, 5 Jan 2023 10:53:57 +0100 [thread overview]
Message-ID: <Y7aeNRf3TyTufC8L@kroah.com> (raw)
In-Reply-To: <20230104183539.1509-1-sj@kernel.org>
On Wed, Jan 04, 2023 at 06:35:39PM +0000, SeongJae Park wrote:
> Hello,
>
> On Tue, 3 Jan 2023 21:16:09 +0800 kernel test robot <oliver.sang@intel.com> wrote:
>
> > [-- Attachment #1: Type: text/plain, Size: 7528 bytes --]
> >
> >
> > Greeting,
> >
> > FYI, we noticed kernel_BUG_at_lib/list_debug.c due to commit (built with gcc-11):
>
> Thank you for the report!
>
> >
> > commit: ff25f87cfcfc34ebe652987f2a7beb184762785b ("mm/damon/dbgfs: fix memory leak when using debugfs_lookup()")
> > https://git.kernel.org/cgit/linux/kernel/git/gregkh/driver-core.git debugfs_lookup_fix
>
> The commit is for fixing a memory leak due to missed dput() call. The patch
> has posted originally by Greg and revised my I[1]. The revised version has
> merged in mainline during v6.0 stabilization period (1552fd3ef7db).
>
> The problematic tree (driver-core/debugfs_lookup_fix) is based on v6.2-rc2, so
> the revised patch is already applied. But the first version of the patch is
> applied again on the tree[2], probably by mistake, and caused double 'dput()'.
>
> So I think the commit seems needs to be reverted.
>
> If there is anything I missed or wrong, please let me know.
>
> [1] https://lore.kernel.org/damon/20220902191149.112434-1-sj@kernel.org/
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=debugfs_lookup_fix&id=5167d3e8149e332204274910da1057e8f907d7d2
Yeah, this is my fault, sorry. That branch/tree has not been looked at
carefully in a while, I need to refresh it properly and verify it all is
correct. I'll drop this change as part of that work as well, sorry for
the noise.
greg k-h
next prev parent reply other threads:[~2023-01-05 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 13:16 kernel test robot
2023-01-04 18:35 ` SeongJae Park
2023-01-05 9:53 ` Greg Kroah-Hartman [this message]
2023-01-05 16:54 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7aeNRf3TyTufC8L@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=devel@driverdev.osuosl.org \
--cc=linux-mm@kvack.org \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=sj@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox