From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18B7C3DA7D for ; Thu, 5 Jan 2023 09:43:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02EDD8E0002; Thu, 5 Jan 2023 04:43:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F20D08E0001; Thu, 5 Jan 2023 04:43:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E10648E0002; Thu, 5 Jan 2023 04:43:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D07258E0001 for ; Thu, 5 Jan 2023 04:43:54 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9A7DE40D79 for ; Thu, 5 Jan 2023 09:43:54 +0000 (UTC) X-FDA: 80320258788.17.340C70B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 18909180008 for ; Thu, 5 Jan 2023 09:43:52 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZSyAQtiN; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672911833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F9J7GXH7UK6/ZFNwO/6rVPP+hAXvpNHH3HULANonYRs=; b=7Af+d29jzBpjEFaY1tbEgzFHyyBYstzZvXqJfp8rgVpvB4iKjQN0RBg8KJMITnzv8MjqIZ +gCWHZ61tmwpIwfBvRF8el5Y1PK90fobqzVgVf5tyl2YeTWUC0eQcE2FWZlnJkzF+a6oet wnZ7VP0TFINfnYjTwyYgPMpc6LKGYlQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZSyAQtiN; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672911833; a=rsa-sha256; cv=none; b=mekxR7LlWe045g0lpqEGr0QX1Z+1mQU4N1HmdZDrz9JUToRi9QKOXvMea9SSQD1Z4OHMzc xPA0kWZqDDcJ7CfIpTdYVkMzRY96SAGdNUd0PEA7S1QW4nUW06sPV35Md/4YTzruB4XmU6 Eu6T4HK47f46PTAGCnRNtw2Zqlm+Jl8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEBC96193B; Thu, 5 Jan 2023 09:43:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D730C433F1; Thu, 5 Jan 2023 09:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672911831; bh=xk1y0PNrseh0gfuyYl1OAwYL8s7WC1qYIROo2bur1vA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZSyAQtiNY121quJjcDB1/aD7gGRdHulbZWPvCgwYTntvaK1Y0FQ5mxMcEeA2HwwxX f3Brl0T3UZGTjCTLPhU8u+8kidWiXU4OHXJCks6D8GP6oZuIAdpI3M3TxRzUwvv/yH 41sIQxhNVrDtvo1u7GFm2kZtvS3ZqUebKnZ7Rrk87yQAjEoxO2yJY01eJ7SD8BG1Hh eUJMK3HHzySkWOx5V0T0dlAG/aKr01AAefrfW3qUMWHYouRAxVFZuapZJ2k+Ts7bQX Zm8gLFwCRZ2vvBpcX6ajRNwtl2hWMhiYXZas8SX2Xt0rsmClFl+sz+P/4Gf309fB+i cOmN/7HAxbtbw== Date: Thu, 5 Jan 2023 11:43:45 +0200 From: Mike Rapoport To: Anshuman Khandual Cc: linux-mm@kvack.org, mgorman@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable Message-ID: References: <20230105082506.241529-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105082506.241529-1-anshuman.khandual@arm.com> X-Stat-Signature: eeopqs6ip6grcc668jpcaopqp1ukxink X-Rspam-User: X-Rspamd-Queue-Id: 18909180008 X-Rspamd-Server: rspam06 X-HE-Tag: 1672911832-789394 X-HE-Meta: U2FsdGVkX18VKkaOMCCEyoCbxmAayTLEXy79+pJAnxRZc/SJQL7F6zLVODP9vXgHEY0lKsXcsmZlH0m5+TyNMs4drJyOyhBvDQ79e3bRliG+qOvVusmM9RdQBrxq/qswQp5ljDSVd1ksWZBUj6KAaPM85FZJcQMFqPA0NEgMf+naiBV3KO4ZXgw//eH5UywXOsfrfUDE8zgRBoYezbzbBJdDAC/dJ0u3PGJkhGuyAFdbPRDrcYKuzesTwDk63aKqM/vzCFO5R5Ykh+8Xt1H3E+7pbuQs3A/LjcZVivTQZyxLZnKRi2tsCh5x3gBdrFFPkssLM5WsbO35NBUry4H6R7AZ0uRQ9Tl6AFu8binHd32XaJ+SJsNnSirpXn/fzCkH0UYU4o2p6QOfaFctodK8SMVkg3bcaE1zTPqe2zECpj5ud2a41rgxhri48uvCutB+yVrwgdDqyILMjOixPZVToBzwXpkJ74SmR4EOzR7sAMsV9ztmJNJSx3weifUuXa4caB/YLWMP40BS62qsGYVkG7fGbSSyizVF34Z6PAltzvcxVTLBR1EU3fg7Or4jILK5YP4e1olObO54n1elLcGfcdDGb7JX01zpx+T0YTAJaeEg/Z0BgjWJCch7JO70MRRDAaHLSe9JD+zbD5qGkECSENwL/sobEikelf06qTRtGlsb5ZfiVucGUTDtVnNZdLn4XSR3OYEULpLP0l99kAqoSQQt7Ya+xtaOZ4d32slLkEZVXCdHOGC9ZZLlFSqhtGgzXmBUpPUxoS9b1k3cVtfthHexazDyISDUcnWZVlSotGExn7sZcphu50qT2zNXoPmvF53fb61Xd5U+4eqB/11hidUvp+BBqteQS6v6/FVdgiHGJLKEX6m8+fIQYys8mtSnjeQMVzYcvL8MGFO4wSsWZOQrvRABmYjat8H7TFr9p3UhXAvrLXoxTppdbSoR3fuVlviGwsF1gmKY+zCGLxT A5NKGkF5 WrbO+3o0vygbcf7lYyKEBCAPCWJRV/VW6y44hqX0U+dWEdPyKTx8mhCdD5pNlkvubfkWEiYU4h24jwpQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 01:55:06PM +0530, Anshuman Khandual wrote: > Instead of directly accessing static deferred_pages, replace such instances > with the helper deferred_pages_enabled(). No functional change is intended. > > Cc; Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Reviewed-by: Mike Rapoport (IBM) > --- > This applies on v6.2-rc2. > > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0745aedebb37..232d0323047b 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4244,7 +4244,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, > * Watermark failed for this zone, but see if we can > * grow this zone if it contains deferred pages. > */ > - if (static_branch_unlikely(&deferred_pages)) { > + if (deferred_pages_enabled()) { > if (_deferred_grow_zone(zone, order)) > goto try_this_zone; > } > @@ -4293,7 +4293,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, > } else { > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > /* Try again if zone has deferred pages */ > - if (static_branch_unlikely(&deferred_pages)) { > + if (deferred_pages_enabled()) { > if (_deferred_grow_zone(zone, order)) > goto try_this_zone; > } > -- > 2.25.1 > -- Sincerely yours, Mike.