From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B35FC46467 for ; Wed, 4 Jan 2023 20:04:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E84CB8E0002; Wed, 4 Jan 2023 15:04:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E357E8E0001; Wed, 4 Jan 2023 15:04:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFD7C8E0002; Wed, 4 Jan 2023 15:04:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BFC208E0001 for ; Wed, 4 Jan 2023 15:04:33 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 810AC40D23 for ; Wed, 4 Jan 2023 20:04:33 +0000 (UTC) X-FDA: 80318194026.25.7085B0F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 81B2E40014 for ; Wed, 4 Jan 2023 20:04:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R5FkZQZL; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672862671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KsNn6+8herE45H4IfoHjfH1DQT1MJEJp3AWNOg7phZ4=; b=b0r5u1YlM4xwjUhThK/+gt4fukSDw3dMqaDPEsxzOOpJ85u0X0/vR58hS8yOkxFjCfvvA0 Y4yd1oMybaW3C1VGhnvP05W9Mb403o5seI25PcTWRNP14dik6eFa8ESziECDGo6ylCO9VK SKWVPTlV2tXBduHIHnII+9Ga59f6iqY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R5FkZQZL; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672862671; a=rsa-sha256; cv=none; b=vFsMwpaCk8n6jFGCn/l4nwto5uU+vz7LbdbNYYjO7HTU42V21uFHqKMT+466nhpDDtwjAz Tcn5/JTKIajq+Y/j7Kf9wof5wKBNNNS22tlxHXsKsPkVq6w8oj/HoCSeBzSI8UdZQbvzux 9x8q0u5MSMv0eGkKxpk8CdZUE/dS2tU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672862670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KsNn6+8herE45H4IfoHjfH1DQT1MJEJp3AWNOg7phZ4=; b=R5FkZQZLufZxUj9rNTSwhR7WH6arQ5lubzsF+HHXu1YQDGElc+yhpOoMb+WSBSw140N4rc nrUUHFbO3A8ymcemebQekNglMkWeO+bIb3ch3cQa0rNUE/V9UocXR0bFHBm0AGTnCy+ksy OV9lNTmFpUHvL9yKc1uUMbCNUcLgzEw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-21-ZtSux2uSOd-_VhJmwFEw0Q-1; Wed, 04 Jan 2023 15:04:29 -0500 X-MC-Unique: ZtSux2uSOd-_VhJmwFEw0Q-1 Received: by mail-qv1-f69.google.com with SMTP id ob12-20020a0562142f8c00b004c6c72bf1d0so18049429qvb.9 for ; Wed, 04 Jan 2023 12:04:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KsNn6+8herE45H4IfoHjfH1DQT1MJEJp3AWNOg7phZ4=; b=10W/XYF8CeRmvr6PpeZnOafcUNrwkbm3bjtWBDjBBa3UAM7TBwwrMjDlOoVYtHnDaK ge6ERQdTHvjdjs4gd+OVyjeElyHpxjB33ry/d1HSz8a221N89rl9KxL3xJB6wDSGJoB+ kNzHWBLh2qLqtcFMsIJk4OHX+foJevR/98XjBXch4XMZs7qsulyAwYzAKIZPZ0ShBQHA Ht9aKOlXRlGMNkbWq92datZngA/MDgWaOtzXzxlrNe/Hy9tph6RuYf14IK4V3pXLlohQ Kr3TTTJNuZQJqThqGxspXGWksrnQdr5zWArQb5EDD4OUH1lIqYztGejtTwRyIevBu4c3 sSrw== X-Gm-Message-State: AFqh2kqbbpe/Avp/21Wef+bftNpiuzIHJwNJWDqwSi49roJ1+Cyd234H a9GEKofnOa6FId/Di1zExGdvSUimH692b7z/c8BFoUNZ29CX2YLyFdwtPoo2as1PDmREM6FUnVx mP11s3044O/U= X-Received: by 2002:a05:622a:488e:b0:3ab:6e0c:16b1 with SMTP id fc14-20020a05622a488e00b003ab6e0c16b1mr62941499qtb.45.1672862668701; Wed, 04 Jan 2023 12:04:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXsaFjL7h6gQ5ju41/7AtQskfQjy5co76i3OES7n6IcqFJfbhbilKb/W4LhkpckOGdBE23hx0w== X-Received: by 2002:a05:622a:488e:b0:3ab:6e0c:16b1 with SMTP id fc14-20020a05622a488e00b003ab6e0c16b1mr62941486qtb.45.1672862668478; Wed, 04 Jan 2023 12:04:28 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-39-70-52-228-144.dsl.bell.ca. [70.52.228.144]) by smtp.gmail.com with ESMTPSA id 6-20020ac85646000000b003a6947863e1sm20297948qtt.11.2023.01.04.12.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 12:04:27 -0800 (PST) Date: Wed, 4 Jan 2023 15:04:26 -0500 From: Peter Xu To: James Houghton Cc: Mike Kravetz , Muchun Song , Axel Rasmussen , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hugetlb: unshare some PMDs when splitting VMAs Message-ID: References: <20230101230042.244286-1-jthoughton@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 81B2E40014 X-Rspam-User: X-Stat-Signature: muauedhzne1k6nobfhdwjxow4ox5771z X-HE-Tag: 1672862671-157218 X-HE-Meta: U2FsdGVkX1+CwLaRUW98Rak/upjb7mncRMRzb25XpWtpw7ZigmRrYxMBRpgpbDdiqpKndjXSWeKB2YY5BGHDECjhSfoUDEc44TqwJfTBBIbMnTa8PPIFonXePY9ILMe47BklZiU64k8Mt8a4YyBM8J35obhwIJTWfYRkCgyLgn48ixJz4bFQHZlEGCxyi35AywmzTR3ArYTOtM+nQ9kt2/YdtRwY78c4+meaLH+NkEwFZbYauiHh5wHz5pBQpYWFRiTOLL/BQ9VU+Uksc5Zv/vtHcCkqGVS2WA28I1/VG6l6n+kKSpLZTR9k/0sfUTTT1b8v4+N2UMTSXm50sXh1GUMsh+eHmrDAwaPloa6x3bOdUVNqrKyISraCdwWbwGPSa9RSxq/4CQ8+KdcQuTJIDRqh8ukgDiF0NKBJNNrj6hwzoeU/N52hjjzQIU9qrYlpDxzzUGxcdaa7Lvv624NX28DHNpxHepwXBCx5iOhmuTzKioWS5+Kbyih3FRnsDhYzn7bRaiAxSpgLKNPjqlBd2iqw8OogH5WrZpPhEFc7nhR7NX1jdJkSwlHhbTkoGkjDkWa76TCKt3TM0yYERfoVidirO8Ms2zrpd3AJzWTfL4v1f56N6O9fBoWCCXF46T3AMjOCCxJhIz44/pbhdk5EzPT+jZO0sEJAJiWy08+WCm372MuJ+2YI+XHBJ5wsQW6LHuk6A4phJJ9cdNZ4ovdbgcW4aLJCpNNI/pgiY0D8ju7R3G+N5nfy88cGxkLZca9RxcyYo3CzH1/u99kscR8v6fSJ3M58CKgO/CrN9FDKu/tfo4y2R4AM4HT0E61O/RNgp7W12kYI41ciWG9ec9kOzSDu2z1uiA7nejXtklsewodWa4s/mnnK+tnB+7gjB+TdsYJM+esHQRoVeiebbmxoOKbCF4hafyE2qqUWwCAxIWkCL1Kpbm/HbUfsrbHsZmAdE6tJ12OL88YRzpw/G27 qr/RTVRM TZIgvxRWMEbhNBdGIshmsvMHmHBpW4eQ70ZRfpCLgphrVWYssA8WargP60UWQ/OB+tqHJ+8i8wCQuLoAqEHiUjW88/CckT67RykoCLb/x5LIUMZY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 04, 2023 at 07:34:00PM +0000, James Houghton wrote: > How about: > > /* > * PMD sharing is only possible for PUD_SIZE-aligned address ranges > * in HugeTLB VMAs. If we will lose PUD_SIZE alignment due to this split, > * unshare PMDs in the PUD_SIZE interval surrounding addr now. > */ Even better, thanks. -- Peter Xu