From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F721C4708D for ; Wed, 4 Jan 2023 20:08:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FEA48E0002; Wed, 4 Jan 2023 15:08:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 188368E0001; Wed, 4 Jan 2023 15:08:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 028688E0002; Wed, 4 Jan 2023 15:08:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D92198E0001 for ; Wed, 4 Jan 2023 15:08:20 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AB2B0A0C7F for ; Wed, 4 Jan 2023 20:08:20 +0000 (UTC) X-FDA: 80318203560.17.5A0DBE2 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf22.hostedemail.com (Postfix) with ESMTP id 05C2FC0010 for ; Wed, 4 Jan 2023 20:08:18 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jYTbS3tW; spf=pass (imf22.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672862899; a=rsa-sha256; cv=none; b=yjiMRYtwnVnJWwgT7nEofvx8huhQybTkcqIutwg3YFSfzJ63OFmivyhcyLa8wMa6E4IuVn Wd5wMwCWj1htQBSB3RlGAbKrTaG27P3Nt3h4wxHwSL9hyf3htFo9gs+4IseErSXyJnBHop 0BC7jS8s2O9DOEvusl0c1ZNh2TedvuQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jYTbS3tW; spf=pass (imf22.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672862899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OG/y7xAe7GoU0v2u69k5lX/4KZLOEKX6GSOlMx3yuAQ=; b=OmbVpmJ4Xzfr6A8ecaTV+KaKEObk6uJPSmrT20UZZsus8YqlHo36eiwJi23PMkFZj3G3Zm fmV0yDJrt/TvtDMmiivCfreeeYkmNq0zTpLS94PnnmdawY7sY5y/8iLPdiy7+AluP+2fUR cLmoC6qbn0OQ+TL0UsD4LtxV/N7qd3c= Received: by mail-ed1-f50.google.com with SMTP id i9so50128247edj.4 for ; Wed, 04 Jan 2023 12:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OG/y7xAe7GoU0v2u69k5lX/4KZLOEKX6GSOlMx3yuAQ=; b=jYTbS3tWP5PjKTYguj167jAFjYT2aPGkce/WrztXbN63Z0CVQr8Ld4Ac8efgxoL6DU ik3X9qtPNJEwy3wyFX1Ukf/DSERctCvNrNYUhM8W7RM9rm/3AQnMaGRJd4ID1dF4z3es dt0JeIWznmQgBiEyCqeYHezX8Vlzv9AtyGx9j9mm/qpDi8xZO5LkI78dyqrdoDDVQOaF nhUydsFwnoSvW3z8OOHlFeG7mk0+FJHB5RMEpQr7jTewbhwVtcYJisIUoI/YreJuAYtf 87yGTnNs/lEO7qGx/rTR4yQJdWwAs/wXt+LpBqlvRNAzxAfcW6vWXEIz2mhZ25aq0t1R kmwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OG/y7xAe7GoU0v2u69k5lX/4KZLOEKX6GSOlMx3yuAQ=; b=jr5vYZQTQcbNzSBwkflanMhQAa2jQr/E3gh3vds9otRcABYG27JlKssDNEscFbxSfP gqzUubNqh5aiX72aWd6f27q2Su2bnnF5kkUyg4EPehWyvwP9vLX+OpIMSBsez7WBPixC brBkZANNa8kPFjlyAU/TQdLoMehJR/6U0UrAGJETKkK2ZcFBP7HnYwlmnAqcBijCl8iw 3ogS563K4IBRW4n0OYpRu9k4M4/nSaFG+oDVrOUQivtgUDwZrrVXhGLIwteTlGK3mr21 BIGSby58Mhgfc1ihTUCTAbr56MxWYpQARF0DBGMOv4kCsN8IpXfquEkwoNFzR94ABTY0 pabA== X-Gm-Message-State: AFqh2kqASMNCy0+U4JFZ4UVqM5mv17MeskO526XS5TXFSLqTDPCiDB4v 1U0Dc4coeWoQyI1mi/kYjqTlrJBaQbg= X-Google-Smtp-Source: AMrXdXvfqTH0p/eJd0SwsLoZc2HcLfB3obqg0ghT/R+iy//w4COBtg/aXwEj7yayc8kTGnyia5x5pg== X-Received: by 2002:a05:600c:54c2:b0:3d3:3c74:dbd0 with SMTP id iw2-20020a05600c54c200b003d33c74dbd0mr34390181wmb.13.1672862403849; Wed, 04 Jan 2023 12:00:03 -0800 (PST) Received: from localhost (host81-157-153-247.range81-157.btcentralplus.com. [81.157.153.247]) by smtp.gmail.com with ESMTPSA id j20-20020a05600c191400b003b4fe03c881sm59068351wmq.48.2023.01.04.12.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 12:00:03 -0800 (PST) Date: Wed, 4 Jan 2023 20:00:02 +0000 From: Lorenzo Stoakes To: "Yu, Fenghua" Cc: Alistair Popple , Vinod Koul , "Jiang, Dave" , "dmaengine@vger.kernel.org" , "Zhu, Tony" , Andrew Morton , "linux-mm@kvack.org" , Christoph Hellwig , "Shankar, Ravi V" Subject: Re: [PATCH 09/17] mm: export access_remote_vm() symbol Message-ID: References: <20230103163505.1569356-1-fenghua.yu@intel.com> <20230103163505.1569356-10-fenghua.yu@intel.com> <87tu16rdea.fsf@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 05C2FC0010 X-Rspamd-Server: rspam01 X-Stat-Signature: t5ujte3dnnqjjdpesoe8bgez6mkg138o X-HE-Tag: 1672862898-194040 X-HE-Meta: U2FsdGVkX19b4feweGr6+ZdwzoC28Ejpe3hhtbZu5lhlVYUQXdEtuGi9fDiI9Vr0xg8gHDD3ah7CICKZB4IdusvkIWnMgxxHdq4pVYWlBKeVIIaQk/15WRrz1GGaS9zBsTD43nlDNtyrHeob88jcodyM0RwfCKTjb8HtQ6NaaNwDGhUSvxDsansTbw2qwyo/z4b+eO5h+iZ5US8j6iYFI/i/NYmWTEtThz1CuCXaDA0GraJy9hKogOC7tbxD08DExrKq2MMD9gZirNLE3MFEqKukK4jl78zinYllbDuhVkMSdtmqRH8qYsIoNmAe/VJBAzi+ZGJ6w8HLRH035vcnP6ONAhNOftenvLNrz0OhHHQJE7xkL0n48o4HTBy/gSruRbPlcmvj0B0deegWw/EidHADcxrDf+tTMQQoZ9n56usJ1L+3/3eQ+HM/svT0MdfCRwN2gp7flxAFbAoNwxmNqX5gl5hqKadkT7IhysGUPEvPNe4j2gberYE420mdo+cMOvpYalMDIfpt4DyKsiZbSRyaBrq7sj0TwDFROb7lIUU7CXa5mC43AzxUSJHmYO9GvFCPdV628lb36VDOx8JG8SqhDuKMfPnySyoUj7HE9sBT9KISvQb7cPbWHkr6WG/k1zd1i6ogku3lVbRMdKVAzmwMiU8dq01apgcMTRbYf+SoqzQ7pFkFGcC3jUJ7H1pHBBGjjAnxqqiXEy4/AuyxcbLjoDQmo7OxFj6SHJgH0XIpbzvBo34ZCVbRebilh5aPp7+TXl94OTd4BXA9657pxHJF79OaxNQpuM0gFCFG6HU+a8pDM+KWm3/rhNu6DIFrknkhjnEFjcYu9MReiqrdL8QKGSrIAWX6qa6Cvf2EvtQHUxQuA38GGFm7yF3AvZGolDo1gBI39SQvb7zmVwrYM9QOn1U4WkWDfni0b3aoU17/7UhPhVit1epvkPp85KwV9ettvvX7eRX1c3r4Eqe 7XVwLh7t E2ygPntvGfmK49ylT7ACgQ4fGZPflxlmHgfYqVtXPvOqg3kA/kdXjtyyu+GJFaqQdUlkXGKkDer6FRO1QNMNMxOmefPIX/UyLURH+dw7PKUu7Df4AXBc5qKT8RmKpW09X4GdbRDBjKZuJ0o7RXqNWZ2nF//P/NbmZyZnwVHtHOyINFUQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 04, 2023 at 07:00:55PM +0000, Yu, Fenghua wrote: > So the current patch is good without any change, right? No, you'd definitely need mmget_not_zero() (and a grab in advance of this, though from the sounds of it you may already have it), I definitely don't think the patch as-is works, see my reply to Alistair.