From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87BBEC4332F for ; Wed, 4 Jan 2023 18:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FCA18E0002; Wed, 4 Jan 2023 13:10:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ACF48E0001; Wed, 4 Jan 2023 13:10:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6746B8E0002; Wed, 4 Jan 2023 13:10:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 57F268E0001 for ; Wed, 4 Jan 2023 13:10:27 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 256AC40CD2 for ; Wed, 4 Jan 2023 18:10:27 +0000 (UTC) X-FDA: 80317906494.20.9EF9ACD Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf17.hostedemail.com (Postfix) with ESMTP id 6810040015 for ; Wed, 4 Jan 2023 18:10:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=fyiW6W2U; spf=pass (imf17.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672855822; a=rsa-sha256; cv=none; b=QpycxdtgKijDpeGIaJ5xaWkmDTMYIewb+CdQ+6afbh7Ngml/Nc57hvDelTWOIjTnbk//sY upVWI3LHhLzYh+ZEHlpDfZknozeXQgFv2JuYPfoEAE4cmDMFTtR31m2AeKTYE4Rt6AdVsV X/cHkPYWQPFNpktnSoid4Did8EV3GWY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=fyiW6W2U; spf=pass (imf17.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672855822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7GBPF88wzdVZ7ar1F+eZ3hgfidY5D8srQT8J/QpDwvc=; b=Crsw+tHZ9GoEMSkwpT79n8i0ipYyosGCS4oVN4BHgguZcMJ5BnlPtAMHZTOoJCsV7YEkC9 MTj13h7sVd5FIjsHZZNlYVIc43tkdx1A+/lLxMTCNop1weUnRoTVA3Y6KJTbXaEM/GOQZD 3fZ2E82dnwvIiztAjNo55vQg2x07cdc= Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 304HUcG8032586; Wed, 4 Jan 2023 18:09:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pp1; bh=7GBPF88wzdVZ7ar1F+eZ3hgfidY5D8srQT8J/QpDwvc=; b=fyiW6W2UUN8LX92+pUjeVSnvz51f7TnyzFENkpC9v/GweDqnRwuxyoh215RVbC/DJ/AQ 2wbVM+EzRWCEAmzmwiojm3CpchC0Y8ZmWUr1x10H5LHQra4UxToTRms7RUKFtnV9AOT/ Nb1EvDzNT8pngUWXgk/d80u62D8s23dr5qfuFmBlayG9GXKDrOZVg3URBzBXPtLQBjAm POr66aqy4XecphxqgSsuXd3HzdYxrH1T1/If1l4gIJ0mkfKSF51Yi2sMMITiJbHYqDg/ mUP2q/DTQrLrpbJM2eyJGE7hMsZNxNfDs5JzW+bUeZyXPTic79NtgHeaIb5XEvYJuVWR 2A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mwdwy0xas-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Jan 2023 18:09:53 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 304I7i4V017758; Wed, 4 Jan 2023 18:09:53 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mwdwy0x9d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Jan 2023 18:09:52 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30486XjM001864; Wed, 4 Jan 2023 18:09:50 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3mtcbfdpdt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Jan 2023 18:09:50 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 304I9l4M48759224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jan 2023 18:09:47 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B830520043; Wed, 4 Jan 2023 18:09:47 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6E85E20040; Wed, 4 Jan 2023 18:09:46 +0000 (GMT) Received: from osiris (unknown [9.179.28.126]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 4 Jan 2023 18:09:46 +0000 (GMT) Date: Wed, 4 Jan 2023 19:09:44 +0100 From: Heiko Carstens To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, Christoph Hellwig , David Hildenbrand , Michal Hocko , Peter Xu , Nadav Amit , Matthew Wilcox , Vlastimil Babka , Rik van Riel , Will Deacon , Michael Ellerman , Palmer Dabbelt , Christian Borntraeger , Dave Hansen , Christian Brauner , Eric Dumazet , Andrew Morton Subject: Re: [PATCH] mm: remove zap_page_range and create zap_vma_pages Message-ID: References: <20230104002732.232573-1-mike.kravetz@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104002732.232573-1-mike.kravetz@oracle.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: k9qXecJ4RRKrWMjkiEzD557REdxr7RO2 X-Proofpoint-GUID: QiYQILsN1_8J76fc1D6yWsOXcnh_ZlS9 X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-04_07,2023-01-04_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 malwarescore=0 impostorscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301040151 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6810040015 X-Stat-Signature: 7gru684oyi3dku9p44d1rco85zimdpor X-HE-Tag: 1672855822-490580 X-HE-Meta: U2FsdGVkX19HfFyrRoZFmH6aLl/dDK5CF+Xqiarcjg+FQRU03daL6wUg8TiWiOhpSw9aY25SQu1fcd5/iQHGnkk8CjfEKkdeUMYpchjFyV7lBKHZTYuOrySl4yDZ99YkXTzixjjPXmNUhqBAiRmxGOQh7zcHli+sufE0gWGo1EdG+UdWHjOIDt3tycbJQAlNrytzc93D9Kmm6pBfhuunAJnnDgwjCiM/u8qRLfLKyPmCvAfTKBxgg1sN68xkWFJ1c+oH5sL4rmrF90rckhNSvicEslGIdGZuo9/m8f3EPYxW6BX5jYnJBen+KJg4iw1q6uO1ReMArGlRSOIkpWoBZu2bdz40XCUxSExjrM1cVrZgPGEZKN7FZS8KsfcbETEvxLy5VzmThr/pQXT+PnX92xP7Nj5DvM6UC1snj4LCA23agkkjnOyeydiTyudEyObESUEuFRVX8XnmKH5I5ZrDvOGnO3exwz7LtCgNW5YeDyaOvN1v0OHmzTQHzdWq3m34PEadvJtcdW3GaHqsDjpBkKFX7UR8Uc4iz5jYvZYLMYqTUMjX2F71fBjT1mlKgixQ4I9Hp1f8/QX3RfgPTfri+Zdg5P8pV69nH9ESRzFJMqnRGDIDLuMZi4e5EPLaUf0hy8QZEJe+N2iiOTGlIShA+hO9QdJfoFazILI0DVZbyFQSNujIcLDW6sgfs4jO37uqytnPTfk88DRfe8zda9iZDKdjNLibmAxS+cPPXYTcx+YJmwG39NDAKZtRgYEvWKEMMARq/N2ygOrrDQ1xqZ8QGN/dT//V9ezAwWywqnVh4r61pTw4ZTMxUWyxmwvUZ298lBYiD1CWi6V21NWx+kOSPL91ZdUKTKlS3stS2P4Ky7Kh/HpmffLuDBMVAJwQFkl1f8rAQgHv6DTX7raGn4MlEyHmVQFr+HVTK412c6ct+SNBnTkYp5R1EIq+Y4S1V/3/ss8BOPhGn+r0food7Kv 5sQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 03, 2023 at 04:27:32PM -0800, Mike Kravetz wrote: > zap_page_range was originally designed to unmap pages within an address > range that could span multiple vmas. While working on [1], it was > discovered that all callers of zap_page_range pass a range entirely within > a single vma. In addition, the mmu notification call within zap_page > range does not correctly handle ranges that span multiple vmas. When > crossing a vma boundary, a new mmu_notifier_range_init/end call pair > with the new vma should be made. > > Instead of fixing zap_page_range, do the following: > - Create a new routine zap_vma_pages() that will remove all pages within > the passed vma. Most users of zap_page_range pass the entire vma and > can use this new routine. > - For callers of zap_page_range not passing the entire vma, instead call > zap_page_range_single(). > - Remove zap_page_range. > > [1] https://lore.kernel.org/linux-mm/20221114235507.294320-2-mike.kravetz@oracle.com/ > Suggested-by: Peter Xu > Signed-off-by: Mike Kravetz > --- > RFC->v1 Created zap_vma_pages to zap entire vma (Christoph Hellwig) > Did not add Acked-by's as routine was changed. > > arch/arm64/kernel/vdso.c | 6 ++--- > arch/powerpc/kernel/vdso.c | 4 +--- > arch/powerpc/platforms/book3s/vas-api.c | 2 +- > arch/powerpc/platforms/pseries/vas.c | 3 +-- > arch/riscv/kernel/vdso.c | 6 ++--- > arch/s390/kernel/vdso.c | 4 +--- > arch/s390/mm/gmap.c | 2 +- > arch/x86/entry/vdso/vma.c | 4 +--- > drivers/android/binder_alloc.c | 2 +- > include/linux/mm.h | 7 ++++-- > mm/memory.c | 30 ------------------------- > mm/page-writeback.c | 2 +- > net/ipv4/tcp.c | 7 +++--- > 13 files changed, 21 insertions(+), 58 deletions(-) For s390: Acked-by: Heiko Carstens