From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9518AC4708E for ; Wed, 4 Jan 2023 16:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2FD98E0002; Wed, 4 Jan 2023 11:44:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDFF78E0001; Wed, 4 Jan 2023 11:44:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C80C98E0002; Wed, 4 Jan 2023 11:44:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BA1B18E0001 for ; Wed, 4 Jan 2023 11:44:56 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7D0AFA045E for ; Wed, 4 Jan 2023 16:44:56 +0000 (UTC) X-FDA: 80317690992.02.210D8EF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id A4FAC140015 for ; Wed, 4 Jan 2023 16:44:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WxwgsSgt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672850694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6EzsGSC3holClBSPQw8EocT+rCm9w6LTUpG8IqXLKaM=; b=gWHkamJieLQFGSb9LgovIOHZgc0UPM3iwdCLTqWvjHdcRu/S1hZxyh6WTynIojBRNNrEiR Yt5bHx+RnjOdjtT8RFo0Djz+KFbncNcs0ednz4cPHFm5ZT8wP0upHVEqGm4EPb37NhpBZG D34TA4QYWxxEfZTwZhrq7F/dHbhoByw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WxwgsSgt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672850694; a=rsa-sha256; cv=none; b=mDcb7WKdICT9Skk7acMKIAJ3/l5/Ut0rxNPJJG6iJaO5+332uviSM1Rdo/bNxuGMmTI5fF YGSqjV2BpDI68VbAgPi0OsSFQkOUVeP88MykY6RJBGek0Z9x4o3X2wh7xeZvvVYTBObRSb 7wZnopwirfUl3jpuFdDU+/1BIxL33Xg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672850694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6EzsGSC3holClBSPQw8EocT+rCm9w6LTUpG8IqXLKaM=; b=WxwgsSgtV/aUyKxpMinNBr0WvgK2Zmd8TgA3cR6rxwn+KkF47DkRl6eZrYoRR6BK58TVUu 2zEeBmdhd58UT4Oxci+Z0hZNMVglItFZJJ5tSvM4l21CAh/KJLxY3ZWEmknr0kb1Z2www/ CiNvzeKsjuoWnmoZQptFStcyZzh4Z2k= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-491-T65TfqS8P3aAQium3saWQA-1; Wed, 04 Jan 2023 11:44:52 -0500 X-MC-Unique: T65TfqS8P3aAQium3saWQA-1 Received: by mail-qk1-f199.google.com with SMTP id v7-20020a05620a0f0700b006faffce43b2so23211035qkl.9 for ; Wed, 04 Jan 2023 08:44:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6EzsGSC3holClBSPQw8EocT+rCm9w6LTUpG8IqXLKaM=; b=RZhwqBQW4Z8Aab56gbG1SgncFiobffd/CiYAbxNmQvd7kDgOB/mZOG6r+hHQCFrT5J NlglQGZMpk9FEYptTBjtV6SYaM5Ne544T138Z/rfRMXTYRnbk+j3VktlbK8eOOMEi/q0 +s3QOV6D0B8Tku3r1JTXBcMQ+q4snqdGfsU9c2HX4QrCkef8JF5sTPor9aDTynkb0kXK 5URVHA6GKeMwyj39WwbT/UGsAzAtfP/Epg4o+6Un7ymCyBEZzDybG2OGofx8JXTWmWXy nAiBBb1XxDaPEqU2cqblRalyvOecFVEZ4OdcxP7gUl128OXhtvlxry8FXOUn8jjfbtAE D43w== X-Gm-Message-State: AFqh2kq1wNNGOQKWLfrTA6qm4IEjZ8NzPhAf95GVb4zdYDF51ADSQaEr hc2Fz7EOkMpG8BzrG7Te93exVDojBHyxRBquwar0r7K4dVXLG6W+uRaSWVhSbkr+iwtsYTlDjAQ NaqfwKsMsjI8= X-Received: by 2002:a05:622a:124b:b0:3ab:7bb3:4707 with SMTP id z11-20020a05622a124b00b003ab7bb34707mr50094168qtx.64.1672850692362; Wed, 04 Jan 2023 08:44:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXtC6/5x1TZXjNxaTZni/mgmGgEGvHrxdB4Ldf1ggEJ59TT3GmI7MMZ8cyzI4+MP/hbyTOvkqA== X-Received: by 2002:a05:622a:124b:b0:3ab:7bb3:4707 with SMTP id z11-20020a05622a124b00b003ab7bb34707mr50094133qtx.64.1672850692030; Wed, 04 Jan 2023 08:44:52 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-39-70-52-228-144.dsl.bell.ca. [70.52.228.144]) by smtp.gmail.com with ESMTPSA id u22-20020a05620a455600b006fb112f512csm24300165qkp.74.2023.01.04.08.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 08:44:51 -0800 (PST) Date: Wed, 4 Jan 2023 11:44:49 -0500 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, Christoph Hellwig , David Hildenbrand , Michal Hocko , Nadav Amit , Matthew Wilcox , Vlastimil Babka , Rik van Riel , Will Deacon , Michael Ellerman , Palmer Dabbelt , Christian Borntraeger , Dave Hansen , Christian Brauner , Eric Dumazet , Andrew Morton Subject: Re: [PATCH] mm: remove zap_page_range and create zap_vma_pages Message-ID: References: <20230104002732.232573-1-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20230104002732.232573-1-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: A4FAC140015 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: waw7bdcnpf3zsuy8in9dkwhin6e5dek9 X-HE-Tag: 1672850694-523371 X-HE-Meta: U2FsdGVkX19SgZs+hWegDVusmOJyiC+/hsTVkHh9zubeaZEB28rdenpIMKVCU2G9OXIWVBHClAnZTDPO0RUsCFO2R/pDCmH1L/azH7LlIoeL9Ju6oXoEyCtxCQcqXkpwp4kEOdGI1TDv6ePhYEohkw5gMDzFotSSL+qXeg54XEonXLsZbkYx8796xzUtjfc+moIb774MgCwAhDD0A12i5ErQZsQAgC3SQOTkpqZcen8wAQq1d2pWmsLSB4Q4+tXPufvQhro06j6kkX3y0ua97YI9azyBh43ChNyOCiLtAygesm2U96mOiO32i9QPcewuqczAs095wjtIwxuGPdtcpInnYFJDB8aOic6STOlanzCCmEB6Xtqbg1M7LnDHLHmf5gi7VAAFjo07rGXmj4vctAD+Wi2gcSv/X+HGW+ddKPGaF7W9IBJTR26pmWBCeV1JBN0dVaaZKY9sW28ubaIDr2C+FkAdhtpTD/rHBGfAZtrognX9Y1jxzX+ICkLQM2hOz/lDPTIyb6g7Z6b/inRdwK/oAlzJU4Ux/qPqVpsXYVTuDOWUycnoQ7bhlhJEBF06yCR8cMU3K9Jfa8w4MOD02KzuMflFwT0dkLRDuvTYOksDgmpdnqLOTDU+CJCwObu1tR3qz2QMzditbWc4w11Tu8e+dkfkmWAdmGfDm807MWbbeH9amWpMjnO4K8iNGD8eQNrpnTO2hjBQLHMSiCcfjQZyYS0rqmzSqOcYmCuZNrBA9hf3jquxSERrzANYjjnEQVVB3P1RL8ku90IWJ1TmrFHv9LKA2z5eFXmSZRolIV58Yx9vndJCz8BDQSzlAljC4p2YY8mHj1kjU9HGCp5XKhwTw4JpcdhryfuyUZt3EmHCTAqd9Tx/EthSeeRxi8Lz6ghfGKONCIx34w3JKAS51srG3/sqBzjklNVykL7w9H1p1+Q7mUF3Kw2y8WPoqyQ4HBV27/81vwlaVVjpXhU nY1bcOL5 g6KQpM9o9Z/k4bkhGe3DF0b8K87DnpQksKqEwHxOWP3lZYcYVvJFG7vTz4zN4UFIZKV07iz1HgYRGuXsm7EkW+AKn+VT5k5TNiixxnyrsLBzvgRhmEnGXj4RGtgliSkVyxf2PV/SVoA7cOVQD6s0lnPxKmIPvy/94loRQipUH9oWxezAAtt/plwhN367x4Zw4eT9A+NRtQQ0Gsy75Un0KB1KEfys7AVfkQ8Tt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 03, 2023 at 04:27:32PM -0800, Mike Kravetz wrote: > zap_page_range was originally designed to unmap pages within an address > range that could span multiple vmas. While working on [1], it was > discovered that all callers of zap_page_range pass a range entirely within > a single vma. In addition, the mmu notification call within zap_page > range does not correctly handle ranges that span multiple vmas. When > crossing a vma boundary, a new mmu_notifier_range_init/end call pair > with the new vma should be made. > > Instead of fixing zap_page_range, do the following: > - Create a new routine zap_vma_pages() that will remove all pages within > the passed vma. Most users of zap_page_range pass the entire vma and > can use this new routine. > - For callers of zap_page_range not passing the entire vma, instead call > zap_page_range_single(). > - Remove zap_page_range. > > [1] https://lore.kernel.org/linux-mm/20221114235507.294320-2-mike.kravetz@oracle.com/ > Suggested-by: Peter Xu > Signed-off-by: Mike Kravetz Acked-by: Peter Xu -- Peter Xu