From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A750DC46467 for ; Wed, 4 Jan 2023 14:40:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AABB8E0003; Wed, 4 Jan 2023 09:40:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05B788E0001; Wed, 4 Jan 2023 09:40:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8C828E0003; Wed, 4 Jan 2023 09:40:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D6AFB8E0001 for ; Wed, 4 Jan 2023 09:40:28 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B095B1C6307 for ; Wed, 4 Jan 2023 14:40:28 +0000 (UTC) X-FDA: 80317377336.28.3E31A68 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 3D33F40018 for ; Wed, 4 Jan 2023 14:40:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ffTR+47X; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672843227; a=rsa-sha256; cv=none; b=EIbxyEGcr17hwWuuEDrZGLtzdmqEqkdhLCzaf9UXN1TuTqP7XSdQ4Att9c0u/cNjZjsm0J GPvxYBkhHSzk1ydvIV1Eo1D1PbrxXF58aa8FuhQxw1Do7is9somFuzb10wgpjKp/o9g5vA u2BnV07EH9L22pi++dGw7nagohdjnZw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ffTR+47X; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672843227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tl+X9g/RXdgA9M9RbC1T7PBcdBUoa0eZwHN8F9AnKE0=; b=PLZ8Q4loFI7KZTflKpWmixxykZpOaXCp/fFehSRxIJCEhQnLv/+kLJ/yShuv8Yp3f2K1Sc 2t6gWPweIZlwLFpeouaiBggOk5aeR41KMgFTtDsoIE9Hz5V0w6+D+Xry+RiyKQPRneukqy OY4psZ4OrEp0fgkGB6MHyecIrIY1Y5k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tl+X9g/RXdgA9M9RbC1T7PBcdBUoa0eZwHN8F9AnKE0=; b=ffTR+47XkzJtIBLKhbWc1Iexaw IPEi6QOyVh4W310g/oDbvPEUeGQv/U1wQwFwhMS3YDgxHbakoEJONtVqIK+wps1wX69uqNTMEamob TSxX4yu8eu+vrUZfDfPRRkQeUDZT+hGxcvyv8nRgu2VZ0KGYRICfLwmAGpYDlsAWCTa7YpeGksJeO Fp8P4CR3l2/wWu5/72KCxjUhfLRWnoZnfHCPTnif3nqKFp90bK0Auo/dWeHoSqF5RWldWps5gkANS 9621/Hjdv1lxkunF1OLbsk0Pf/jXor33JRTfnRjy4CHkMV2OVSTYCvCDfnjpH47NBz/5Hc89/zsXa 1/1KSBlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD4wM-00F7hD-Om; Wed, 04 Jan 2023 14:40:26 +0000 Date: Wed, 4 Jan 2023 14:40:26 +0000 From: Matthew Wilcox To: "Fabio M. De Francesco" Cc: Andrew Morton , Ira Weiny , Sebastian Andrzej Siewior , Alexander Potapenko , Bagas Sanjaya , Andrey Konovalov , Tony Luck , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: Remove a sentence from kmap_local_folio() kdocs Message-ID: References: <20230104121845.15770-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104121845.15770-1-fmdefrancesco@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3D33F40018 X-Stat-Signature: nmyg1885rm9bscx9txiybu6youd9zek3 X-HE-Tag: 1672843226-102881 X-HE-Meta: U2FsdGVkX187PzQQ7IX6lPN0+dEJcNPscOzxCDotssGR0AiVE1IWG94uATKiJ18iyMTyasLwlY8WEUXMekwHWBVXx55WKhO6RxlzAI4VFGo/Pk+otpyWZyH/+ZG9Q4qTZCgXpuNJSg1i9VkCQ1f4/xz/2xLIbokeH/1n1krCGUjh63orDwxO9mlsDtH7dPzmLISra+kvH1ulibL0WciBOjky1UXp4xG/HLpAiStPnWaOON2MBvHzpKK/K53me/5MIBCprqFV5xeVHTE1UCIO4b16FbHcN7Dv/hSanrfEved4+Fa4LV0Q7C3PKgBAQW0CvWz0PGUlK4+LHzBf3qawUGmwBQCgaZA9hT1TdtTUb+2qkmpvUMOvaWtfnNVC54fR9yvaZypXLVlNEiBPcumUsj/H2vMf2tKF1PGKqcwLiMxtv+MssgeB+CxwZs/dJn0pQTAIaLFRQPDnxD1Q+hVlmHT+YlSMBTBxzLWufipxKoXKZI17YHMdscLoMcC+r3hbBL0HIoWtl8ZxXcM5QljALXPdnMA46hyvK0xm6Ya0zD/aAIaxC0yOQCig07TTiJ1uaaPB0qyAfQUCUEOyiaEFEys0mak3FDvG6dYV89dxDnbMJMaMH73e9Uu5qks1DemPjhVsDi73Ktc9WY//pbGbLsAnoApcfYg2+Bq2iQuW0yNeLU7eXuPEZRR+PbfcAwFIjQc7/QF56h8T7FB43TR6JAtqInNO23M3ChLn03Ed70HST2HriS1J/QZihGJ60hRLHgiPDekASRCvfvPmtHl1Y1smkVRCJfMjQOAuD4DVaSFAdmA57BX4zV+bpNA5hrD3iuEzXsuqDPbgw0dPzSELOcAQVfyBo3GmJCF5Om20Fx+7IgBEC95QlN1H3HrQrEOADqMar6NhZDhmV1pLLeh8tA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 04, 2023 at 01:18:45PM +0100, Fabio M. De Francesco wrote: > In the kdocs of kmap_local_folio() there is a an ambiguous sentence > which suggests to use this API "only when really necessary". Looks like you removed it from kmap_local_page() docs in 72f1c55adf70 after I copied it in 53c36de0701f. That information should probably also be in this changelog. > * While it is significantly faster than kmap() for the higmem case it Also, s/higmem/highmem/ (both in the kmap_local_page() and kmap_local_folio() docs)