From: Matthew Wilcox <willy@infradead.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ira Weiny <ira.weiny@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Alexander Potapenko <glider@google.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Remove a sentence from kmap_local_folio() kdocs
Date: Wed, 4 Jan 2023 14:40:26 +0000 [thread overview]
Message-ID: <Y7WP2gyTRqTZWAQZ@casper.infradead.org> (raw)
In-Reply-To: <20230104121845.15770-1-fmdefrancesco@gmail.com>
On Wed, Jan 04, 2023 at 01:18:45PM +0100, Fabio M. De Francesco wrote:
> In the kdocs of kmap_local_folio() there is a an ambiguous sentence
> which suggests to use this API "only when really necessary".
Looks like you removed it from kmap_local_page() docs in 72f1c55adf70
after I copied it in 53c36de0701f. That information should probably
also be in this changelog.
> * While it is significantly faster than kmap() for the higmem case it
Also, s/higmem/highmem/ (both in the kmap_local_page() and
kmap_local_folio() docs)
next prev parent reply other threads:[~2023-01-04 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 12:18 Fabio M. De Francesco
2023-01-04 14:40 ` Matthew Wilcox [this message]
2023-01-05 12:17 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7WP2gyTRqTZWAQZ@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=fmdefrancesco@gmail.com \
--cc=glider@google.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox