From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D32C4332F for ; Wed, 4 Jan 2023 12:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F4908E0002; Wed, 4 Jan 2023 07:09:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 07D548E0001; Wed, 4 Jan 2023 07:09:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E14448E0002; Wed, 4 Jan 2023 07:09:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CDB3B8E0001 for ; Wed, 4 Jan 2023 07:09:46 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AB3E5C0AED for ; Wed, 4 Jan 2023 12:09:46 +0000 (UTC) X-FDA: 80316997572.20.3A0D4DF Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf25.hostedemail.com (Postfix) with ESMTP id 972A0A000D for ; Wed, 4 Jan 2023 12:09:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=WAY+yTiy; spf=pass (imf25.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672834184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RSYhdqTpMfykqc1ctl3BKtFuCm8inJnwJpeRspp9ONY=; b=JqBiMqBQJ0FyauGLMybLwaELtodpmeifBbK1Iq5iVib7d2Mj8s6pEKmZmDuQgXNIuaAbBS 8CiWL5cdoYo9XSzq3uk5D4HiuyI93DAPJoEN+3CAcU8oawY43NrH1TsTDhcQjSv+3QwXqs lhdTrbRQVhijiUQVZZ8a8DmrNb8hS/E= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=WAY+yTiy; spf=pass (imf25.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672834184; a=rsa-sha256; cv=none; b=25vTJJRBTreMTsmuW95YwiVJeL63yc3vgwej+YwnET8CoGBn40jgRQTLnQApjq+NBJa9AZ Xpm2ai3UHPgEtaelczF0DxSFS74ZJN+gXxCq60odYxHweasODhxGp45geLT+410EGNeLMO ghQISFz7w1YqT+GGBJJ9WN5RHnWeg/k= Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 304BUDcm025186; Wed, 4 Jan 2023 12:09:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=RSYhdqTpMfykqc1ctl3BKtFuCm8inJnwJpeRspp9ONY=; b=WAY+yTiyqrC0H8nHA99N8GOhbtvysVlsp+R2PZkxQv/54AlHHBRZHekzaTqR5be2E1R3 L7xZyLM/oqTgp/twEaYJRB4NOlfP99IN0XguZux5AXg3Ea5eHFhp7lbpy3qFJIBmejk9 XbeLvtPSeoLzRFRn4bkFUSzubVFJgswEPxVtKtqP0Vxx26IVfRTY3iIYisHWrxQhndP5 q16YnO97n04MLUE21A536mcKpY0iwXftD8Gy6h3KS5ZKPcpY0WCx/RfFglTBxkysQ5TQ iQPPjUcOuHnJhtyx4SFnoalJUzXWkIXwPfn3ZsDwv2P0Sjq6AKeVuS3FzR47u5HrlWUc /Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3mw8mp8su2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Jan 2023 12:09:26 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 304Bn1l4000794; Wed, 4 Jan 2023 12:09:25 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3mw8mp8stf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Jan 2023 12:09:25 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 303H2vOL028210; Wed, 4 Jan 2023 12:09:23 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma02fra.de.ibm.com (PPS) with ESMTPS id 3mtcq6uu67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Jan 2023 12:09:23 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 304C9JKt44171612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jan 2023 12:09:19 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 858F520049; Wed, 4 Jan 2023 12:09:19 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BEC312004E; Wed, 4 Jan 2023 12:09:17 +0000 (GMT) Received: from osiris (unknown [9.179.28.126]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 4 Jan 2023 12:09:17 +0000 (GMT) Date: Wed, 4 Jan 2023 13:09:16 +0100 From: Heiko Carstens To: Peter Zijlstra Cc: torvalds@linux-foundation.org, corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, Herbert Xu , davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org Subject: Re: [RFC][PATCH 07/12] percpu: Wire up cmpxchg128 Message-ID: References: <20221219153525.632521981@infradead.org> <20221219154119.286760562@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221219154119.286760562@infradead.org> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: v6Cdb3q06drLPDoMeGnxfYaUTPnm6fUF X-Proofpoint-GUID: VZjraPk3cBZ_DLGZSw4eYM75PJm0BhwW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-04_06,2023-01-04_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=683 mlxscore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301040102 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 972A0A000D X-Rspam-User: X-Stat-Signature: pd4dssxnnhjcf3ugy1m89aojtmwf5tek X-HE-Tag: 1672834184-108302 X-HE-Meta: U2FsdGVkX1+b6o2g64N9D4p1UCfOHl7xsLh0xTburr2bU3d9I/dEMYIc0EaXc5X6J9FwlSt6IW5QX3fcw0mkShl47MHouTsYod9sJTtNN8LOLN2CKcWU1M3BiX97oMgWVjq54F4wp83X2CtJAhFqRYcOeqqFPm71yc4PsuczsbCFJ84ItdHqr1OtFL1eL3jJV/+TcmwZPs04EAkxcPauawJ3BFzKjs/kJ78zFVCK0sJj8AEAqD6raCBeW7PeC8ehxCZl7c0OCcVE+1hJJn+AK5RZ/Rs2yZOEXivUWhVVnV0Cd1IogPiBOYwtBAMSoPF4d6ejDCAj4zqwoojo1NJ9suicMIooGZYEL6H3rr5kriJZqDFkVRff/gGZfj7WNpPEUYHcCAyoEkWxb4ufQIBsrHamfHxjmJREkc+dpFRIpGgQVi6cm772AkbxyWcM2TDRX4/uOhC13m5onY4Xbxp0RJkAlMjJB9f+wXx68vLufnoz+pfJk+qrSo9KLFWJSMcqPZlhO5Kt9EwG/OU3jNYwnOXWWgvxJM+BoEpQXnq6D3MjakkyD1Pn/bSzEOO9Q0ffK6+vq3U69AdpmIahW/YBgeASUpIDpKq9gJnORQO/17iQ0EHjzW5/tShf9J2iSw2Vgf+5MzydFH2yvm5Uf1X1Qkj5DRUAo9nLDT/n/mWuA9yZTOu3zd/awcyofTX1zDYEe+lYzPvWTM9WprmGYAIOjsW0V2eJkpgMgyIecp9lrSH1FA2osdkDnGH+VjlM8GuoqlGJFl7LjiJeLP6NdP/W7fOpa3WIa3Ap2plJPMNlTntkDMDMdqZZOUlIYSf6IMjX77uxj2RlWQMEu1ozVbt8Cvq2o36ogCtVhHZJpGN5Ke0e/PrMzuM+xv5DJCTtwGVjaGZwpMR50HRid2kXcRUeUCk5KqbChCCt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 04:35:32PM +0100, Peter Zijlstra wrote: > In order to replace cmpxchg_double() with the newly minted > cmpxchg128() family of functions, wire it up in this_cpu_cmpxchg(). > > Signed-off-by: Peter Zijlstra (Intel) ... > --- a/arch/s390/include/asm/percpu.h > +++ b/arch/s390/include/asm/percpu.h > +#define this_cpu_cmpxchg_16(pcp, oval, nval) \ > +({ \ > + u128 old__ = __pcpu_cast_128((nval), (nval)); \ > + u128 new__ = __pcpu_cast_128((oval), (oval)); \ spot the bug... please merge the below into this patch. diff --git a/arch/s390/include/asm/percpu.h b/arch/s390/include/asm/percpu.h index 24a4d9d644c0..d1997d01892a 100644 --- a/arch/s390/include/asm/percpu.h +++ b/arch/s390/include/asm/percpu.h @@ -156,8 +156,8 @@ #define this_cpu_cmpxchg_16(pcp, oval, nval) \ ({ \ - u128 old__ = __pcpu_cast_128((nval), (nval)); \ - u128 new__ = __pcpu_cast_128((oval), (oval)); \ + u128 old__ = __pcpu_cast_128((oval), (oval)); \ + u128 new__ = __pcpu_cast_128((nval), (nval)); \ typedef typeof(pcp) pcp_op_T__; \ pcp_op_T__ *ptr__; \ u128 ret__; \