From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24147C46467 for ; Wed, 4 Jan 2023 12:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 763098E0003; Wed, 4 Jan 2023 07:03:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 711928E0001; Wed, 4 Jan 2023 07:03:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53B10900002; Wed, 4 Jan 2023 07:03:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 394248E0003 for ; Wed, 4 Jan 2023 07:03:51 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0789E40C49 for ; Wed, 4 Jan 2023 12:03:51 +0000 (UTC) X-FDA: 80316982662.01.A11C8B2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 6BC5FC0010 for ; Wed, 4 Jan 2023 12:03:49 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ptJuLWEO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672833829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6m/JvLEc3c8Umhg4mQG7Qq1wD3dcrw04DOmWf9xMr9E=; b=lDSJriMao4XTIXkAxKgothAseS8pg2C9Dd1JpaQcBG5lkmTJ3J+ZgsJiRlCKBRDd8YfhIF 8KIx69417hsvSpYJGskVO5CxnU0PxIyhBkMpSzYpIheraeIBAlE6J8sokEG5vgsh2Gqzsj RTZx9ixgeNCLbEZEnVbzkm1BgvRi9mk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ptJuLWEO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672833829; a=rsa-sha256; cv=none; b=wGkh+O5uYNibCTxLhMGMTPp4ADixIz39SpaXsKRwnSucs/h8ItGsdisUVyoGTm1pnjKSwQ QRtMd7TAja7e7c+WHRpor6sLl0+Rj+P/wekHNAsrft1fUrHYE5znvHAcnvEy1dygqpA3oP 0OgLTNGnqnL10ext907SObPzhL0K10s= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C7B1614B9; Wed, 4 Jan 2023 12:03:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9AD8C433F0; Wed, 4 Jan 2023 12:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672833827; bh=dwb9nRq7i7xao4WnNre+ZkAiKphG8Sf61V8egDiQSkI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ptJuLWEO5+ZH8Z34rp3mWYaIa1E5FrsTjCXPoMDhzg1KPRLppvkrKzxe0XrcWTwQa d7Ljp7HsN3XNJ48fmiSkr5rXDCc3Wa/dMgg113HQfCAFwOoZVArXj9E8GpD3r1J9gz KCXF8XQXXf6XEALwBFRN2UHVyKdiWsxqewFk8moSfRzeIdVhc3WzWfrW3J6SFC8dbv oJiWX5hcVPWroD6DWOuqk4Uog9K2Bvgdr+DBbsgKfm3ToPuaHCMwpybaNF+pQ/jOZY 99N0vbCMHZfRWhjNqPM49+7zcQVDIMj+eMCL789Ct9HAC5yK3zVrmQxkHyE3LDsdzw s1QoWyK5lCPBg== Date: Wed, 4 Jan 2023 12:03:44 +0000 From: Jarkko Sakkinen To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, ashish.kalra@amd.com, harald@profian.com Subject: Re: [PATCH RFC v7 02/64] KVM: x86: Add KVM_CAP_UNMAPPED_PRIVATE_MEMORY Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-3-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221214194056.161492-3-michael.roth@amd.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6BC5FC0010 X-Stat-Signature: 7c5sozzrmjity18jio4ysuxbwkwiiux4 X-HE-Tag: 1672833829-759307 X-HE-Meta: U2FsdGVkX18ing2/0tXH4rktgCOvmIVb8WLEW/olzbCBXV5Sx/MtR3lvSHMQ8lHhHd/S1EMxYyatqjved0zYB9vaE1T6uP/Yhra017mb7sV9HirCuHxE/YSIReWTjqNGpOpPhJ/851Mrjb+Bj53ayfOsWHUU1ZuGCq5VIn4KXApNbteb6BIPM4wDbS7lgXJ3j8uNbiYxgQl4NnzMqtsJOGjqP9MRUekD3aN+Q9GKYyi7IkqvnwST2dAPvXeFuxnvvX74pr1+vha5Zmp4aZTPHM8FCBjyRDoiGEnjKiAUplsNov18yfqpkZX5nEUZqTkL6CyGZ2EtzuesCh+IbXDEzcC/bjHDlZCD8yPKbpsHLWxj4PVXXwowbv7S+ogzv5W/a0jOtrzESxlpkJFJavK2w7wc/3ZCi7usHzmzKuJWuCQeyTpbP1QJONHKJYIHNXWyM0hQfWNBtykUvJonImmExTJQJtxSYFzSMQhbzjKzxcqqpANuV63pBkXQ6LFVYg7vt5gA2dhtZRUDba6sCyLfnb80t9gEZM1r+33cp4r1Nzw7v6ONCX+nDcOhh6cAhf1XzJaPDW5++Ppjj3/kQt1MUT8IiAWEOIMpVOs+34LQ73nbGljsTwzl69/VvUFPLe1MdF1j1psaA/xTMwNNgq5iZ6R5MQHbl0MlNePRLiKwihfSlMthktrzsYQGdnnWGacTzX2pu10gLc08FSe9FpzLx2ClI0ukMAfVV6cW23QaGtO3/t4NfHHhbdJf2YrWDnXexVIaSkiZ9QY+qVzZ0DRL+SJYnJMsdNFVEmVPQPam+FHVmgDNxH7+S8+tgUPq8TWAsP5UvhO7VUDn8a/aiPwQgtERpqWDbv+8qyrgBdu01/KXlePPI8+oO2jwEmBQXiQdOlxYjHwu+ZWvPpkWlnFdWqdxAL+XR8oxQ+9pK/iEEUc+GgLx/dDgS1eq1PvgrCSWBdAffwPvqApOuGkh2iT wByVFhj7 2lvBSqvuPQ+VXIfN7Hqh2RXDVyXknjk3xDG9W3E1kcKHRDkX8njrvPj6/isOVf2hFqnLj87RgOBLn7wcH5aYNZm15FQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 01:39:54PM -0600, Michael Roth wrote: > This mainly indicates to KVM that it should expect all private guest > memory to be backed by private memslots. Ideally this would work > similarly for others archs, give or take a few additional flags, but > for now it's a simple boolean indicator for x86. > > Signed-off-by: Michael Roth > --- > arch/x86/include/asm/kvm_host.h | 3 +++ > arch/x86/kvm/x86.c | 10 ++++++++++ > include/uapi/linux/kvm.h | 1 + > 3 files changed, 14 insertions(+) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 27ef31133352..2b6244525107 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -1438,6 +1438,9 @@ struct kvm_arch { > */ > #define SPLIT_DESC_CACHE_MIN_NR_OBJECTS (SPTE_ENT_PER_PAGE + 1) > struct kvm_mmu_memory_cache split_desc_cache; > + > + /* Use/enforce unmapped private memory. */ > + bool upm_mode; > }; > > struct kvm_vm_stat { > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index c67e22f3e2ee..99ecf99bc4d2 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -4421,6 +4421,11 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > case KVM_CAP_EXIT_HYPERCALL: > r = KVM_EXIT_HYPERCALL_VALID_MASK; > break; > +#ifdef CONFIG_HAVE_KVM_MEMORY_ATTRIBUTES > + case KVM_CAP_UNMAPPED_PRIVATE_MEM: > + r = 1; > + break; > +#endif > case KVM_CAP_SET_GUEST_DEBUG2: > return KVM_GUESTDBG_VALID_MASK; > #ifdef CONFIG_KVM_XEN > @@ -6382,6 +6387,10 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > } > mutex_unlock(&kvm->lock); > break; > + case KVM_CAP_UNMAPPED_PRIVATE_MEM: > + kvm->arch.upm_mode = true; > + r = 0; > + break; > default: > r = -EINVAL; > break; > @@ -12128,6 +12137,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) > kvm->arch.default_tsc_khz = max_tsc_khz ? : tsc_khz; > kvm->arch.guest_can_read_msr_platform_info = true; > kvm->arch.enable_pmu = enable_pmu; > + kvm->arch.upm_mode = false; > > #if IS_ENABLED(CONFIG_HYPERV) > spin_lock_init(&kvm->arch.hv_root_tdp_lock); > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index c7e9d375a902..cc9424ccf9b2 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -1219,6 +1219,7 @@ struct kvm_ppc_resize_hpt { > #define KVM_CAP_DIRTY_LOG_RING_ACQ_REL 223 > #define KVM_CAP_S390_PROTECTED_ASYNC_DISABLE 224 > #define KVM_CAP_MEMORY_ATTRIBUTES 225 > +#define KVM_CAP_UNMAPPED_PRIVATE_MEM 240 > > #ifdef KVM_CAP_IRQ_ROUTING > > -- > 2.25.1 > Why we want to carry non-UPM support still? BR, Jarkko