From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6379BC4332F for ; Wed, 4 Jan 2023 10:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC4498E0003; Wed, 4 Jan 2023 05:33:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B74128E0001; Wed, 4 Jan 2023 05:33:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A156E8E0003; Wed, 4 Jan 2023 05:33:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8EA3D8E0001 for ; Wed, 4 Jan 2023 05:33:02 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6887D1C5B98 for ; Wed, 4 Jan 2023 10:33:02 +0000 (UTC) X-FDA: 80316753804.25.5F376F6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id E120EA000C for ; Wed, 4 Jan 2023 10:33:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q9sl2XkY; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672828381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nkJuPBtYaFwGayB+8rQQaZEPFLUcLkWx1aDaMJhaYE0=; b=o4JIt3Y00XPtFX4u18P0CXIMBsD5lsCUpbc/pGiRqbTXF7HtkWhsgJqZmVnZ8T8GgRc6bX PiiWK3xtzs81MRugXbzapCRe0C79WBj84UFad8N0YVoI5UT2I+yTXK2i4SEzOqk9azo88H Pghr7Cf48P4HH6horeNoSUqdtKBiQLc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q9sl2XkY; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672828381; a=rsa-sha256; cv=none; b=ItzZKoww+XTq/mlxIY00dJqXf9dDZsExc5Sg/vh7ah3M3bcSVOsIzqkEo1nuyzVgjEwn4y 5AvxuRh+/crUCDtS8mYBx3gLKbiptfyvrKPxsTbOm3HYXkfb9G7oQq9a3Ca9Uqm74jcihL 5P0gnKVy0xAO5tN22tGgR1RE0gvq+ys= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E8BF616A0; Wed, 4 Jan 2023 10:33:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68315C433D2; Wed, 4 Jan 2023 10:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672828379; bh=vF8eiH+zfyKEbLyTZZlwHaQeGAk1Dm/ULe7hm039cJk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q9sl2XkY5lsEtXSL383T5PFQGsqOeS+kdHqFL3K7rBpAjzktdfedZ1pR4QZyJDCZQ YroZZLjU2BlddB4YWS6bwaFPXjm7HTBAAKuyjktsIt6mXm3EbvK9/0tXS3hT3MOlSf cXRPCl1tkGv9T164rbjp63PoNWQHRrtyi4cJ4mlob4rqslW4eCPfofGwIMHoOJGnNi /l5hmeIuOQAXR9WxEar5SiAxsf7u6yM67yxuNohSqhH7mOTK+6enaSePGwlr0oHQgC ULd2e+UXfQddJ7zi/wrZ3vVs/iXB3IaPpA7yZ4+UdAvtIc85PygVYjXCNvC7+awqFl WmChIwE8/J71w== Date: Wed, 4 Jan 2023 12:32:47 +0200 From: Mike Rapoport To: Aaron Thompson Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock tests: Fix compilation error. Message-ID: References: <010101857c402765-96e2dbc6-b82b-47e2-a437-4834dbe0b96b-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <010101857c402765-96e2dbc6-b82b-47e2-a437-4834dbe0b96b-000000@us-west-2.amazonses.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E120EA000C X-Rspam-User: X-Stat-Signature: jmgr7fr66d5hickt7pz51crzs94xbyiy X-HE-Tag: 1672828380-601111 X-HE-Meta: U2FsdGVkX196mHb2yRSaANOEpxM2NOZ42iZF51Hb4320EBkOovJpzpqoOs4xbxTOnPWw84C/5gp7Rj2qYuahogea4aCWqn46s2CgAFMfxsoRX9v0QXM05AnQOMtGIBn+BM/2vegbKFz3MbIruldLDyDt3zgiiwmVB5lB93zi5hcZF/mTNBLPrpqHvOmR9CDYlfmeb/BvzD8yx8B4c/kB6kr3ILHC3kzNj9WLhOrCm6a8wVE0+GKlRjwacjm8hBMXwXM4/Ew+Ry9nH75faUx6wyrzYJqUN6y7dk17RHO7bUri6TJ1q7R/y1NXE2qaSNnTqgIRkY3sdg8zwUiVrZ6LUcmgSB3sPxl9Z5X3XbbyeZDMeRsnJfH2AnHhHjJEBKiTqSiH0gThDLD+tEtnDz1ic7zVOURKNYb3n9VNfKRnHKOHKKBJNKEWr5JMgwmyw89ibDgnpcB6fkPdOllTWvBQdB2Yn89obf5MM45cTe1Rjj3A6f5EY3kMeSyrlyGgD6WpHbst/fLkk06nTaIyFvix3pt3zJWvgvu7ap88J5AUhGXvR9mrVJTbe97euPKTH2JZWix5aQTMbMmeD21z8vCCp3yAa6c/fleaaHyqsHFlHxrEp/TfhFUx+pcWd6tsBUmd7Pw/a3IHJQQtSxbAy5MqSHtA5ORvGId4+bxSkVfIOe56D3FwK0TyPN2sGBaxy7GpGErUBor6RzUrck7LkgLNyxpCg5a2i4UzrShEGn+VAqxM6SGYc+PKyHm3p4pIlJtN2IpMdvzLt0Ow1xSvUM4Lk0jzZUOBV61rm6yheu8w3fBEufOUhb35k68+n/0wZSkFjG6VzHhp2Ad9lHeCj3t2LMiW/2v4d++YqaaDljY6FJgA/N9t+k2sLtk7tq3lX9z+FWw/Y8YVBDmms889Gm5jS63XqZrDT/xfClEaqx+dduBk+vTz/76oibA73IZdT2fYjxLewb1LXlcTR5I/zj3 SbLoTT3y LngN30OtqGZv/nYJcK7vh2EWSo2xcN6Zrpjjt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 04, 2023 at 10:07:37AM +0000, Aaron Thompson wrote: > Commit cf4694be2b2cf ("tools: Add atomic_test_and_set_bit()") changed > tools/arch/x86/include/asm/atomic.h to include , which causes > 'make -C tools/testing/memblock' to fail with: > > In file included from ../../include/asm/atomic.h:6, > from ../../include/linux/atomic.h:5, > from ./linux/mmzone.h:5, > from ../../include/linux/mm.h:5, > from ../../include/linux/pfn.h:5, > from ./linux/memory_hotplug.h:6, > from ./linux/init.h:7, > from ./linux/memblock.h:11, > from tests/common.h:8, > from tests/basic_api.h:5, > from main.c:2: > ../../include/asm/../../arch/x86/include/asm/atomic.h:11:10: fatal error: asm/asm.h: No such file or directory > 11 | #include > | ^~~~~~~~~~~ > > Create a symlink to asm/asm.h in the same manner as the existing one to > asm/cmpxchg.h. > > Signed-off-by: Aaron Thompson Applied, thanks! > --- > tools/testing/memblock/.gitignore | 1 + > tools/testing/memblock/Makefile | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/memblock/.gitignore b/tools/testing/memblock/.gitignore > index 654338e0be52..4cc7cd5aac2b 100644 > --- a/tools/testing/memblock/.gitignore > +++ b/tools/testing/memblock/.gitignore > @@ -1,4 +1,5 @@ > main > memblock.c > linux/memblock.h > +asm/asm.h > asm/cmpxchg.h > diff --git a/tools/testing/memblock/Makefile b/tools/testing/memblock/Makefile > index 2310ac4d080e..7a1ca694a982 100644 > --- a/tools/testing/memblock/Makefile > +++ b/tools/testing/memblock/Makefile > @@ -29,13 +29,14 @@ include: ../../../include/linux/memblock.h ../../include/linux/*.h \ > > @mkdir -p linux > test -L linux/memblock.h || ln -s ../../../../include/linux/memblock.h linux/memblock.h > + test -L asm/asm.h || ln -s ../../../arch/x86/include/asm/asm.h asm/asm.h > test -L asm/cmpxchg.h || ln -s ../../../arch/x86/include/asm/cmpxchg.h asm/cmpxchg.h > > memblock.c: $(EXTR_SRC) > test -L memblock.c || ln -s $(EXTR_SRC) memblock.c > > clean: > - $(RM) $(TARGETS) $(OFILES) linux/memblock.h memblock.c asm/cmpxchg.h > + $(RM) $(TARGETS) $(OFILES) linux/memblock.h memblock.c asm/asm.h asm/cmpxchg.h > > help: > @echo 'Memblock simulator' > -- > 2.30.2 > -- Sincerely yours, Mike.