From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03AA1C46467 for ; Wed, 4 Jan 2023 10:24:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53CF98E0002; Wed, 4 Jan 2023 05:24:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C3948E0001; Wed, 4 Jan 2023 05:24:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38CA28E0002; Wed, 4 Jan 2023 05:24:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2606F8E0001 for ; Wed, 4 Jan 2023 05:24:50 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C898BAAD69 for ; Wed, 4 Jan 2023 10:24:49 +0000 (UTC) X-FDA: 80316733098.20.42AA6B7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 3D8C040002 for ; Wed, 4 Jan 2023 10:24:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lgVGP5VV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672827888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F6MObiraG1jfV9VKGgetp45GNwEk8yUfWo1bOcBxoGo=; b=Hb18H8heRp366x/nvf1zOB8OzWV5upzuge6/d6JXpvpNx4kG/aB9Pe3Z5GHZaJz/q7vc/c OvsciFa+silAX5sExQkJEmULFVOiXCojWjxRz+osvSOhqpjucatQgr3eRutH1cJgud5MZg KDrfJMEXHjjdQ5fVgr4sA4UyGszsvTY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lgVGP5VV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672827888; a=rsa-sha256; cv=none; b=43E40BsBssUZcvNuanbuUv9GNcqigBXXzBvgwc5Mry4YdFDBPUdBz2lj1H1bg656EQ+LyN a7FJ0FD4CfwMxtmaTz7xc2qtUBFwQ8jTxTQZTmw1qfaI/Ai1M7TQ/I8oNhuJDAdla2+Y9s +knpIEDJivdlX2A1UcjDPfDMozuhw1k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D8B061637; Wed, 4 Jan 2023 10:24:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31511C433EF; Wed, 4 Jan 2023 10:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672827886; bh=YJDznZgeh+BEyxpBFvqDWK88sgorfwfW6T+7n5G8kBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lgVGP5VVq0BrTBujIIWDYrh7WrFCLSxLy5waJh/0bBcp5l+kzsA6nWg4S2HxA4HeC YVdIEqt2xlij1Cjr3kBA7ehjmrNQsYSOtHz9m9GHdYtCDz+eXm0TmqhnNglyOQLq7c xxVcOXghk5cQlUk1akUMA+uf6y53euoquLn1xVbz8Tit+zEq6XvRV+WxwJtjHmJVmi R68APvlnk4Wn7xgAdZb8tHCQA/NBPC4KQpT0DRz4uL+vny2B7Yz79pXk6FVoV1R0qz albb58E8tcADOMab4FANw7CsHsKm+Vq67aCfROpBiPxgHfd4TC6BsLAG3BC447ILmK GR0gWL1KKtAJQ== Date: Wed, 4 Jan 2023 12:24:34 +0200 From: Mike Rapoport To: Levi Yun Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [PATCH] memblock: Fix return sizeless candidate on __memblock_find_range_top_down. Message-ID: References: <20230104095049.59043-1-ppbuk5246@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104095049.59043-1-ppbuk5246@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3D8C040002 X-Stat-Signature: pcwsfct5ezkde7waxt1tzc38a8zwcrak X-HE-Tag: 1672827888-527386 X-HE-Meta: U2FsdGVkX19bCV5R9My1oDRvFk9/pKvrCoEyBQcd+2qvU5qI2gFXv/3fnXXCZEwPMGm93RscyKCYtsP4NGj3jF263EvSjUxjWZrKovQ9JsjQh/2Kp7hYjsIkr3GK7n0OtoVlDgqTJ7sH4uaYQ4ly1AjAzOmmo1fxjqS3m5kXg4vPjf+Zuy5oE5/vgW4bv/HstPq/ypBMZ29Z14lLKyUVAJFNHOItKTj5j1UTM2COfadUDjos8MCiude0NqOg1tMWGCVUtnJNQOVcuSoKRIPl55SQV3/9lbnbF8Lj+zF2/u/TkHZKTkokL9pQif0BjjAsqVn83Jf9H9YJVbTci3W59KX8sCdYA9vFt4jCcElozXg0wglmpmtXOMNvk8+D5qKfek6UW446d5kxJ+JqxH053wLWRaqhEEuJzgABeip4C5RHroHI8roH7LXK6nqtXGO2D40rOsfsTgGfcU+HwcK2fB+94S47Gh+SznQ0sP+5m4vKjkMZAHlvTd8J9UHvf10S91ALdEVQx75ikqI/hRPBmJTg+VH++Ni/4i6NJpERLtVeNtJqgREXKx/ZfZP0VL3dqz2xRmw3bZQe4zFc3OuIuYyUBu9LtdRqXB8VunNBgp7ZwYIdjUJbDzeVsG1gh2BXT8nYkhZZbHMY/LiAUbGPO8CgFzQr/e+KbFmRb+bXvN+ibd42wAxZ2TipirtDDylh7C3zdjtgyHvPjL+fKgRXlVO8uTLyVikHwKIbmnXn0GXTJ5URr5KDCsQliPhv32EF1JOKWCaxUk6cJS05fbuc7SbWvbrvCsAPhlwmnc6y+O0X6EySU+URlha1Uc5H5XwSY7zeQpnd4+V9kxK0KcR7/Ns171A0kuPCJUu9BwgW2KP9IwU+AZU6pogDU7g8nj36OipZ1koJ60Adqg/xIDGRyabVMvcpfDLckQc3jg4QTisg2KO3lTAgFQTkRVc0wqqVSZMBEJ3CVzCE7ve2kEu izRcXDpO Jk+ga0ceV/IDkvH6TV0rBx3k7hirHIniL2TI78I7zXZoaViLRq02PEuTG+D/E3SWUcZfy8SX2ItS8GkI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 04, 2023 at 06:50:49PM +0900, Levi Yun wrote: > __memblock_find_range_top_down can return start address of free region > which sizeless then user speicified. > To prevent the above case, add size check on candidate free region. Did you see an actual issue or it's solely based on code inspection? > Signed-off-by: Levi Yun > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 511d4783dcf1..710e2ef8d67d 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -262,7 +262,7 @@ __memblock_find_range_top_down(phys_addr_t start, phys_addr_t end, > continue; > > cand = round_down(this_end - size, align); > - if (cand >= this_start) > + if (cand >= this_start && this_end - cand >= size) > return cand; > } > > -- > 2.35.1 > -- Sincerely yours, Mike.