From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFBF1C3DA7D for ; Tue, 3 Jan 2023 21:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 574F18E0002; Tue, 3 Jan 2023 16:00:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 523EB8E0001; Tue, 3 Jan 2023 16:00:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 412478E0002; Tue, 3 Jan 2023 16:00:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 34D518E0001 for ; Tue, 3 Jan 2023 16:00:11 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0DF77AAFE8 for ; Tue, 3 Jan 2023 21:00:11 +0000 (UTC) X-FDA: 80314705422.26.52582C8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 7085620012 for ; Tue, 3 Jan 2023 21:00:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=U5Yd3TP8; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672779609; a=rsa-sha256; cv=none; b=d9QPJuY4ikHA0V+ck9oI/nZsXB4FazY7QafTxfUCK5VlvuAKsiuFc5ljEjeeWTivMWU85F s4DYtTK++ufRKkRPi1ENelUmmIwVAzkGIkZg/7WxK6m+FFjrh4EQzaF4OUmiKLyws3iZD1 o/o4EEujD7mh39Uo/gfQueIiWFpo0ZA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=U5Yd3TP8; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672779609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lQIrLUPIl+i/y2McQ1KqovnwZ37cPRNSnM0HrSIfVis=; b=pGRC4UTcvoFQqcMa20Ok1ybqs1VJ9Dl8g+MK9XtVkJUI89WNwbx1oMmwWQ8y7cWoLZ1GFX ZIrwFK7YScIcLGQ+T+nuAuKcQRGO91QPLihlDdogP38ay/jk123T2d5rjvutcQln5p49pp fPKFVtEzQcD+UW74rhoGvzbN+ClAxso= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lQIrLUPIl+i/y2McQ1KqovnwZ37cPRNSnM0HrSIfVis=; b=U5Yd3TP8tnDWS6O60ptT4qa7jt RBmNen4FN/NtclUgVvGiIGuxpwRXoVrRtBWIXk6Kz+9PnIBEq/LjhjQCR8WNFd05sR8P0kE++2lnC +OMZS9ptA/MakBJ+CgZs0v9O7oIeHFgdXDuqUFU8UPxnPpE2ZmOKeuSc474x00KOj4b4refXOIYqr 3p0RLQjw/wztNADrYv+gAl3+1fcOK0cBniioz1Ab/Kj+P5pXzb0R1Kdv3396Q60d0+/J9e4y7wa9u WaYNRmJRiQ2Ax9rLQpRQfmWshtiUFfLrqePpUupI3yrrEjIg6iB8DUXiiARn9hMRnTxyxIZp66CLB ElF5w8WQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCoOK-00EPEc-NI; Tue, 03 Jan 2023 21:00:12 +0000 Date: Tue, 3 Jan 2023 21:00:12 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, tsahu@linux.ibm.com, jhubbard@nvidia.com Subject: Re: [PATCH mm-unstable 3/8] mm/hugetlb: convert dequeue_hugetlb_page_node functions to folios Message-ID: References: <20230103191340.116536-1-sidhartha.kumar@oracle.com> <20230103191340.116536-4-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103191340.116536-4-sidhartha.kumar@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7085620012 X-Stat-Signature: 614z5fduufu7wtn6dxj4xy4a7kikhkr3 X-HE-Tag: 1672779609-897710 X-HE-Meta: U2FsdGVkX1+p/m/vDl8cIm58VCG/NULgiZxxASRiz26KFg3p37e7EGrKB79oA+8waA+9XaIZs842uefrkLgoGqEDDcTzNQz/Ehjd6xxXyOAWrYgJYHnIfbfHmTx7FoTUT9hqiRPJWqRvPx4+5dp1sO458KxXgyeDLWKhN3q4aV0j2TFFyUayCbgVGHcei7dLvtxM9g+7jwxMdGFyA0zvb1hlBEU7Lov34j8GHUip6/C5R6uWCeQrX/zMGUN3fxA7DlLCGCv0Zng304sj3Q0Wt0rESD29jVFMlDUu5zhvZ2T8LVMiy14Jp4arHGv91jNzlKYsd8p35NA/lmR+/lpU8xGMNhNbzD4R0lgKra4sac+Sa7qpJxFKcQ5hb9qiFb/mlkc31RcKe3Gnm1WOkUrLk8MBS24RhaGSKO/nAicoa8V8WZqZ4KITnRVlQSB6k4/64x3K1WxVMNA8gBQuZjw0H1F0j8NZ2TjC5kXYAApU7YfbHFGSmP2dyl2Rd+gY+T1DOIm1B/9mfhDCszr8+tbWAoA9jjRDJ77gGD4Qq16i+v3klBXbIEmeHEeUv/z/AIyAC+Do/ps3MLjY9irpL81745z/BEc/fbilZ+e+90enLkjFAErp7A+EFC9jjrkHJTuw8+YsjYCPmxA9G4wZcr6v1s5ebu2TRuJSy0zZ4nFL89KGlUgF5h6/kcw1CmsaVuRcuYmn3S+zAe10LT1kkI7da5sp3vFmFskp9lJoYi9mRhNuK1Sd3fcJ5JIyy1wq1qMSTe6D2QpBNYI0JrZ6JKuaS+LXC/zXUYQVPIvIYL1DxNpw6Xj6UnIkI+uxTLEj61dyTX30fx7WxJJ42IwSG0URyo3q9LzszVP8kLeEfGyPH+ZjN/bhxMl0dJaJelR3JEXbx0aGRtG8/XeZ4kZfrN7jMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 03, 2023 at 01:13:35PM -0600, Sidhartha Kumar wrote: > +static struct folio *dequeue_hugetlb_folio_node_exact(struct hstate *h, > + int nid) > { > struct page *page; > + struct folio *folio; > bool pin = !!(current->flags & PF_MEMALLOC_PIN); > > lockdep_assert_held(&hugetlb_lock); > list_for_each_entry(page, &h->hugepage_freelists[nid], lru) { > - if (pin && !is_longterm_pinnable_page(page)) > + folio = page_folio(page); I'd argue that you can pull folios directly off the hugepage_freelists. Since they're attached through the 'lru', you know they're not tail pages, because lru.prev aliases with compound_head. The rest looks good.