From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C06C5479D for ; Tue, 3 Jan 2023 20:56:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21A908E0002; Tue, 3 Jan 2023 15:56:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CB3F8E0001; Tue, 3 Jan 2023 15:56:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BA668E0002; Tue, 3 Jan 2023 15:56:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ECFDD8E0001 for ; Tue, 3 Jan 2023 15:56:50 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BDB4516066B for ; Tue, 3 Jan 2023 20:56:50 +0000 (UTC) X-FDA: 80314696980.27.44E7706 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id A517A140015 for ; Tue, 3 Jan 2023 20:56:48 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=u6TSBbld; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672779409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UE4pFETTCLCzR95QKSBJ3qT45YjNJI4csCeU5tD4KaQ=; b=bw2QCQc806+VcBE5wCyQJudlt08Zj2AJecOGnugMv6dQ3PISOs8WYTBkLxxrOsQWxfuEHN WcwxI8or5uZomE0vJODeie2dia1KmwSidyV5JC17OYRFqapO5RODhn450BMdCSiQv1IhYa XEfTFTfx9YV1FFPIZaK7ZCWVqXbu50Y= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=u6TSBbld; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672779409; a=rsa-sha256; cv=none; b=quountKwbZLQyd7Ycd40+UxYBtEe7rq3o+/ebRraxgxhQv/1DxHvio+oobU3o/5AnvBHvz DyHk5QDt3EGZ8m+lcdV4rxDF2BytgzV4+ha3Oti0WOFmxKuSih69zBrHwAdZK8eUxPMpsn Bsqv4VdEp6dNqjDIv+/HJj+53yYJ0g8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UE4pFETTCLCzR95QKSBJ3qT45YjNJI4csCeU5tD4KaQ=; b=u6TSBbldGd41Xz/Vk18GdgWB9c KaVf8X0givCS+fAja7O6AhPir7fXdlqrFxnNpRACQZVT1ffR4SKowzRat7d6LuIXJjxfaJlX5ZlqD U33fcLY0HCslISlwcSrRx3brql1Ul1r0Pj/yO85oovODlE8nw52Xz9TCZkBbJLDutWWX22Dbm4PO7 0fteLjWEHVZepqyxrzhDXevgpu5LCTarJkqKM7LkQdaYNx896BHVZsnA8z4h0Idqq+uxBy8VurDvW n3Zz/ks0sspuqzNMHb4YizowAHvnqeJNoRfN90s928uN4TzSRkHJ3tazHojmFSmeZDAsc0bSh/Qwv UpcQ8UFw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCoL5-00EP9P-Vf; Tue, 03 Jan 2023 20:56:52 +0000 Date: Tue, 3 Jan 2023 20:56:51 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, tsahu@linux.ibm.com, jhubbard@nvidia.com Subject: Re: [PATCH mm-unstable 1/8] mm/hugetlb: convert isolate_hugetlb to folios Message-ID: References: <20230103191340.116536-1-sidhartha.kumar@oracle.com> <20230103191340.116536-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103191340.116536-2-sidhartha.kumar@oracle.com> X-Stat-Signature: r8ecf5m4g9gfk7wp44yxzt9pic8niqxy X-Rspam-User: X-Rspamd-Queue-Id: A517A140015 X-Rspamd-Server: rspam06 X-HE-Tag: 1672779408-278405 X-HE-Meta: U2FsdGVkX1+0cITfb4Em95z4Su3IMlPN9QVr4We03gOpJH/EnTciapJxP0aGNCRz14YVuoCeD9aKCosRF3ye+VBQHq7ope4apzHMJLYvIfZoEDwTGGRmjYX1OW2XZ1LwZhTNuI6MrXOP1jEQMZn5+QiBbim/7CXFRYdrP6supnAjYt4XUmcwLf+9XnbFLKA1y/vgqzfHD+WLZiBonZbb3lFfXa5f3VXCHCWffZh2Nfma46lx5M2YzyEZKcOfS/062QnLc09HKH6ic8p3M6y7UxbJmIZ3iuIjZvKRwQv1Vcrc6kW2nM/Aq/IYDB7uRyWYUGqqcYqR4z0cVacFCv7VUyB/veaJVaZ6s/qNBd10OFaKTgKJFt83AUqXKKCU1RyAru5GK6mybCvuhiFGT8eeyZkbcciG/g0Q4x/ZNy+O5aHKvdYy/A7W2KzpKB7yo4rmee4xxY1mJmggPzuZBh8+Kb37rvde1hpdgebIqqNwxWKyOaeASSR9N6ejkDNi+FvEiP8K25tfYfc33vMMcpkrtFWcUNIbTuI8GiL7vVX1d89XPoU7GE25qQ0XRek6etW7sfZ2n7hcRUq0wMgpisyZIOANoUE/qF2a8bthztXPY4gLds4xyN/kAbznKA/LbnWFZ3RE2PEun0/jH0EFh1JNwG2r2vMe5L3YuFC4v3hI8P6MoGU61jKw1BQAbt+lm9nr9D1ZyfNQu9wfX4VMylfj6fdoWqngn7yheilOclbsPlGfn8RLBL8b/K7NqAaqW1/Ja7VF3QObaCPqmanacAjj8cqoX4BTynWqV+eETOwiPTsUnrnlU6n7WxUFgYEeNQWuZ7w4rV6DDzRcnxHS8u1qsXcbaP+KWtCHbkXEwdUol4VY/i5B9RvS8o1TwMDmmzzAby1ddIaU0sQDbPm1fativA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 03, 2023 at 01:13:33PM -0600, Sidhartha Kumar wrote: > +++ b/include/linux/mm.h > @@ -775,6 +775,11 @@ static inline bool get_page_unless_zero(struct page *page) > return page_ref_add_unless(page, 1, 0); > } > > +static inline bool get_folio_unless_zero(struct folio *folio) > +{ > + return folio_ref_add_unless(folio, 1, 0); > +} > + I think that's folio_try_get() in linux/page_ref.h. The rest looks good though.