From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E56AC46467 for ; Tue, 3 Jan 2023 17:06:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A43808E0002; Tue, 3 Jan 2023 12:06:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CC938E0001; Tue, 3 Jan 2023 12:06:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86CCD8E0002; Tue, 3 Jan 2023 12:06:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 73CFC8E0001 for ; Tue, 3 Jan 2023 12:06:27 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 48C9F40ADC for ; Tue, 3 Jan 2023 17:06:27 +0000 (UTC) X-FDA: 80314116414.07.D00FFDE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 1AE634001B for ; Tue, 3 Jan 2023 17:06:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OKWEP09r; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672765585; a=rsa-sha256; cv=none; b=o1+xJWeiVCPcoW0Rn1BsT9+tsFImZXebFfJ0z8PC0ayw+VPrPC1o+yLhoyifLrX8dp/+Cq hBr6aC318akVhQgABx8wKYb4gM+kk2U5dCJhyq0sM9OIVz085fBhk/4btQeHUpcIEQ7RYY 8UZMH4QQhQKiJAzu3P6iBCNSr4blOJM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OKWEP09r; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672765585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6BRBNvzQCbi1RenvRCJJP9+zcFTdMvF+Yz2UJ3A+ymw=; b=JZKi1Duhe2tu2+Rji/UcLCB3kusqGMLKNYHu1mv5KbhNWvu5y6sm73ec5H9osKyD+H+5DW 8wLGcWSB9Sv7N3P9oMuv/bwXHMO9mVUP+FdQcCI138d0vn9Cu1pM67ysnu0apgwH5YTA95 DDNtTl0VsG20fu+iI9cRSQekjriqscU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672765584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6BRBNvzQCbi1RenvRCJJP9+zcFTdMvF+Yz2UJ3A+ymw=; b=OKWEP09r37lTHsrs93EGNv+ww2JDb1CtwUyTp6efGt13L1h9YAEJJfRIPTaeYgYblt9c5V aJvXzBBAJEas4HcQmnvvj7mjWX+JGFVM8WOSS8pjAj84kWlK/l61kkRTjaomJCiiC+ABls MbNQRfW409Kl80nz7/o8vmqJ5xgbey4= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-442-PUq5b-wBPu-dfGDQuNzCWg-1; Tue, 03 Jan 2023 12:06:23 -0500 X-MC-Unique: PUq5b-wBPu-dfGDQuNzCWg-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-4ad7a1bd6f4so33107337b3.21 for ; Tue, 03 Jan 2023 09:06:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6BRBNvzQCbi1RenvRCJJP9+zcFTdMvF+Yz2UJ3A+ymw=; b=nMYrj4u7XP1abG7g2zWIO+STPD6x42nnCeM5Ea8Bq36UX3VrGa8P9mqX/z/WXiHpS0 kLlCD0EpknwZPKDpUv2LrpVvTfh19FypD52tr0+Oyz2PqWuYuK6q3jKRNGFvHDqCAzQr tOCxYjFGtpK5zloApi092Do7uExoQSZAmhh3uAJ4rJX9ukaek0rlul0c9iYMS6xFoFW4 156Jp9dYQ2oxDvhGxUSVYWh6Js0DBUPZkzRv2SxEGpVaZ68jEeZYDX7TkQ5YvgdCorwj 4tg80g4HMNle28avUWESpnToGXXzNGD/UnDDZWsI/7MVH8YE2TrubZlVxcdrTskRdoVZ j4Jw== X-Gm-Message-State: AFqh2krTdUFl0C0XxSuFTtP3QIE08v9S/f7p2GGWyKwMXumyEQTrL3uC nkJanmJG1QUoAOIa3aM/uzBvqndwPB3eh3kBjBeJNCW+ID/MImthuZoV8AOvEg7ckqlQq32Lw6p UfaBz1WpYiMM= X-Received: by 2002:a05:7508:668b:b0:48:f620:2c6a with SMTP id dt11-20020a057508668b00b00048f6202c6amr1639413gbb.9.1672765582560; Tue, 03 Jan 2023 09:06:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXt523hnmHSsOU3XGi7N2xoeMR1V8T+JUVSBn+QqfnYY9uocBsZpKDL4orUEbrjuNgR1+K0dYA== X-Received: by 2002:a05:7508:668b:b0:48:f620:2c6a with SMTP id dt11-20020a057508668b00b00048f6202c6amr1639373gbb.9.1672765582158; Tue, 03 Jan 2023 09:06:22 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-39-70-52-228-144.dsl.bell.ca. [70.52.228.144]) by smtp.gmail.com with ESMTPSA id s2-20020a05620a29c200b006eef13ef4c8sm22809203qkp.94.2023.01.03.09.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 09:06:21 -0800 (PST) Date: Tue, 3 Jan 2023 12:06:19 -0500 From: Peter Xu To: James Houghton Cc: Mike Kravetz , Muchun Song , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 33/47] userfaultfd: add UFFD_FEATURE_MINOR_HUGETLBFS_HGM Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1AE634001B X-Stat-Signature: tgnb9zrb3je6194ig3okq1ya8xeyercw X-HE-Tag: 1672765584-362545 X-HE-Meta: U2FsdGVkX19CN8zihfIq+Q/iIhnMl+zRGY5GxMv7O68cqjDSjf85wiTNWaPk+wB5LUJLAKicqQtks9ZPCUJXbnQ88ICzehIDRNxYcvLySO1ryOE8gKeG/eiCR4Xs+Ij0dPcT61v1VGIlZcE1e07vO0krhU5SpzL3iMU+vyEO3l6bthGHFVIlcRj+Q8i3uzyuUYfV4k202ITH7qK7XDw60B5ECPH/05JyB+zBeWWtvdrtONlwJAKohQav0CkkJDqsNofZAHNEQkHia75mS/4ewI6v8dh76i8rY+IC7lEsc4pQ2ay1Y8bJLoYZYLwiRG1b3/lxK8+T4H0r/nYX0bPNtV81xAn3DB6fRECNdGEunygWIVjsspMMQiivGEI1exbW3TW5JtuBIDUYIRhbTYnaj09KhxnTCw4RGRWhfiUIbN21e6O/QUkBAxoH0/nYiH/appnN/E4IigpLPSiBqdQjUa9BEF0zzjP6hc2S5G1RcWG7QXUmZXHY+5h/RM8Qpcaxxkna261uOw0dbjZWeY7vhjTVlGW5N7NdG7p1TujQ3MnJE40gcTXExqfe4v99X81OGPLCjcHD+dJBJRgbfmqlOgPZG2pMLYgO/cpK3oT/u89b+lU/XvdM4rzLr0RtoVjCBSizATvIZnALHYAdLomBu/J1VMdrD9HaIhV4FmQG4iqEkAt21U61lK4gLqY337f62yWfgBYzEnBGkIc/lO/yugNyyYQcHGSlaj2IS837hcCQuGNtnIFQ4mniu4VoX+CY93sJggv3taq6YE9Ssfx+M/Zji2xJmVmJ5fwvaZPG/W62NWbUQC749EZW9OF8NvCvUMy0IP2Kkp4mukihlenbMKxVf8Aih8LgSovm/aHqwCq45wAustFxa486qVngYWEdmVOlcCpSfmEzdoDIcW9FvJbjLc4po/EivAG2A9v/K9yYurnOV9LTX0gtyJMbESYrYnmFXJ77MZJ0BzjgjkK v2R5PWrp 0CrAF3Bj6pL9gk5gGw4b3DP23osxtMGkAF/YyoTqJtiRjkXjTf246mRAZWWGmYNL+pdHTm2tvSw7QT2PSwuHyJu5vE2w24QAr04V9SDj/KeBdKHCR8oVJDSMUHzPFteVB6T6pKktbXZv2NM2sP9IlkzgoPmoWe9n3INkO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 27, 2022 at 12:02:52PM -0500, James Houghton wrote: > On Thu, Dec 22, 2022 at 9:30 AM Peter Xu wrote: > > > > On Wed, Dec 21, 2022 at 08:24:45PM -0500, James Houghton wrote: > > > Not sure what the best name for this flag is either. MADV_ENABLE_HGM > > > sounds ok. MADV_HUGETLB_HGM or MADV_HUGETLB_SMALL_PAGES could work > > > too. No need to figure it out now. > > > > One more option to consider is MADV_SPLIT (hopefully to be more generic). > > > > We already decided to reuse thp MADV_COLLAPSE, we can also introduce > > MADV_SPLIT and leave thp for later if it can be anything helpful (I > > remember we used to discuss this for thp split). > > > > For hugetlb one SPLIT should enable hgm advise bit on the vma forever. > > MADV_SPLIT sounds okay to me -- we'll see how it turns out when I send > v1. However, there's an interesting API question regarding what > address userfaultfd provides. We previously required > UFFD_FEATURE_EXACT_ADDRESS when you specified > UFFD_FEATURE_MINOR_HUGETLBFS_HGM so that there was no ambiguity. Now, > we can do: > > 1. When MADV_SPLIT is given, userfaultfd will now round addresses to > PAGE_SIZE instead of huge_page_size(hstate), and > UFFD_FEATURE_EXACT_ADDRESS is not needed. > 2. Don't change anything. A user must know to provide > UFFD_FEATURE_EXACT_ADDRESS to get the real address, otherwise they get > an (unusable) hugepage-aligned address. > > I think #1 sounds fine; let me know if you disagree. Sounds good to me, thanks! -- Peter Xu