From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA5AC46467 for ; Tue, 3 Jan 2023 08:03:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34C3E8E0002; Tue, 3 Jan 2023 03:03:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FCDD8E0001; Tue, 3 Jan 2023 03:03:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EB428E0002; Tue, 3 Jan 2023 03:03:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 136D08E0001 for ; Tue, 3 Jan 2023 03:03:38 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E09AB8031C for ; Tue, 3 Jan 2023 08:03:37 +0000 (UTC) X-FDA: 80312748474.19.4DDC651 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf05.hostedemail.com (Postfix) with ESMTP id 36BFA100018 for ; Tue, 3 Jan 2023 08:03:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=A6ezqKSa; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672733016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Ulj1KdXgOhz3mFb7YsOBfrLohsk+mOcfQTC8VIBIyY=; b=uItGUseYr1E2jSDTMtv+4ZoqnGRw6BhyYbkIrFlDoYbRKkI8fie74kdYg1zU4beJZS/CmJ bpl1yDNOF+XsqV2jQqglKKdX0m0B8s6mWzItkDG0ptVXjEW+MeYF9WRpJiXA1/5K+ltsj+ 4AIIzx0M2gR9O/AfoLlWQPZ67hUZJxg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=A6ezqKSa; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672733016; a=rsa-sha256; cv=none; b=Nn4PnGaEzpqeylDHD62dtJepNff5dlx0S1YX5qYtLl+Zcbze5gCuPAWwabgNKAzmKCyEpT NsGjrrCGDpf3OrcpD8uJTs5Oa1Liy7dZZmqKKBuT0UKTqjiqCQP+hmyvyOg2EiVFbGCnAI yEBwmcXtsTpVvg/QW2w7kpvQ9EfvbHQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B99C234367; Tue, 3 Jan 2023 08:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1672733014; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/Ulj1KdXgOhz3mFb7YsOBfrLohsk+mOcfQTC8VIBIyY=; b=A6ezqKSaMS5FkyAjD92Oqzp58vLYYNOst800s7iKTLxeX/W4EsZZj7Nh/qSNHuIdbQw+8v UVQ+ITlICX/hTuNaWhltgnIb9FvIy7AYAYqlXIAYs3WxNcImmf0lJnQEjkd2urmE5lfUG/ PyH7UWhKQGzTcA2wqg0h0mFWznyD8LE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 99742139F1; Tue, 3 Jan 2023 08:03:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id a1ktI1bhs2O0eQAAMHmgww (envelope-from ); Tue, 03 Jan 2023 08:03:34 +0000 Date: Tue, 3 Jan 2023 09:03:33 +0100 From: Michal Hocko To: Jaewon Kim Cc: riel@redhat.com, redkoi@virtuozzo.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com Subject: Re: [PATCH] page_alloc: avoid the negative free for meminfo available Message-ID: References: <20230103072807.19578-1-jaewon31.kim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103072807.19578-1-jaewon31.kim@samsung.com> X-Rspamd-Queue-Id: 36BFA100018 X-Stat-Signature: b98cwxsuwbtnqoxfua9m9mfckg3zyjsd X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672733015-563511 X-HE-Meta: U2FsdGVkX1+qOueJR0yAvcZ3q+FNOGAC9/jWg+UIchRwdhu9B9Ld/8gec6hEaQyMuM/976cxzjH+clL+huG9zHfo4cfXQ2d2j51jqM1ZFNR533QPw2B8L1/tKC0wgoShoc9EQtBWZsQofm8yL4L3oHk4eYl17e7WJ+hrSJ46MsaVLNauvhpAYu6bNBomNVtwzNRDQuOA47JaOwp9j29YUSnF3S3ULF5IgAaH8TmF5hcSQfJPA3n0XTJpdxuyeoJVWre45Mzg1/o/mhNiIw2vbXH7jVSSbm7mFLLvheKCc5K9aMJyyaMOglxx/2CafJGouIMjOdcIypdXk2jC/o/BsNCIZf/G/952m+qW5vDtmlPEgo78faao0yddEb/ZCxLjxdOobxEJDiwILbRdI9LlfyhU0pdQ4xjlMnuw0dUHfAYXfCF2P4Sy/WsPj7CbQfDDdn9DlkLl4jPOf4Ppy4Q/aOXQcwhHiXLmtrcwY8GkHIG3YHmDxBo6gEr0Y9+rGHLh/fCZjgStro3IWEHVNDSiu4F1posMFQP8/S6T60q/dd8wJNDV+w6eLuBHaZ6WgLfzMzYCSow25pA6wbh1kF/o3Bs3DoOF8spHgAVLIWmMoznk6Sx0LSqBL4xgXDV1h9a3XvKZy6APYRP6L89HVPgKVOqviJCgREbhsSuraEMR49WhgPOOJ3f0YfCod9RidVYmbPyhVeJT29K2u0XtrAKnetFc0qpBUTiLHdl1pJTgo5T9cW/+Z9PLLqG/pJHoyDtAUdL02bw/Rd8OIHHA6dsxAJEy1LqbWl0tnGcwEf/Z75oWdoNC9cgRQEZ16KBOdhDPd+jieYanW2Ely8IU1TC9A/LH/AF3JpBZR5GaSRJi5ehgmRDBaL1Z1Jj0n+WUFXibZe0XP+/YtPNO/AcpmVkxUt4yA8P9SpvqrqyM1fa/8lLnNddApBbivba2nJ4VhXS4tYX4eGkJ32lGufCWvGB 8wXG8FGF tB2HMCeXmw38+LJo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 03-01-23 16:28:07, Jaewon Kim wrote: > The totalreserve_pages could be higher than the free because of > watermark high or watermark boost. Handle this situation and fix it to 0 > free size. What is the actual problem you are trying to address by this change? > Signed-off-by: Jaewon Kim > --- > mm/page_alloc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 218b28ee49ed..e510ae83d5f3 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5948,6 +5948,8 @@ long si_mem_available(void) > * without causing swapping or OOM. > */ > available = global_zone_page_state(NR_FREE_PAGES) - totalreserve_pages; > + if (available < 0) > + available = 0; > > /* > * Not all the page cache can be freed, otherwise the system will > -- > 2.17.1 -- Michal Hocko SUSE Labs