From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B385C46467 for ; Tue, 3 Jan 2023 08:01:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C27D28E0003; Tue, 3 Jan 2023 03:01:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD8588E0001; Tue, 3 Jan 2023 03:01:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9FAA8E0003; Tue, 3 Jan 2023 03:01:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9B1308E0001 for ; Tue, 3 Jan 2023 03:01:38 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 601E0160B0C for ; Tue, 3 Jan 2023 08:01:38 +0000 (UTC) X-FDA: 80312743476.08.A46C3F7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf19.hostedemail.com (Postfix) with ESMTP id 93F1A1A0016 for ; Tue, 3 Jan 2023 08:01:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cAINTZ+5; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672732895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9oyWaRXlIzBFaCON804thbmLR23DiivRnrdBiLJeOLM=; b=N8T05Fb1Z2F2n6HWwirfCwJ49gF+kuD7YBV46ncJj44nSYW+ElFypX5eIhs2USJ5F+40KE O3gCKBxrDHEfq/gXDHnCWYUvQ05FsD891crOxxjsyV6rSqV/fOJWvsSlbZQVwFxksKW3xc psGYPrJu91Ziphm0uYY/XZOwpsoFE2Q= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cAINTZ+5; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672732895; a=rsa-sha256; cv=none; b=JuC2ORBaslAoqrMAEw3iBHaCTHN7g7alj2wzyEEkRMkpZeg7CZF8TtGh/OoP6wY0m2BN13 TjsDsARQ0OmuAGFcLzE5uc0uuu/+JrNIT8/zZ/gZEJt8E3F8ytXa2O3E+yMAApbi6UOyzu VJ2EVgi7sI8y79LWqFYmhmLDSk0eddU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E6FAF60A93; Tue, 3 Jan 2023 08:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1672732893; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9oyWaRXlIzBFaCON804thbmLR23DiivRnrdBiLJeOLM=; b=cAINTZ+5eHmaWfCgedo/S6rBGsaY2VUMQlnvDXlxLROEjEJgpsKRXNDnH6aLCggXD9PJTk oCuJYv8BjwdztUpFS8oLydI9dJgLTWK19roM3TtZzMnRyIUpoAi8hCaV1Iaktsmwg5Hzdo KvHqeVXcg7BaAUIico6T3/XYDADXt8w= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CA553139F1; Tue, 3 Jan 2023 08:01:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dm9xLt3gs2OMeAAAMHmgww (envelope-from ); Tue, 03 Jan 2023 08:01:33 +0000 Date: Tue, 3 Jan 2023 09:01:33 +0100 From: Michal Hocko To: Tetsuo Handa Cc: almaz.alexandrovich@paragon-software.com, ntfs3@lists.linux.dev, syzbot , syzkaller-bugs@googlegroups.com, linux-mm Subject: Re: [PATCH] fs/ntfs3: Use __GFP_NOWARN allocation at ntfs_load_attr_list() Message-ID: References: <00000000000027524405f1452ea8@google.com> <7b10c1aa-0b3a-da0d-ea0e-b135cffc3491@I-love.SAKURA.ne.jp> <38352801-b4ae-0cdc-17ba-06b363da3aa6@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38352801-b4ae-0cdc-17ba-06b363da3aa6@I-love.SAKURA.ne.jp> X-Rspamd-Queue-Id: 93F1A1A0016 X-Stat-Signature: m5p7mjgxkgcwzpkbh5fj4wienrh96szm X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672732895-780261 X-HE-Meta: U2FsdGVkX19nX2NO36qxyJgx8acZTISn1jRNCrE91nxrxP+MvkMYuzGR1rdGrMDrj0JWP37KRF17bDRReabRAW1INUvZZyzKf83Al1okzqsddAss++LO5OP90M6m1yseHDhRl75wcpbYv7W8q5vKHCcSlR5pxX9f5IrbJ127h5t9j239X8fLX98UUNt3AIqeA6+51ZmpYPWCSadHfs9UfeFw8mudDkEsMVZNnEmEke6k3znIKKSBKBZbC9Zq/G/jCWw0RveeShsjsVQYLYUNh3u2+jh9rd6/ffhcdwu+/TkjEtOjwPmWhe3PGRL40fTX8QhFZ7FHGnmMsJtYHd2Qh/OcsXgGNhkL/WKcZ3TxLg4nGodNbblQ9S7XvOg8rimVgGxqB2HDll/0l235U2lsEUhAWMVWTcUrici4sccCPRdDufMrmdXDKYJKR9hNAoQdQYwcf/DrkbJDcchg8auq510LQ59yBcxT8Aie5YBq9Ni1oia8CapxwKv3ak19dND/cb5PdbD7Syt3+mp3hjRU8jGq8Wh6ThaFQdOqZicsXmNorZ1ilBdfUP4nINXoh8QpQH1OPkxyglgnhbRG2KRkvWHzGMLXJ4gLLdaHHfvaJ68Zc9jTLh7bRaG9ACTsKxn/mlhqTIJ7ZTe5QELNgXsGYqGzURAXwkb9xvbGzHc2SdbVEOiUQDgZ5JK9DcgFFfSwRqoC7/wtNDt/3ZYR8TBXmAHnGei/n0rXI3JbSVqZKrRwQYKTGGXVTAdr63F2hEtA/pKPnMk7sYW2NK5diL/Qz0nXBxda4FY4Q5HX5v/KFnEcyc0KCq30kNpcOydMpjDYa2pN/Bti6+ERxh1dYdyu/sMOzQf2DjxpZOXQpRTJ0s5/VJ4XbzSOZ0Iq300YlUncslEw7iWvhbalBUD8zyr5cbdeurCpAx/XozrxJA3kZWWms4LUiiZDCLIIAQQUd9WJoxrA2BgZSpFnjjRr8Ix k/pLNdMo torpFEEfgemUDcuFt4GuoXox0yJiZ4xlcv5ia X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 03-01-23 09:49:22, Tetsuo Handa wrote: > On 2023/01/03 5:19, Michal Hocko wrote: > >> @@ -52,7 +52,7 @@ int ntfs_load_attr_list(struct ntfs_inode *ni, struct ATTRIB *attr) > >> > >> if (!attr->non_res) { > >> lsize = le32_to_cpu(attr->res.data_size); > >> - le = kmalloc(al_aligned(lsize), GFP_NOFS); > >> + le = kmalloc(al_aligned(lsize), GFP_NOFS | __GFP_NOWARN); > > > > This looks like a bad idea in general. The allocator merely says that > > something is wrong and you are silencing that. The calling code should > > check the size for reasonable range and if larger size. Moreover, if > > lsize can be really more than PAGE_SIZE this should be kvmalloc instead. > > There are already similar commits. > > commit 0d0f659bf713 ("fs/ntfs3: Use __GFP_NOWARN allocation at wnd_init()") > commit 59bfd7a483da ("fs/ntfs3: Use __GFP_NOWARN allocation at ntfs_fill_super()") Bad examples to follow. > Is KMALLOC_MAX_SIZE intended to be used by callers like > > https://linux.googlesource.com/linux/kernel/git/torvalds/linux/+/a5a1e1f249db4e0a35d3deca0b9916b11cc1f02b%5E! > > ? Nope, this doesn't look right either. This all is about inhibiting the warning much more than actually fixing the underlying problem which would be either check against a _specification_ based or _reasonable_ expectation based range or using kvmalloc instead if the range is not well defined. > I think that, unless there is a known upper limit defined by specification, > checking for overflow and silence like > > https://lkml.kernel.org/r/6d878e01-6c2f-8766-2578-c95030442369@I-love.SAKURA.ne.jp > > is fine. These input are random values which do not need to succeed by using kvmalloc(). How can you tell the value is just a random noise or a relevant value that people would actually want to succeede? Answer to that question gives you a hint on how to address the issue. -- Michal Hocko SUSE Labs