From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D135EC54EBC for ; Mon, 2 Jan 2023 16:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46C1F8E0007; Mon, 2 Jan 2023 11:09:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 451928E0001; Mon, 2 Jan 2023 11:09:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26DEE8E0007; Mon, 2 Jan 2023 11:09:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 148798E0001 for ; Mon, 2 Jan 2023 11:09:18 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DD449A0307 for ; Mon, 2 Jan 2023 16:09:17 +0000 (UTC) X-FDA: 80310343554.23.A25540F Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf30.hostedemail.com (Postfix) with ESMTP id 338E28000E for ; Mon, 2 Jan 2023 16:09:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y1fHHCtP; spf=pass (imf30.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672675756; a=rsa-sha256; cv=none; b=Bo4LBPwwTo5rSWGaU7gJpt1PGlk4QkxxArUyX0/SNtBgyXKy9JpkBW09abVCTQk52pO6V9 TsjLBtuF59b0wGwcG5TAIC61IPo7vsfNvXoXAWnJbte3f8l6QpsSKEivR1rkGGVfOhEJ6k dgD16F7Kg2TDY/mm/U5aCiPi0GEA2Jc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y1fHHCtP; spf=pass (imf30.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672675756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0f6Df5GAHRv63Ek+imSWcwMNsHw4338pqSJLA2YJouo=; b=jeh53FColAl5/IZ0OtZMJ+55DZcy17OhKwXQGWfntU1iyRRbkfHz3JlG6vC2FM0Kgmcfjf 7jwCW+lU2lhl7pRXpWlVyjy59OFuyDItPawHKmqrGg67X/5gPpMn4wG/TckO5w1Sp2l5Ja 8Mf/nVu4bsdSPzQ4DY6iC1B07O37XPA= Received: by mail-wr1-f45.google.com with SMTP id y8so26672886wrl.13 for ; Mon, 02 Jan 2023 08:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0f6Df5GAHRv63Ek+imSWcwMNsHw4338pqSJLA2YJouo=; b=Y1fHHCtPosDd5qpxe1/lQLlPANHFOWJ3BbfB5ks2rVkHSmDmSAPNt4ZH1JrHzJsgJC 6rje2eLE7x4GkF9XJobFF2tdHGEcwCuFMdRfS1kRMEWhZy2Gc792lXKZ6BNXqHFQL2Eb VK130PKrGGwNsc8OvPfmJ/JvF/xtpMitUFBtdHqJT+pQKj5T2ofxP73kOFOewfj4Ee/f mmdUYICW3NrIR+ChcYifGTfI9fkKKpf0Sr7XZmccjIAlYSNr16uzOMOvMaw6YISoA1MQ /g7rwcxr51KOmg9VXKhPB+Vl4KU32jLfWGh3tlD5yzNbu8p542D4F5MWvs7xyl2D9/xT hJ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0f6Df5GAHRv63Ek+imSWcwMNsHw4338pqSJLA2YJouo=; b=03/aAThFxZFsuS+kk22khx9M0w1u5RHUQkiktvraAUWV/PFZVZHREdvNDzB7KELnnH 0p4JWEw6cALiRrABMrOW2FEl40LlQ55m+SnnjzCznOuh6Q2wKifHiExje7TuE5zMPuqz nMNPMmgVvXjQ6aGBJO/9pCj5TMRvqhApUQ9Xj1tv/ejPNL3bH/veirhWmLsDUaCHJ5pP fqMJlU9qHLRvv5fpj4RGE5Lffuj7IP6mhXnD6K30xRGVx3HH1XRjRvuCH0O88Qx0fpnO 5emHYZjWylMM0Fe6cEMAgBElxH4Jm5MCBB1vOnq+acfJa1/VJedxoEmEDmqnhyGus/Rd l15Q== X-Gm-Message-State: AFqh2krWtPdzFiNyaPJUr4Z9jIaVEIdH+0yAsoX8YWol8Dj2t/GiD0ZC WVEmwKYCGUhfdqw3wduolGA= X-Google-Smtp-Source: AMrXdXsi8RPlPraZsfzVbsmqLj0DC8LkHcsljtZkutjXXPxuT5lClS5XZH2CibGK0Yx1VJv4b6IcqA== X-Received: by 2002:adf:a15b:0:b0:256:ffcc:49b7 with SMTP id r27-20020adfa15b000000b00256ffcc49b7mr33710333wrr.62.1672675754790; Mon, 02 Jan 2023 08:09:14 -0800 (PST) Received: from localhost ([2a01:4c8:469:341:d1e1:a149:58ed:f096]) by smtp.gmail.com with ESMTPSA id u3-20020adff883000000b002423edd7e50sm29443498wrp.32.2023.01.02.08.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 08:09:14 -0800 (PST) Date: Mon, 2 Jan 2023 16:09:13 +0000 From: Lorenzo Stoakes To: David Hildenbrand Cc: linux-mm@kvack.org, Andrew Morton , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Jakub Matena , Matthew Wilcox , Mel Gorman , Michal Hocko Subject: Re: [PATCH v3] selftest/vm: add mremap expand merge offset test Message-ID: References: <420e491062db9151504aef5661c8a2d928ef6bd7.1672675224.git.lstoakes@gmail.com> <9d13393a-d203-23de-30ae-4d6476a94fd7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d13393a-d203-23de-30ae-4d6476a94fd7@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 338E28000E X-Stat-Signature: o4my8bewbycr5rp3duymc8upc9gpizip X-HE-Tag: 1672675755-412540 X-HE-Meta: U2FsdGVkX19IwfmIN0LIdUGITXDLa/UFWqyLMjNksmDprM1S3KHiA40eUH+IKXer5rtBX9F0DCY0JxSc+PvwXohsgVFBCN+yBep5tkgtkd9cxSLBO+ZLHUNIxQhNuyXMHA1kC+vTCmKVZ9Rl/Z1yAmW/NcZH8nicxFdYmEi1F0ltdkpmQAXvIFWSqppUj34mQvfKhHktv/mg2Phm9Ta2tZNSLK56immjWfjT5Zn68dVqFYMVFcOod4HgxcuKNS34Ji+EoCTFLhDrZaXbk36ULrdA8ULIkh3LrHkhPsA9B64W6Y8h+mIHmgqN852DMT0jRE0M/2kAnKqOdgDX6a+2wddPHO0+JbjXD7ouoLbulbdczY3tB/mQQx5qxvqzTtmvpxFhR4vzEJn8Ksutr0+O8cSYes3NX+VWpAkb74H/qqwFWYU+wTRkzobQ8nRlF52CTITXiG5v0g7LN1mv7cbVayBBllQSK/PNQf3PESr4vku17UciMfkndFSsxZ+PXq9ZkhrQPEeevC4gSfgOU8mw9J1PulSjJbcM6Xw+x9Zj8s0h2qeFhxJM9LH/JRLDOtuUC5mNeNnJPQpaRQvXFeKGapNGualSGWTzvbWFvVGo+eFLGhj8jj8c0/RLe9YA9umhCw4hSEUXqmqHDrsOCDyOMrUXir2ThnGLYWmHqkOTSmra6tU2uRKYpUZzsV0py8bAPNtagZUxyzleOaKVRCMeSs+sgOuIK0PLW1ZvuV7uP0xMrSAFKqZ9Xg2NaRyOuzn9J7zLfef7mm+3DSy56K6u6n2PLv18uRyI6EsROpfxtCE9FVZaC1qhoE/QwcBMyHW85gPEzeJygJopXbw+TDAt9jMXvZPKrTAbb1M/goEjbTpC2zVmMT/ZiGOFVFiWMuonaGYeXLDkC1lNmLGsCMc1rGRAUAK0hDqaFuA8Bm5xbkefzbeYahM9Fh3Vji2qOvKTX36AjKN3HfNhTR1ck48 htil6l8o Wh83jQBnWsuHsoSXoDewMhUFQWSe2QVZmdYIWdkgVCjq5lccDMIWiP6C3hPwCzLV0IelqFCLXvIbZHEG5XdWTna1ajw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 02, 2023 at 05:03:31PM +0100, David Hildenbrand wrote: > With the exit() in place, the else branch is implicit and the else can be > dropped. Good point, we'll go to a v4 then :) that does neaten things up actually. Hopefully this should suffice! Agree with your previous point about tooling by the way, it would be good to have some more functionality in place that wraps these places where you feel the need to goto.