From: Lorenzo Stoakes <lstoakes@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Vlastimil Babka <vbabka@suse.cz>,
Jakub Matena <matenajakub@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH v3] selftest/vm: add mremap expand merge offset test
Date: Mon, 2 Jan 2023 16:09:13 +0000 [thread overview]
Message-ID: <Y7MBqfYv54rY48Wi@lucifer> (raw)
In-Reply-To: <9d13393a-d203-23de-30ae-4d6476a94fd7@redhat.com>
On Mon, Jan 02, 2023 at 05:03:31PM +0100, David Hildenbrand wrote:
> With the exit() in place, the else branch is implicit and the else can be
> dropped.
Good point, we'll go to a v4 then :) that does neaten things up
actually. Hopefully this should suffice!
Agree with your previous point about tooling by the way, it would be good to
have some more functionality in place that wraps these places where you feel the
need to goto.
next prev parent reply other threads:[~2023-01-02 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 16:01 Lorenzo Stoakes
2023-01-02 16:03 ` David Hildenbrand
2023-01-02 16:09 ` Lorenzo Stoakes [this message]
2023-01-02 16:10 ` David Hildenbrand
2023-01-02 16:16 ` Lorenzo Stoakes
2023-01-02 16:20 ` David Hildenbrand
2023-01-02 16:22 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7MBqfYv54rY48Wi@lucifer \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matenajakub@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox