From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E632CC4167B for ; Sun, 1 Jan 2023 07:51:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D99138E0003; Sun, 1 Jan 2023 02:51:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D49848E0001; Sun, 1 Jan 2023 02:51:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C387C8E0003; Sun, 1 Jan 2023 02:51:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B320D8E0001 for ; Sun, 1 Jan 2023 02:51:42 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 83D021C5D13 for ; Sun, 1 Jan 2023 07:51:42 +0000 (UTC) X-FDA: 80305460844.04.56A3414 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 06AEFA0003 for ; Sun, 1 Jan 2023 07:51:40 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VVT9XHrC; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672559501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Jw5lAmUz9PecwTT2HQf2wH/a08yY/ItbCtY1GYmz/E=; b=WeWxmPdxSoz3xQ3pplFXa+f7+qr9JAaTYN8RGCSKevgOOiGzpXXRcKJs34xIepAgHQjL0Y ZoD+fAZWhMAtu55/lseuVxeO6DdL8cxo4WRzuAJ84rQS7TRdSsGBZHERB8Hc7mygJSHuLi Xni+NiqI4cW3yaGF7Rqycf8KfRvvrlA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VVT9XHrC; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672559501; a=rsa-sha256; cv=none; b=CIvFzXWwsBaGrI39zuNgfSQP/CCztEstPx2ZiXpS5QOvv9h8Q46e8+cbJ3Ichit4eA0r/4 MJsE+Pl1uSto4gaCkyZ8gDQ77q1Yov5yPNjAiB8bNQHqzsNR/KMvNkbJdoUiF1UdgJWEpt H/KF2ENA2zT7sNZArVvx30rB9xMLg3I= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC73360C7B; Sun, 1 Jan 2023 07:51:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44987C433EF; Sun, 1 Jan 2023 07:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672559499; bh=3KFyT2GsRXTISn1ehU/3Q5B8HYDCYRJool6Gn7EU9D0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVT9XHrCCRKPJZGP6sAjWt6EvEQ7d1kqqDDFuy7bNW04V9rjD6sseH/WZ5ToWk2cG wIKk+DKsh4t8XgckLkvI8eDphNEwjuso1w0lMpKbPNsx4+RBZE9nKlbkMFhkrzEkcE 0kqisJu7Tg5uj7AHJUK3OswAGgNeNNNtR/0jKdb7O1HODFYoGl2Lex/TPIcxUGGKqY IwvGfUxbaoqkIoj/yZYR32EYo9l/6qH2DSY+GkYqDoufD2v9wHxA1hpRwPhoXIt207 K3JZJ6qxvUti+gZoBihublfnuCSEueC4EiRa+Na3ahvRnRrahKYRli6lxjfn8vlS7A ROMSRxcPVKbhQ== Date: Sun, 1 Jan 2023 09:51:24 +0200 From: Mike Rapoport To: Dmitrii Bundin Cc: jan.kiszka@siemens.com, kbingham@kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mingo@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz Subject: Re: [PATCH] scripts/gdb: add mm introspection utils Message-ID: References: <20221230163512.23736-1-dmitrii.bundin.a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 06AEFA0003 X-Stat-Signature: kdq8s9ug7q6szat457upak7jfbrodzwn X-HE-Tag: 1672559500-238635 X-HE-Meta: U2FsdGVkX19gvyDiQOzBarztWVWerGAF3kqNU3ZDRYwiT9Rv+bYWBHqKMDYo0oAwEqLzAn6TPNpUF9Q22wW133c2R/nS64XTtiZJ1nIOUDb7DttDhi7TPInYimN83rfIen6UaPhKL5oszLh84hZQybIZn/2uKgfqbgA9KqbP0ucfMKin8WCgRoEZddMuQmbAlWUWGHAUD0mmpHuil9BslawPPYsD+Jco0+OLctZzZ5ji+V74zstZv68Crx+H01kSUy0kKQpFpSt8/o1wVMUbVZO90bGf82EQoBsgF+roRM9SRHwQv01adX3ouBBd05qrjQqixYLUAWplTDAckMBlPPLECkt/m3V/iNSuL+xyBlqu0drPVBXHJ3YoNs6lNsli0KU76F2iaOgHINQzZV38mvcPY66vVka4rvsfAa8+HsSEdoLYoVd0reVi+y29YOl3nWJmGU19pVPPzRm6MpeI5qQVQPG6FnSSfdM0vZXAa6FvX4A6mbAT+KjQwqyepSm2OnYUoy907Jj4lz4c7am01Tm1DvkMVePKFjwnD5zwEF0azej2FE0rYFiOtvk+TKyJIZCAABrvj06LDuBX3axJzO+Epaj8vSEiSIcwuqZ7PNb69uRlWIXxoNGNmhiyh+yIcXYPp1ZU2ABm5uwiFmHPazRlT3xDYY5KTAT8qiZPg8oqFPFj2ZQ2Rh4ZV7oHhXAs+XGKgsvQB9RHpztolP0ed6UsigVrXCx6HeQXVQXHoUoDjFPQ0Bjb2PinYdaqb8KVy7gb4C7ZbKdzVRs/if5e9cdTURjwtJl+J8ezSbpdLIzAmdeA0stoOhUmDO/+l4GyOmfzoJuzRj8XoRiRIKf8eZ2esiQCWeaOxjDZNqr2kFpC5Tj+suPAzbdWk/mv2P6/GpIeGHHWwhI/Q/F7Vb+/6294jiTEIh5pEB/zMFoVLikqX6VyekKcbc0Bk1lqBKpYLLnItPVPz7pvZTq3PGx dpjgCobK FWodwwDk2+hsnOx4ouvvnLXWtujMGbuH1lNSUK0XUGX/vOaf0oR3n32s3Co36tMc573yg8DWpdU9MZe+vk8bWn2ss2FHEbvkvydxPakX5GATyUnk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 31, 2022 at 08:14:30PM +0300, Dmitrii Bundin wrote: > On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport wrote: > > > > The commit message does not mention it's x86-specific. > > Not sure how gdb scripts handle per-arch functionality, but at the very > > least this should be stated in the commit message. > > > Thanks for pointing this out. Will fix it. I put the command's code > under the if utils.is_target_arch("x86") ... else > gdb.GdbError("Virtual address translation is not supported for this > arch") as it's done in other scripts and have plans to implement the > same functionality for ARM in the foreseeable future. > > > Any particular reason to make it ALL CAPS? > Actually, no. Do you propose to reformat the output with a lower case? I like lower case more :) I'd also put the bit number first and would align the columns, e.g something like: bit 0: entry present : true bit 1: read/write access allowed : true bit 2: user access allowed : true bit 3: page level write through : false bit 4: page level cache disabled : false bit 5: entry has been accessed : true bit 7: page size : false bit 11: restart to ordinary : false bit 63: execute disable : true -- Sincerely yours, Mike.