linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/mmap: fix comment of unmapped_area{_topdown}
@ 2023-01-10 15:03 Vernon Yang
  2023-01-10 18:44 ` Matthew Wilcox
  0 siblings, 1 reply; 3+ messages in thread
From: Vernon Yang @ 2023-01-10 15:03 UTC (permalink / raw)
  To: Liam.Howlett, akpm; +Cc: linux-mm, linux-kernel, Vernon Yang

The low_limit of unmapped area information is inclusive, and the
hight_limit is not, so make the comment to correct.

Fixes: 3499a13168da ("mm/mmap: use maple tree for unmapped_area{_topdown}")
Signed-off-by: Vernon Yang <vernon2gm@gmail.com>
---
 mm/mmap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index c9da9119d7f2..e06f9ae34ff8 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1554,7 +1554,7 @@ static inline int accountable_mapping(struct file *file, vm_flags_t vm_flags)
  * the correct alignment and offset, all from @info. Note: current->mm is used
  * for the search.
  *
- * @info: The unmapped area information including the range (low_limit -
+ * @info: The unmapped area information including the range [low_limit -
  * hight_limit), the alignment offset and mask.
  *
  * Return: A memory address or -ENOMEM.
@@ -1581,10 +1581,10 @@ static unsigned long unmapped_area(struct vm_unmapped_area_info *info)
 
 /**
  * unmapped_area_topdown() - Find an area between the low_limit and the
- * high_limit with * the correct alignment and offset at the highest available
+ * high_limit with the correct alignment and offset at the highest available
  * address, all from @info. Note: current->mm is used for the search.
  *
- * @info: The unmapped area information including the range (low_limit -
+ * @info: The unmapped area information including the range [low_limit -
  * hight_limit), the alignment offset and mask.
  *
  * Return: A memory address or -ENOMEM.
-- 
2.34.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm/mmap: fix comment of unmapped_area{_topdown}
  2023-01-10 15:03 [PATCH] mm/mmap: fix comment of unmapped_area{_topdown} Vernon Yang
@ 2023-01-10 18:44 ` Matthew Wilcox
  2023-01-11 12:47   ` Vernon Yang
  0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2023-01-10 18:44 UTC (permalink / raw)
  To: Vernon Yang; +Cc: Liam.Howlett, akpm, linux-mm, linux-kernel

On Tue, Jan 10, 2023 at 11:03:20PM +0800, Vernon Yang wrote:
> - * @info: The unmapped area information including the range (low_limit -
> + * @info: The unmapped area information including the range [low_limit -
>   * hight_limit), the alignment offset and mask.

s/hight_limit/high_limit/

> - * @info: The unmapped area information including the range (low_limit -
> + * @info: The unmapped area information including the range [low_limit -
>   * hight_limit), the alignment offset and mask.

ditto


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm/mmap: fix comment of unmapped_area{_topdown}
  2023-01-10 18:44 ` Matthew Wilcox
@ 2023-01-11 12:47   ` Vernon Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Vernon Yang @ 2023-01-11 12:47 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: Liam.Howlett, akpm, linux-mm, linux-kernel

On Tue, Jan 10, 2023 at 06:44:27PM +0000, Matthew Wilcox wrote:
> On Tue, Jan 10, 2023 at 11:03:20PM +0800, Vernon Yang wrote:
> > - * @info: The unmapped area information including the range (low_limit -
> > + * @info: The unmapped area information including the range [low_limit -
> >   * hight_limit), the alignment offset and mask.
>
> s/hight_limit/high_limit/

Okay, thanks you for review.

>
> > - * @info: The unmapped area information including the range (low_limit -
> > + * @info: The unmapped area information including the range [low_limit -
> >   * hight_limit), the alignment offset and mask.
>
> ditto


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-11 12:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 15:03 [PATCH] mm/mmap: fix comment of unmapped_area{_topdown} Vernon Yang
2023-01-10 18:44 ` Matthew Wilcox
2023-01-11 12:47   ` Vernon Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox