From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C06C5479D for ; Wed, 11 Jan 2023 09:36:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E24288E0003; Wed, 11 Jan 2023 04:36:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD40A8E0001; Wed, 11 Jan 2023 04:36:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9D088E0003; Wed, 11 Jan 2023 04:36:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B9B1B8E0001 for ; Wed, 11 Jan 2023 04:36:53 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 816C91201D4 for ; Wed, 11 Jan 2023 09:36:53 +0000 (UTC) X-FDA: 80342013906.21.7D61952 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf11.hostedemail.com (Postfix) with ESMTP id B812F40009 for ; Wed, 11 Jan 2023 09:36:51 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="UEEhg/SX"; spf=pass (imf11.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673429811; a=rsa-sha256; cv=none; b=2wP57KAEdX+ocrud7PBap6SyFWdyyNdHt9/BgqaVGvMc/jmEgkMoFMeJ+6aNQvnKqUcrfA r+gtIe36TEou96gnduH7HGKCjetkWOuxw1khi1d5D4/6jC1DM/bzsiyrhMEqmgKWD7hX8w X3JX1GVsATaUt1E7/xO/S1OIArPWdP0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="UEEhg/SX"; spf=pass (imf11.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673429811; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lgxbe9iy/UIiGBDGt6X9MleqRSYp4HVx7CIEeTI4ufU=; b=6ykBQB4x3mNnIi0jaEgPcVI2uUOX+sDMRFKNi6LKc6faiQoni5luLxGw13+U2//5GDRmSB Dm+Hv3ZsXeAaNDcENhnhFSeGAwsH1iVfBZaxMGYtMwbd56QtcAZFT2PdD3CE8L0j5Os38x MU6Nj/9FxeshQj9KR+FIpfhq8oY+GbM= Received: by mail-pf1-f178.google.com with SMTP id s3so8438392pfd.12 for ; Wed, 11 Jan 2023 01:36:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lgxbe9iy/UIiGBDGt6X9MleqRSYp4HVx7CIEeTI4ufU=; b=UEEhg/SX/TFPKsEVPlR4oEk9BfADyFg+Ym5uadlWJdA88dymfbQzGUqUcv53K8Ot9S LEp/mjVABk63mEPJWe6twp4CnQX4OOte386K/jBXBW+qze5DQcEfgSzLZ/tD+MpZLCWd 3Z0x67zTLBAUoSf5VT7ZcrdGrSuoNtT7m2M5H47O6pS+g9AyI13IGMhhYojTWkCETSLZ n2Us3htJCeH0cZhlEqifBRXkRUF4V6Dts9iPqfT8nTpIlGE8UKUraXaoI+cGizRUzwJ1 dSOfxS50WvQ/pM8Q3FZDdJ1BEw5ew9Fn5+8sSsQBoj5pFNOHC1BQhvjCoxFKy6SS8dqg w5Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lgxbe9iy/UIiGBDGt6X9MleqRSYp4HVx7CIEeTI4ufU=; b=6/gkr1Pip3i2NwjwnZwfNEM1p7AR3Tno95SelPFpJfZM4Z17U1Ri6bjIbgiuKr4SYp ZIeeIPLH3dQBh+eqH67fr6mKhzUTWk8Gss/7yVHvxHwRKBrCRQiQOPn2dLLovajx/kg5 6t3LSDTVaz/MmhTKWtb/6E2g+3hw9dK6neiehZr7RJlgzw7xymWmZ+iI7xOYiC/fVecN 6l34vZHIoHLMgUaPGo5iKtukwpONLiKKpDLEi1zGtysrmVU8qAxn2T3Yrj9uhXGMEjDK km3BhUm88hRl8vPXekjuRGj0H2jCbaayMPtYjFXhO1cpSPiRJ7GqiFd4GjwPXCiCGyT5 VfKQ== X-Gm-Message-State: AFqh2kpH6JFHLasJnhqdji9k+oL1rnc0NxAXDRGMGITLzURPxtbHcHKW Av8SnShFFGtXVm201jY7XSo= X-Google-Smtp-Source: AMrXdXub5iyH1ER+/F6NZA6+AIJbsgt/6RPVVs6/bQTrKDKEAgPi27tls3bG1gM8jLpGoV+qdfLY9Q== X-Received: by 2002:a05:6a00:72a:b0:57d:56f1:6ae7 with SMTP id 10-20020a056a00072a00b0057d56f16ae7mr60870508pfm.33.1673429810487; Wed, 11 Jan 2023 01:36:50 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id z24-20020aa79498000000b005821db4fd84sm9536546pfk.131.2023.01.11.01.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 01:36:48 -0800 (PST) Date: Wed, 11 Jan 2023 09:36:44 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: SeongJae Park Cc: akpm@linux-foundation.org, willy@infradead.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/sl{a,u}b: fix wrong usages of folio_page() for getting head pages Message-ID: References: <20230110005124.1609-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230110005124.1609-1-sj@kernel.org> X-Rspam-User: X-Rspamd-Queue-Id: B812F40009 X-Rspamd-Server: rspam01 X-Stat-Signature: xkjw11nrmh9awi5znqtc17g9ru6tg46s X-HE-Tag: 1673429811-811752 X-HE-Meta: U2FsdGVkX18n/sHCB3ZvvztWoueelpYHW9330Ryy1pr9N9MtobjDaZmv8R12/dQ73HVqOSsVnhRm2OPGToPNBuZCrkSDqKLL1ZLkoFRIP9Qbnh7YFQ9yWe+5F6KZ80agYUcrrckTZ49ro2g+HMaPefu2uiXajBcv6wXcfF3UXRP8RQOSMMNivdRsN7yS/d4TmH2dN8xVUyDz4hVu4SuHdK73UphR8w1M4Nh5f2RsheiYn07+JXQK0XHItvUkQucX8JtJQFyAo5qEPjmDeH8y/5Qx/1F7YDZRp+IP2L+Ej/gOyvbDD5j7s9iR8BymAvULT7rLJ2F3/ngiexJfzI41ODqtLDcXKtiaDl+9o+StN8QYBk8c9MmP8vCXFuYXkV7P2kYzorNYn1hVMBhbmEFiYamp6JW5zjpQ1IpDaZ6XVTfZLyQ3MJt8HD3iRBG5ym4MuAoEMxMECjUcfu6qj0Y82UdNOGwUukxHC9nuXHF2EHXp3GyPr0iJhPS6w8335uFLHwS6/9kPL42JHg2fk/Cc1DWCMVqFl03KggwGZKMqKEQbl6OXFuzeQftXDzEcC8EnUlga+b3WFtj4cqQi/PZXzZuqLrqpG+S3W6g++COceOtjv0Sw0uR4I0a1bN4hcjaQhouApVTgL4M/ZvVYhQBZf9Ez2IAzE9Zbzih8oE7Ce+7aRnMcEXKQM+ebKkG9xWKGQNTl05euJer4JlmKVjdQ/rDwm6VV/dQS8miH5YsN0CgAgaGkZtTucoqtBFcSF83nyxWkbixRwsqF7ra1T7TPUO7++bRMF44b92rqaRwmU1/wwCD4G7rjCPZ/Dr49dUGnHfwPhaYxzgzRSlGIriD+DbuYofdz/dEdiuULxAy+QzWf7CLEkc3H92XHrWD8794I/CMKoP794dxlnQm/96O/EIURvxn2PJ5zPa1KjR1qhlHl3JV+Wo3f/oKF6ofwxE/1GUZXEM7icHmAkQFEe/Z HPD57TdU T3vrGgHk6ibh8ngjtOOZOPlwH7qUnYDRAk8s/5xED+yvJ19tG+TOm9NcFBTLze+PpePlsQ6yIIg8Xub8rzK4luqVksQlPH2c7WjAiJA7q24oQSb5SsaQYreHdlPhAaf5rkkt5ZjFgP8fVrSHR2rFA4aEmFfsd8hJaZwVcWIZh9m7Z5/U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 10, 2023 at 12:51:24AM +0000, SeongJae Park wrote: > The standard idiom for getting head page of a given folio is > '&folio->page', but some are wrongly using 'folio_page(folio, 0)' for > the purpose. Fix those to use the idiom. > > Suggested-by: Matthew Wilcox > Signed-off-by: SeongJae Park > --- > mm/slab.c | 4 ++-- > mm/slub.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index b77be9c6d6b1..a5398676dc60 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1389,7 +1389,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab) > > BUG_ON(!folio_test_slab(folio)); > __slab_clear_pfmemalloc(slab); > - page_mapcount_reset(folio_page(folio, 0)); > + page_mapcount_reset(&folio->page); > folio->mapping = NULL; > /* Make the mapping reset visible before clearing the flag */ > smp_wmb(); > @@ -1398,7 +1398,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab) > if (current->reclaim_state) > current->reclaim_state->reclaimed_slab += 1 << order; > unaccount_slab(slab, order, cachep); > - __free_pages(folio_page(folio, 0), order); > + __free_pages(&folio->page, order); > } > > static void kmem_rcu_free(struct rcu_head *head) > diff --git a/mm/slub.c b/mm/slub.c > index 67020074ecb4..d5f20c062004 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2066,7 +2066,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab) > if (current->reclaim_state) > current->reclaim_state->reclaimed_slab += pages; > unaccount_slab(slab, order, s); > - __free_pages(folio_page(folio, 0), order); > + __free_pages(&folio->page, order); > } > > static void rcu_free_slab(struct rcu_head *h) > -- > 2.25.1 > > Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks!