From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C94C46467 for ; Wed, 11 Jan 2023 13:43:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2E908E0002; Wed, 11 Jan 2023 08:43:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB6628E0001; Wed, 11 Jan 2023 08:43:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7F648E0002; Wed, 11 Jan 2023 08:43:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B4BEF8E0001 for ; Wed, 11 Jan 2023 08:43:56 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8F4E9160DC2 for ; Wed, 11 Jan 2023 13:43:56 +0000 (UTC) X-FDA: 80342636472.30.D051F2B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 1A7591C0006 for ; Wed, 11 Jan 2023 13:43:53 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rpw7rC4c; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673444635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cItd0bY8oSKhHtDYzW+0pBisbZrmS7bJcbFH1GTRgO8=; b=UxsnahHSCqjGtHs7mCaMwNAJStR3d0IkDFUCK66gbjHHjYYkGxZ//l8xsFS6wVe9r5dKJj ofxhdyqBF6D1PvjOr7GDviC2dyox9Z6OdTzyIWPuY1R8hhaF/6OjkjBQzQMDxRfrwgQ57W 4lnU9cpltB5Me3JXhxvGGcZErY9rq8k= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rpw7rC4c; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673444635; a=rsa-sha256; cv=none; b=N5axelCfLw0uKFLsCE86DzCp9ADfA9QtNgEWoUN6H/oo/oOkmK5ZlnogSWgUwGPhtCSPEZ I2iyfbW9eiF+V5m9hGWVHUEmE676Cq0EtO7DDZ+fW67XG5YmRC6MYDIM/1sBIBoypDwy3u YMbNfc0AV/dIykr/VOjmWNh5qauX7Ks= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cItd0bY8oSKhHtDYzW+0pBisbZrmS7bJcbFH1GTRgO8=; b=rpw7rC4ch4ZPQlmQAxYYWGufXX 9VYUI5FeCcGREzOlPcqkuSr7kuR+EaFyfUlCPv9YOy0hPxIXMY0smxBket2gMg/AuyckJxFrC0S8E Q6S/9xiJ0ULS9dQ+WxWrUaJi0DdPZdrDCJNlo+dRcXPA9m0xTPU1VCtsa3wrpGV+YbaS/lJGDyKOS hbLI3t3N9lSMf0KVnLbJ6km0WLYe///8G+TIAZnUPWwnqAPlMmDEOtrPkgtR7+jacov+mHsKmjUE5 rvbM2jtAYLX9nJOLRqR79KtOkAgu0Y6yqnQ6uGQSrc5ZtS3piiPSqmhsEJU5EeJYnc7pxdxPfvnS3 fIu8c+JA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFbON-004Ar5-2G; Wed, 11 Jan 2023 13:43:47 +0000 Date: Wed, 11 Jan 2023 13:43:47 +0000 From: Matthew Wilcox To: kernel test robot Cc: Jesper Dangaard Brouer , Ilias Apalodimas , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Jesse Brandeburg Subject: Re: [PATCH v3 18/26] page_pool: Allow page_pool_recycle_direct() to take a netmem or a page Message-ID: References: <20230111042214.907030-19-willy@infradead.org> <202301112022.zmClDxtO-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202301112022.zmClDxtO-lkp@intel.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1A7591C0006 X-Stat-Signature: 3kgkgknz6zcy7cctu7nrqc5k8mk1bzq7 X-HE-Tag: 1673444633-977697 X-HE-Meta: U2FsdGVkX18beSwdz2GcAzRuY7qw378TN/v7MwhHHNQIM5zDJYRM2wLklDlXdTlf3rsF38kpZU0QwyKWtIbha2tjVrmJPAhtUxigiiyVHkedACVqkRXZ4GumPR8TWPj8Ugw80eneV7ABPLWK9MHd2LyVYtSJER7xR+oNZ9xXi+RyfJUIVFVY4k0Z6aGzPadZsS03A6feo++c6G/ru64q92oFp2IMxcgFlKzYRTJXrV2d2yaFbkfep+Aybdtriix23nC9znZ8qW4ZoW8Cmm+qkaxTTAQOPQMydGV4fsA4Pg5XarfT+osc2ADaMUjjIiLulYmytP3ChxYmKMG9o+wEQZETacv9ZGx84gQTIMsK8jpjL1DHm7XbA/tba6KxigcaG/0O9a6FmKgGjeVe7ps2zfGeL7V5YacbRapKl8m4czj70RiLUyBO3F5SR2N8ngqno4zAbGdoKRNsUuVPHhoR0+TfgELDAplDpCAJ6RQd6TxsBnaD/P3kPDtWYP23x+8WZeOHyWd6ek9+yjWIJxF+eugclaqoQf1wUk0evHnfGQlQRV4t47MCL8vnKIIPNeYrqWt40LPbIHf9JdiOGZ+wqXZOJkGOlcgxMUZD08Tr65UliIvzdiB2g/o1H+CEF+ks2FwIXI8pLrhVCB4dseNvAyHCvf4/SLJZoy5Ljf0gkRJ1wzhvAOgVWBGA2JudFV3MAbq1F3KMU5KLERfU9LO8M1IhcLRishdk6H46hDqghJd5myVJqV0/yWT0vKBmqxGNlUWkjZcajqLMe0kLeI+vaR/7+rRWbd1x19iox7b8QjNFPbnYj0t7YnVZva477cKIu98lJJ93d6mgtX0eK1hEhjxp3x5KTQmeI9yu0ffR5H/AMNAIbroWRSepGJydaEIPdlpKKvUUnYpiN+H4Eppsnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000192, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 11, 2023 at 08:48:30PM +0800, kernel test robot wrote: > >> drivers/net/ethernet/broadcom/bnxt/bnxt.c:2978:4: error: controlling expression type 'void *' not compatible with any generic association type > page_pool_recycle_direct(rxr->page_pool, data); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I swear I did an allmodconfig build ... don't know how I missed this one. I think I'll make the page_pool_recycle_direct() macro accept void * as well, and treat it as a page. Once we finish the conversion to netmem, this problem will go away. ie this: +++ b/include/net/page_pool.h @@ -485,7 +485,8 @@ static inline void __page_pool_recycle_page_direct(struct page_pool *pool, #define page_pool_recycle_direct(pool, mem) _Generic((mem), \ struct netmem *: __page_pool_recycle_direct(pool, (struct netmem *)mem), \ - struct page *: __page_pool_recycle_page_direct(pool, (struct page *)mem)) + struct page *: __page_pool_recycle_page_direct(pool, (struct page *)mem), \ + void *: __page_pool_recycle_page_direct(pool, (struct page *)mem)) #define PAGE_POOL_DMA_USE_PP_FRAG_COUNT \ (sizeof(dma_addr_t) > sizeof(unsigned long))