From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB3EC54EBC for ; Wed, 11 Jan 2023 02:21:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 402E58E0002; Tue, 10 Jan 2023 21:21:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B2E48E0001; Tue, 10 Jan 2023 21:21:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27AED8E0002; Tue, 10 Jan 2023 21:21:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1A5B48E0001 for ; Tue, 10 Jan 2023 21:21:07 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DE34E1A044F for ; Wed, 11 Jan 2023 02:21:06 +0000 (UTC) X-FDA: 80340915732.12.9662CC6 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf10.hostedemail.com (Postfix) with ESMTP id 54BD2C0005 for ; Wed, 11 Jan 2023 02:21:05 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=EJXDRWw9; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf10.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673403665; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nC2zRIJsPDH7lfPM013A6ZhKrdzcIixd+v8ICTA/zXw=; b=oF7zVyOa3NHwQ22yM5IVBT8fhq4XeFaHJt8gvQT9QK2E/8gT9jCB3wBrVSwEmRX2Ol6NHu lCVn15wdZqq8YF6/MIRmswilulitilWfeXwztsSnUBc26bRAHzjg4cKkZnsCfWy+JsYaP7 w2paGF+7kaAci9v7uL7fexR/aaua1DA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=EJXDRWw9; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf10.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673403665; a=rsa-sha256; cv=none; b=B3hqweVpfHJKeZVav8bWuxZQG+heL626CCGIyiY0hAjUZQsIEWdEs4rhJ1DzEjFzoAIJp4 MBsIgFb8JiWJfiCQgyZKNhvNFo7xlagIcxcTADI4SEKfkw2Cf2p1Gn+6xj4QY+sZYEepOy 4lKP3PpWisePMLvj1BYIEQfgQC65OXA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nC2zRIJsPDH7lfPM013A6ZhKrdzcIixd+v8ICTA/zXw=; b=EJXDRWw922tsBHv8pVihMTfEzX cAnh+DIDfy5WK8WpuLeldrQsLeM+U+IDEhfDKkpqfRPo5ltzJrRQJN2h0983eKxZEn/ViZvQT1zw5 dXZE6B7ajOJP+d079+ZOkU3XjRGF0CBIhvdLilgI3TMdfwzsYv8Hj+L9vHTLYg6953pTPbQgKeBnG jKblwmPGe5q2Ukar3+4BVgnbtwgOGcxJvaBJ2QDDdnukNQLNFYs45tV0O+meIHYIoke++yw3YLSEc ckkPIEkrGzWzDZEg2WPLfglK5OOx6Ai2BfcMgqkfqHHatTmLIju0/qQmXMpjNhfM21hXR1omDsOhr Xvu53ukg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pFQjJ-0016dP-29; Wed, 11 Jan 2023 02:20:42 +0000 Date: Wed, 11 Jan 2023 02:20:41 +0000 From: Al Viro To: Christoph Hellwig Cc: Matthew Wilcox , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories Message-ID: References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-4-hch@lst.de> <20230110082225.GB11947@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230110082225.GB11947@lst.de> X-Rspamd-Queue-Id: 54BD2C0005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: fk4ydyz8c5ceju8b6nbyjgjmi9dynd61 X-HE-Tag: 1673403665-129660 X-HE-Meta: U2FsdGVkX19ECRsXJT2fSmtnRxStwCUU5NDJ7uaEgTDOKMeh7+veZ1hGRyFTGJMwjXp5VDOtqUkSzGcmotKuIJdIL61Sy7qMuWSrQLDd/he3mh0z9KF+E5Ph7P9sgE8eyudOoD6ocUWMpE8+Svb4czbV9J1Pr7fXqJGc0wlE7A3gvDRDX9lkOkqoPdnIlYci64nWE1P/x2l9TcmHkWdvmND4upQlcXZmls+p61Tu2Ybtm9znYj7fGRl9CP7ZblfVxqJaEWzro29IjOfqg6wCweSwS2ZtnV27Gp6gtJ0HZWyzFYrTktTFaRq2juJYuULFGd/aXS22qaG4WukdEhYU5tm0Tw5NAN3e3B8TBYCK5p3vVWm7qSyL5Ui5j5NaH6Qy+ia/ZEwAEPr0GL2VkeIO3H74wjoORsk9NT89bMXNyRAIZ78HBNFCoQqIMC4IV1YBbUG+eO63sGm0rdcesJOzC1/b9NToJObcVFfgBzy8QgQhd6U+4BThm2mjxw3RIPmFyNCMdJ66svZZocrwMH7vTYSLqQoBXu2DooafBY+KCT8qrkzlwdd+Li9hOodX8hhqNRvg908+NzkHpR9vK9izZcwOaHrue9JDAxTadtoVhn0FFq+R/GFeg16IgJds3AUDeg2KICh3Lhl/QwtfL+29HtFjk7HYpiwopQ7X2uW/knHoJ28s8oJ6TN0AbiZYMKZMMphSYgdd1XAlt/iAlB7gBvYNWKke968Uy6i2xu8ChimD2+TuppEF9q+EVYdB22kgv9ootsXI7V39SSgY69OQmlTehPVaQrfzcJMzeoLDjrnZqs68mZ1nrk6WyRzke7qMjet3dw0UckO+1fe+FVDCaOwmAt1ne8V1teeM34DJ33TlCyZelWHj/F6vEzUaGvsKI2e7XuiaRmDnW1p6uf0M6VD9gTDlUDzQmzeOahJuU/Er6losN2YMWjjsFgfHeLorGNVmnHvW04At5DotyOY n1DzAs40 Yl69RphH3g7VFYmmc4S2nCLoHvIuNNrFYRkEOF7Kd1sEQO+bHTNzNie3zF8rKGgTx0mBo85bSCZAxPK2J4OW3QdBwKuXixBwbglI8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 10, 2023 at 09:22:25AM +0100, Christoph Hellwig wrote: > On Sun, Jan 08, 2023 at 09:17:26PM +0000, Matthew Wilcox wrote: > > > + dir_commit_chunk(page, pos, sbi->s_dirsize); > > > dir->i_mtime = dir->i_ctime = current_time(dir); > > > mark_inode_dirty(dir); > > > + minix_handle_dirsync(dir); > > > > Doesn't this need to be: > > > > err = minix_handle_dirsync(dir); > > Yes, fixed. > > > > > > @@ -426,7 +436,7 @@ void minix_set_link(struct minix_dir_entry *de, struct page *page, > > > ((minix3_dirent *) de)->inode = inode->i_ino; > > > else > > > de->inode = inode->i_ino; > > > - err = dir_commit_chunk(page, pos, sbi->s_dirsize); > > > + dir_commit_chunk(page, pos, sbi->s_dirsize); > > > } else { > > > unlock_page(page); > > > } > > > -- > > > > Aren't you missing a call to minix_handle_dirsync() in this function? > > Yes, fixed. More seriously, all those ..._set_link() need to return an error and their callers (..._rename()) need to deal with failures. That goes for ext2 as well, and that part is worth splitting off into a prereq - it's a -stable fodder.