From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932DAC54EBE for ; Tue, 10 Jan 2023 18:47:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F0FB8E0002; Tue, 10 Jan 2023 13:47:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A0ED8E0001; Tue, 10 Jan 2023 13:47:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 091748E0002; Tue, 10 Jan 2023 13:47:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F16BE8E0001 for ; Tue, 10 Jan 2023 13:47:27 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB1801C6FE3 for ; Tue, 10 Jan 2023 18:47:27 +0000 (UTC) X-FDA: 80339772534.30.265399A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 187F714004B for ; Tue, 10 Jan 2023 18:47:25 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AELf9y87; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673376446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i/9o7iNl6zIhJocKYwkxzObk5xjtVqd6JUFtOY8FyKQ=; b=KSBtaSp096cXVp284+ogmpDxk3qf9J3xRwWKy0NPL7UYUI2smUyrPJRK+nYhoKhvaEAWaa LLMO3vauqUbApqDwkLhv2FpYPBFGff6OGmjfOZrqs7Q5RL9ItF9IAyBtQq+n/8bf9v6Vkh DXaIMKeyWe87keCmgr6o9Al7+2pNTOo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AELf9y87; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673376446; a=rsa-sha256; cv=none; b=ABatU/nb1ezI9Y7Jizh3dalC4aZu6UpNFWeVFeMbtHV1cQ+/kxzuUpTMiFHrHbFnQL/Dpo TyLh1qKycSt8SQ+PaGSSTmuCjNIQ1GdpZlzB2KZbymPZViTimANE6g9srCr6djUPhtyxnC amKKW4jthnYGwmbfYjydDKzwIUQ3dpU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=i/9o7iNl6zIhJocKYwkxzObk5xjtVqd6JUFtOY8FyKQ=; b=AELf9y87WqHFA8TfIY326rRMk5 Jr+ZcgRGBSwPm19GtkO7qNAS9E4q8pY+DcVleHVEQuFxit9tsYl1No0w8Wwj0XipdcLEU+xrqzwct pTy9wDqKztiLytpcUIeVN9MTgQxnNUX/nAJoHDuqz8FtEuRI/8+uJDvDHvoL4HogPy2b3e5SRWPAN Gl+6R1Z0KYr3IKWbdtTbAcHeIULTXCLVCxUM1aIQWQcwHpem20AMWnhlubqjN8SQ6omPOdXzwTHAi Y6GTs462QeuHu1yTT7T2AoL80KXaxIRCVnU859fvFoX6pv7AXBXi+vyx9XDGmzMRvXvNEW09u2Q+4 9si2KJuA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFJem-003SHj-Qf; Tue, 10 Jan 2023 18:47:32 +0000 Date: Tue, 10 Jan 2023 18:47:32 +0000 From: Matthew Wilcox To: Ilias Apalodimas Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 04/24] page_pool: Convert page_pool_release_page() to page_pool_release_netmem() Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 187F714004B X-Stat-Signature: dox48qyrizgjxwt5h8kd5rqk9rzwdd3h X-HE-Tag: 1673376445-398310 X-HE-Meta: U2FsdGVkX1/N0qI8K9xRQjKuHdu1WUEaoxquEI7bJ8jDTITOU7zv151iAyd9sBX8FV3LONU6uwZMcSxz/o9uL1wm8Zqg1U4oecUcKEnf7divnV5haBIGC+Vvh9wUYpJXhmYfgd8nK95QyFtXqnFb/XdZ2GCaL8rMHPz1AB8WJq2T4Uo6+uY8lGhHPb0klP0Bk8R3YPjlExSOIHy8kfDp35aobfQbzyL8EDFFZ1Q92K7lHZ6kvBt2qKdIxFb5mnE7VEI+aWACVQLYTTl3c/KwQRt7Qfu9aXhb/R6bHgEV7L5PZPqbgim12hxx1hMqOrAAwyYJ35gMo6bFPVCb0GnFYiyoIv6d/wRWv0ByYKEmEMvKhfQFcTaQQC/a1/4yAiYE6FW6wm+2WixG+rf+QiQHBUui8lMAyu7Zm4AVLPTp5qbx1XBA6r0eBrBxCB//6/0batLgjzap7pnK4KG3vhDdjnPqRrymgYsi3gOs/d+98y+7Mq6Mk4/tkO55clbc1ZEG9Vrs/Lfca+URrY7dX7pZeXXhocGUPGNbSjNdXPbcP31hqifaddcKINniZ9w/xBL0pxVy5KeXjg9VrrEKiJyuxw3ULakUaY7FCupjFKp0+61oDljoPXhVTyuRvAyF6SmUg9nNLs/igWbGFche78Hc6p0lsoRL/3NNi5WBOZSkaS/4+V8fqI22SnExVr+f1mqh/FxNwMI7GaLTclluqy3FD203/4/tgWcS1cnUnKRC2nrtmGDUTFKwNDtQ3hADzj79lxADVgyIMFCpk7RktZj30abAVeZMEF9bILoE25q67sauB8lwq0j3UlC3Mzl9F7y2LZsUDEN5oRtNfzWXIjJeB3NrGfS7ZSGMp0HyXJmogKYNzQfxOxAhOzzvyc+g0D947uGtNld+UeubpXO+neNeTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 10, 2023 at 11:28:10AM +0200, Ilias Apalodimas wrote: > > -static inline void page_pool_release_page(struct page_pool *pool, > > - struct page *page) > > +static inline void page_pool_release_netmem(struct page_pool *pool, > > + struct netmem *nmem) > > { > > } > > > > @@ -378,6 +378,12 @@ static inline void page_pool_put_page_bulk(struct page_pool *pool, void **data, > > } > > #endif > > > > I think it's worth commenting here that page_pool_release_page() is > eventually going to be removed once we convert all drivers and shouldn't > be used anymore OK. How about I add this to each function in this category: /* Compat, remove when all users gone */ and then we can find them all by grepping for 'Compat'?