Re: [PATCH v2] mm/mmu_notifier: Remove unused mmu_notifier_range_update_to_read_only export

[Mike Kravetz <mike.kravetz@oracle.com>]

On 01/10/23 13:57, Alistair Popple wrote:
> mmu_notifier_range_update_to_read_only() was originally introduced in
> commit c6d23413f81b ("mm/mmu_notifier:
> mmu_notifier_range_update_to_read_only() helper") as an optimisation
> for device drivers that know a range has only been mapped
> read-only. However there are no users of this feature so remove it. As
> it is the only user of the struct mmu_notifier_range.vma field remove
> that also.
> 
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> 
> ---
> 
> Changes for v2:
> 
>  - Added Mike's Acked-by
> 
>  - Added Jason's Reviewed-by
> 
>  - Removed the now unused vma parameter from
>    mmu_notififer_range_init{_owner}()
> ---
>  fs/proc/task_mmu.c           |  2 +-
>  include/linux/mmu_notifier.h | 13 +++++--------
>  kernel/events/uprobes.c      |  2 +-
>  mm/huge_memory.c             |  4 ++--
>  mm/hugetlb.c                 | 13 ++++++-------
>  mm/khugepaged.c              |  6 +++---
>  mm/ksm.c                     |  5 ++---
>  mm/madvise.c                 |  2 +-
>  mm/mapping_dirty_helpers.c   |  2 +-
>  mm/memory.c                  | 12 ++++++------
>  mm/migrate_device.c          |  4 ++--
>  mm/mmu_notifier.c            | 10 ----------
>  mm/mprotect.c                |  2 +-
>  mm/mremap.c                  |  2 +-
>  mm/oom_kill.c                |  2 +-
>  mm/rmap.c                    | 11 +++++------
>  16 files changed, 38 insertions(+), 54 deletions(-)

Thanks for removing the now unused vma parameter.

There has been some code movement in hugetlb.c and memory.c, so Andrew may
need to fixup a bit.  However, that should be straight forward.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz