linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Robert Dinse <nanook@eskimo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	bugzilla-daemon@kernel.org,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	kasan-dev@googlegroups.com, linux-mm@kvack.org
Subject: Re: [Bug 216905] New: Kernel won't compile with KASAN
Date: Tue, 10 Jan 2023 14:33:00 -0500	[thread overview]
Message-ID: <Y729bEXOkwfGBsZE@mit.edu> (raw)
In-Reply-To: <9acae081-9d4d-3dd5-8b2c-52c72592e81c@eskimo.com>

On Mon, Jan 09, 2023 at 08:58:41PM -0800, Robert Dinse wrote:
> 
>  Increasing to 2048 did allow kernels to compile with KASAN enabled. I
> am curious why e-mail only? It would seem bugzilla, a public forum would
> make this fix available to others who may be experiencing the same or
> related problems.

Not all kernel developers pay attention to bugzilla.  (In fact, most
kernel developers do not.)

>  Interestingly, I could not locate the symbol with
> xconfig, had to hand edit the .config file in deference to the fact that it
> tells you not to.

If you search for FRAME_WARN in menuconfig ('/', followed by
"FRAME_WARN", followed by return), it will report:

Symbol: FRAME_WARN [=2048]
 Type  : integer
 Range : [0 8192]
 Defined at lib/Kconfig.debug:395
   Prompt: Warn for stack frames larger than
   Locationf
     -> Kernel hacking
       -> Compile-time checks and compiler options
 (1)     -> Warn for stack frames larger than (FRAME_WARN [=2048])


That being said, you can edit the .config file if you know what you
are doing.  But if it breaks, you get to keep both pieces, since there
aren't the safety checks and guardrails of the supported paths.  For
novices, I recommend saving a copy of .config before editing the
.config, and then afterwards, run "make oldconfig", and then diff the
resulting .config with the saved copy to make sure there aren't any
unexpected changes.

Cheers,

							- Ted


      reply	other threads:[~2023-01-10 19:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-216905-27@https.bugzilla.kernel.org/>
2023-01-10  0:09 ` Andrew Morton
2023-01-10  4:58   ` Robert Dinse
2023-01-10 19:33     ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y729bEXOkwfGBsZE@mit.edu \
    --to=tytso@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=bugzilla-daemon@kernel.org \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-mm@kvack.org \
    --cc=nanook@eskimo.com \
    --cc=ryabinin.a.a@gmail.com \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox