From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC638C63797 for ; Tue, 10 Jan 2023 13:37:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 796588E0003; Tue, 10 Jan 2023 08:37:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 744E38E0001; Tue, 10 Jan 2023 08:37:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60C7E8E0003; Tue, 10 Jan 2023 08:37:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 523C88E0001 for ; Tue, 10 Jan 2023 08:37:53 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2D976AB320 for ; Tue, 10 Jan 2023 13:37:53 +0000 (UTC) X-FDA: 80338992426.23.AC444D5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 2BE5F180017 for ; Tue, 10 Jan 2023 13:37:49 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=We4DGf5k; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673357871; a=rsa-sha256; cv=none; b=hA44RjmzBe7nh4J9hc73a2ZkGpiSe33HAMYz0PrtqhKK5vf3WnJOOi1BTMahasFcwVlLuM 5e9iX8qvHPorfxONlNT6m0NTBqPtLiQ4zjAdIY/IbZpu0AtKcoSzDoFkkxgLdDHK6mfSsW n6bpN0fwn49cua2n6jEOJ08/bulE49I= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=We4DGf5k; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673357871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FShK9vXFfxDQ4VGD5JOqblYjjglMV5Oj0hc50k6vmGY=; b=HI7s9lcMMDMvz+rVAmFK/MznLyQJ9jmLKnJ50NnYFtNSAheaZmOmWsqbInAGUldXpcjdla BksXAeZBF06m3nTpZvMz8zawYOX6uwyGJCqT0yCYv1Ei26DkbWRzhiSFSuPm3g8ZGsDNry rDNaxBBWkXKCOclzR3bPaaWW2C1uE0s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FShK9vXFfxDQ4VGD5JOqblYjjglMV5Oj0hc50k6vmGY=; b=We4DGf5kDltzbK3aK6i7Z/0oJz c8anxvmA2jXtu9UH4C3LD2musClj6rfaKyX8NSiyCs716ySnSnm2ucdtBPLKDzrN7DsAYyqNJQuwB oOQXGs+9p94OYohhBLyFMNpTVf1E10zPtLNuaSwwUqGPZOq4l7A03EBRFktyBKWx15kRPq8jPpqFQ rgfGLUIuwh6181aUWTknoCIevc+FAI2eWgJ1IMml1LsaeUvS0gnFSk1oTdX1cOxQ8IjCbJbn/XBgb fRdrY1/Q7qGPv+a4B9Bvcthi+URHKL2kuufKhzovpA7u+LktD+RsIB2lG6dsbIRcRDyWFrwgBTtqe amIYcpew==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFEpB-003FO5-KZ; Tue, 10 Jan 2023 13:37:57 +0000 Date: Tue, 10 Jan 2023 13:37:57 +0000 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] mm: compaction: Remove redundant VM_BUG_ON() in compact_zone() Message-ID: References: <740a2396d9b98154dba76e326cba5e798b640ead.1673342761.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <740a2396d9b98154dba76e326cba5e798b640ead.1673342761.git.baolin.wang@linux.alibaba.com> X-Rspam-User: X-Rspamd-Queue-Id: 2BE5F180017 X-Rspamd-Server: rspam01 X-Stat-Signature: goibiqp946zqj95t95f579ysiqris86u X-HE-Tag: 1673357869-316023 X-HE-Meta: U2FsdGVkX194XIHb2inOWFo4ZM3zaqhnzd7cwyWm+1BiYV4eCQYU5So2zYHwhZ5y5N0wiJUNincaLggx6h8i9PZgWFm3VXpjo9GtYpl/9emD+XAdv4L5uS1ApcxfS4EC4zVnZI2pPlhipelMIgbxhtDvWZTQfrAmfacPBYOcIcLuXSp1BtlQHdT5qrM0mD4d9vUVu5xTtPYQv6t36qq7fFNh2MdJYRMdfqhn91HByuWUI44bhhczEx0tA1MZh257EExi6GAH9z+rIpi7BY1Sxe+97cdsyB90qaybCRAV47R6b2Prk0Fr6FdV4PsccfMlTitToNTDH8LquY9GXxV54lHrFhr3MhEhPp/h3f+rpnXrOZIauGnqKpgy8RpWwD33Qm08q0SIIkOBOmREY9Gyz9eaATQG5tMj3tDCfSrFI9Akh3P+W1jxWGZmDOWQbAnNFMkTWqP4FMhMVoAli2czx48ZEeqCaiQZt5VpmonC4ihxcrjeowsbHQsk/pNgxZWenQ+E04QsGBJ9v3GPlLYFr6G9DU8EBnruOWKP6yJVUS1EqGLyKWb/l4bcXxjhNVCVDwwOtQ3u+TToXeS4azRfSV+GOKGGBBRFKH4Daqw1oO3wuDNx3DtG7GKy3EgHCxl5LcPFa4bcwZSNAmTMikmbuEmZGn0+jdmq71bzhKaUAvc80ZcvyUM/62tHcXH6PToUaoF1g72TmpTLqjJDpW9BQQaTnvt7qmGy2OtXBwdRTzCb3WdwoDSvurYFnWF0hKTp7P0h4A0y3zhK2iyDjuYQzZOYPmeKJ6MSNVT48tZUgT0NGXrsmc7N6+JCWLuSzjz5v0o9FvQ8mPRDL648y/ZKfPrmQ2HoN4G4touyGIgghsd6pMWdEkZnXK4Yv60nRO/mIlZiW7B6xbLxj3cQwPkv6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 10, 2023 at 09:36:18PM +0800, Baolin Wang wrote: > The compaction_suitable() will never return values other than COMPACT_SUCCESS, > COMPACT_SKIPPED and COMPACT_CONTINUE, so after validation of COMPACT_SUCCESS > and COMPACT_SKIPPED, we will never hit other unexpected case. Thus remove > the redundant VM_BUG_ON() validation for the return values of compaction_suitable(). I don't understand why we'd remove this check. > Signed-off-by: Baolin Wang > --- > mm/compaction.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 62a61de44658..5e6f5e35748d 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2313,9 +2313,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > if (ret == COMPACT_SUCCESS || ret == COMPACT_SKIPPED) > return ret; > > - /* huh, compaction_suitable is returning something unexpected */ > - VM_BUG_ON(ret != COMPACT_CONTINUE); > - > /* > * Clear pageblock skip if there were failures recently and compaction > * is about to be retried after being deferred. > -- > 2.27.0 > >