From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFED9C54EBC for ; Tue, 10 Jan 2023 11:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AD8D8E0003; Tue, 10 Jan 2023 06:51:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65DAE8E0001; Tue, 10 Jan 2023 06:51:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 526E38E0003; Tue, 10 Jan 2023 06:51:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 40E378E0001 for ; Tue, 10 Jan 2023 06:51:17 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 14FF41C5D72 for ; Tue, 10 Jan 2023 11:51:17 +0000 (UTC) X-FDA: 80338723794.06.4B6299C Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf01.hostedemail.com (Postfix) with ESMTP id 47E3B40020 for ; Tue, 10 Jan 2023 11:51:15 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=yaD4qKIB; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf01.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673351475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oIbZQnJAFxgeIrjHC0H2OUIydFF5+euWS8BmOxj9K6w=; b=GxbedA7/BdJA7RMZa+UovvonHnNXX4P9f2iV+PMtv4zeIAQpjsshVRNsS+wAy3daAVXTac I5AvJ9IBroVWy30rgAd/zREGkOn3ingpUg34R1pbBetFbIIG04NTrRr/nZ/ehkGFDRsTkJ wp2AHZCFKMmqnW+MyOEJWxeuH7mOdiM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=yaD4qKIB; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf01.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673351475; a=rsa-sha256; cv=none; b=eIQl6afNmmTkzOOwzD7BA6dG2VPa4pQTujUsP4qgpXj+KOKCaq203UOxStjXrhRGFlIg/v icI5JWLX2G391rNlbbsSX1IEXoIalaRIiEf3ExA9x0OLIUk/lhxvvG1URLryX6u2wjSr0l ocIwR/WThe42l91gr7mSzCM5PXARohQ= Received: by mail-ej1-f43.google.com with SMTP id u19so27834461ejm.8 for ; Tue, 10 Jan 2023 03:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oIbZQnJAFxgeIrjHC0H2OUIydFF5+euWS8BmOxj9K6w=; b=yaD4qKIBgAiTLoy06qkRsdxkIAe5twpsxNRFy9IE57YUXS4myjzV+/pNefYu+IwdKk I8MFndRXiNQFNvn1dAlRF2ym7XF2Z3rXZweBL72fkGZXpH0VwSitk0mU6/GzEMsdnZpY B8ZZMi917+ktvrZgMO2zohbY6KVlb5iP2N+VwtQoTiE5l2dzELgad113p+h4nkf8N54X Wwe582FK8V6o44TfsgUzbqK0qVZUj0b3ZbfHmyXmXAwx7h2dQL6YQsqBmeymZhLjLlAQ mES9rSaPS43gyiA0n3Fx95OgWC2etUQM6+wsB76jI9K1ypCbOQS1CIImYzAHGSeSIHRe JtvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oIbZQnJAFxgeIrjHC0H2OUIydFF5+euWS8BmOxj9K6w=; b=zYEriS64S5MwIJOnD2XHv4B5CVWi0kSMiAPqaNEh4OYm6WKbMPqD1iq05Ds+giEu0B l7UTW3zbVxLO0hrNMiz0fr/PPQ66r+ligwXkJgumevlu9FdWUWg9hJiymw5tVkko57PU I7JvMRXZqam3EZCRv9tS4Ar0B+ygCKcYRxSJOFCK64sntQm4uMQvkIGwXt0+YHHL7Dmj TN+ZDYg3d//1MlFsKDtPIPK/OG6W9xeYAIw/d4odoKt9c+eOAhKFkO5ZcDAeaTeJwxcQ i7h4wKFhcePOuhfhKbt6dEToB2rcSvMXQzcTeHo74uakICnr8+TJukTW+L8RxQYS9STq kWJg== X-Gm-Message-State: AFqh2kq5sYNTS7wAXTmQ+rIMKe7LJxPiPrnZmw6Xk6i6V/E9lMTNnA1u hyZLHLLJdFG3gjNBBzZ2rYLkkw== X-Google-Smtp-Source: AMrXdXsF4ezkqlt7LBL8VzAt7Yz3QRazT6jfNGuMCRSIwBQbNMyk2TtYnAHi3CRqS+OglKuRz8AgTQ== X-Received: by 2002:a17:907:6f09:b0:7c0:a877:1cf1 with SMTP id sy9-20020a1709076f0900b007c0a8771cf1mr65202881ejc.12.1673351474078; Tue, 10 Jan 2023 03:51:14 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id p14-20020a170906784e00b00849c1e5c00esm4850678ejm.72.2023.01.10.03.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 03:51:13 -0800 (PST) Date: Tue, 10 Jan 2023 13:51:11 +0200 From: Ilias Apalodimas To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 20/24] mm: Remove page pool members from struct page Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105214631.3939268-21-willy@infradead.org> X-Rspamd-Queue-Id: 47E3B40020 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 91fjujttj9cknsef3fgzp8p1x19qydxc X-HE-Tag: 1673351475-910840 X-HE-Meta: U2FsdGVkX1847ECPE/oaYAmpK3YAxMUTLQ+6nfW4te3Xi5+64fjz1ufRGigRAM5mXlmnKZ3IdOwMGpi93/1kQ0sHeVxsS5PP5PlvgOplIamL0Z2GBDueIqdGoB+eNJ5otpMUooEn8NxVpXZfuKj6KGiGmHrcD/BbLuBsDNpzoS28buZ1CX34+siV8ZxElHWf56mLrmctIzyMhF1y3vB01AnqYiKeP1yD0yJ8PlmJZCJRpt7PWRZvFEYM+PSIRvDtuqnHY+xCr0aPq12DJ4hHC0gibivsJyIaubRKe8Z3dEoj/5AwxOTDnqcOzMCqV9AM+/nIGXWpWk9RC0O6UvqqVb/b8bKNKF2AYiYxn+UaDu5hmE9qdUb780N3BJWzsOIxgFYWEqrkMRt1+BHHrSKMmpttyPKgW8R7ypSZJ4T7/PPlUqHi1DtGpTnb+f2eNgdfGE4BhRACuKm/H4J1esaAJY80teP+QuUmizJEDY841Lrx0VpI2LyNILUgr6ko87MFtGb9s55L0vKXf9PeOghE5ktO66+FV+x4jRZ995vQBwAzqlrvoLXA2g09e42a+eXddM05y6RfQckTj/HJW33WxFemK6GL5PtXgIhQC92JEmeu5VZp2tyztD8WH0D6OTeYLi2BAl1P5/+n/eH1Z1bY0Bk1Dgi8k1nwv4NnpnfQECyeSfso+ZylF3fgKoLorsBe5G9qNilJuRyvb+IVg97t5HT8IEN6ZspUsER/gMt7sPQl4fh2TP/QioVU9ajhIVcuA9bXQej0fV5HDTSSrBwSgkEK05dqxjBI4jiX9vn7w6vE6WCNWQ3faTap5UGG4NqSIi57QeYZnVU7qVLyHQe20mjPPqhxKHp06XcaDklUY8sxqO1LetJSLtmXR5/yHcRuv1VQcrxFLngGAB4vm51RwBWVH61jnAC0CJnLIP+7xJR38I7aBcdRB8YDhcshLSoHqLjLXBKSltFrNvi1xxb x06xGj7B FGKbgmZW7hNeDzf6LUkLYYcemh6PB2aNGN9XyiHiTn9Vkf1zcpg5Y8PlsNvleytuS8MVXJx3+IiMbhZZirMLRo/b2jg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:46:27PM +0000, Matthew Wilcox (Oracle) wrote: > These are now split out into their own netmem struct. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mm_types.h | 22 ---------------------- > include/net/page_pool.h | 4 ---- > 2 files changed, 26 deletions(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 603b615f1bf3..90d91088a9d5 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -116,28 +116,6 @@ struct page { > */ > unsigned long private; > }; > - struct { /* page_pool used by netstack */ > - /** > - * @pp_magic: magic value to avoid recycling non > - * page_pool allocated pages. > - */ > - unsigned long pp_magic; > - struct page_pool *pp; > - unsigned long _pp_mapping_pad; > - unsigned long dma_addr; > - union { > - /** > - * dma_addr_upper: might require a 64-bit > - * value on 32-bit architectures. > - */ > - unsigned long dma_addr_upper; > - /** > - * For frag page support, not supported in > - * 32-bit architectures with 64-bit DMA. > - */ > - atomic_long_t pp_frag_count; > - }; > - }; > struct { /* Tail pages of compound page */ > unsigned long compound_head; /* Bit zero is set */ > > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index a9dae4b5f2f7..c607d67c96dc 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -86,11 +86,7 @@ struct netmem { > static_assert(offsetof(struct page, pg) == offsetof(struct netmem, nm)) > NETMEM_MATCH(flags, flags); > NETMEM_MATCH(lru, pp_magic); > -NETMEM_MATCH(pp, pp); > NETMEM_MATCH(mapping, _pp_mapping_pad); > -NETMEM_MATCH(dma_addr, dma_addr); > -NETMEM_MATCH(dma_addr_upper, dma_addr_upper); > -NETMEM_MATCH(pp_frag_count, pp_frag_count); > NETMEM_MATCH(_mapcount, _mapcount); > NETMEM_MATCH(_refcount, _refcount); > #undef NETMEM_MATCH > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas