From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC74C54EBC for ; Tue, 10 Jan 2023 11:50:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 268308E0002; Tue, 10 Jan 2023 06:50:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 218528E0001; Tue, 10 Jan 2023 06:50:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B9688E0002; Tue, 10 Jan 2023 06:50:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED3B08E0001 for ; Tue, 10 Jan 2023 06:50:50 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B6C731A03EA for ; Tue, 10 Jan 2023 11:50:50 +0000 (UTC) X-FDA: 80338722660.09.88F083A Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf06.hostedemail.com (Postfix) with ESMTP id EA5D3180006 for ; Tue, 10 Jan 2023 11:50:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=wwrU+SEl; spf=pass (imf06.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673351449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BiHzBTbGMSuIpPbe0K2/KjSY8XsgIfVh0SpcqkalzUc=; b=aw2cb+lRDlikTAxdyYZbdyapyWvTnyiKlMXqYJno8YAM9OCxMqUUOtWh0rcp647ZG55HMN 7DQe265WkkmA+06P1jWk4tfhPqy0Bc+vSdW2F8zMf642e3/jeHKWBlXvvAHJx+akHR6umV pGbi7tMB+FLnY40CH+Y/S+Zh8qDnVVY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=wwrU+SEl; spf=pass (imf06.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673351449; a=rsa-sha256; cv=none; b=Q486mM4urh50yMre2NgOQdeIsncL7eR4+w1Nd+6JMGe9c1MThkWEGwaFjHrfQDCVv7ru9i DB+YI0q31OmQ2/PcTtePtcQyynew33JNwmpGNQoS6oq6VGeZAoEOzBfCUfAVXdgZucETmt U5/M1JXvX2Ve6AmMftEU2EfX08uozQ0= Received: by mail-ej1-f46.google.com with SMTP id ud5so27930650ejc.4 for ; Tue, 10 Jan 2023 03:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BiHzBTbGMSuIpPbe0K2/KjSY8XsgIfVh0SpcqkalzUc=; b=wwrU+SElgLL8do+WFRBXJdGes+eH6xhL9flu/mxjsfZc4OjtKLZG87h2T0XLhEWqJ4 lfL8Xh5NVlU14yB8htdazrbF5IzChQ6Tc4Hmr+K6mWasniBPPDWJ2q8EWg0i6fUnBr9P M+DgmAcfp5LWbilhedSWa95rRRPcAFGATtJURRab7GuylemTifA5PJcrtqGg9M8WHqmF n7VCem6qjiheA4oxVyxs+WRs5DK5HsZuKkhEVcyWN4vk1bmSGhnjpbw2nZBu7iWqXTfC i4u4Do7T/EfrMZIT4WW5gfYgpI47SNXvzOljfek5l2Ls4tRk90fHjS6YRAewSfV5CHvG udtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BiHzBTbGMSuIpPbe0K2/KjSY8XsgIfVh0SpcqkalzUc=; b=jdLyT6YkZSGBzKvGnsamLjGuH5zorcwcRVbiuVPO5l3tUZb0ce5HPeghqCPwwi4tth ODgH2NY7exfJgDbLSaiWFvCZECEUU/doKqITmtdZzrY3eOb3NkuQ0ip7T5jEAQzxBPB3 5+LAAdpqI5a37CVhY24uA1wE4dBqfArow7LHQ2c4p98XLwnR8NzHt3Yjo6amnKRIDzhy ys58nTgmMfqqoZP1cdwChJVcBtQ9ge5Fmo5Dww+g++JvMECs+KHMHLm3Ochng0x2nFRa jX+VYD7iFCNKa1hMNtTCx5+V8jnhPh8xKzoY5obXU6Q2aTHbzgzqPDWCKcivZ48jfYkR AiQQ== X-Gm-Message-State: AFqh2ko4inWg/xU37BIwHvdjdJg7IGFfNPzNHbFndyNkm2WAwZZV8DBH HsErnM4G0T8CqbxRFOxqUqLv1Q== X-Google-Smtp-Source: AMrXdXscyhAc9NjtqnFO5nOuFK3X5ZWRKKoCIdOCvkGTIeycC5K5JFadXUz+Sbq01EWOxJktj080Hw== X-Received: by 2002:a17:907:d045:b0:7c1:5464:3360 with SMTP id vb5-20020a170907d04500b007c154643360mr80125660ejc.65.1673351447462; Tue, 10 Jan 2023 03:50:47 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id x11-20020a170906b08b00b0084c62b7b7d8sm4870119ejy.187.2023.01.10.03.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 03:50:46 -0800 (PST) Date: Tue, 10 Jan 2023 13:50:44 +0200 From: Ilias Apalodimas To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 19/24] xdp: Convert to netmem Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-20-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105214631.3939268-20-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EA5D3180006 X-Stat-Signature: 75co5x9xabpdxmknh4opts8fdxx5i3jd X-HE-Tag: 1673351448-491179 X-HE-Meta: U2FsdGVkX19bwpZ3jRfBEd0kK7Y2BCsS8GCQlWODBSpwGl4WzVV/XNqO8LqBec0phl/hvHLTmF5tpg+l0VKiru7OHjeny9wzYe2Gu+Bn6w2zBBLMKX73OqwUBhEmoOMUED4hu+zCZlJdWxM2nQichkpKORg3x6OtWw/8aDuKxzQzEMWZD8QuX5E56wW0gKk7Uqvv2uJGOEcrZwsQYaNSg5xRdfAzw8J0757zicBwY9mh909LGGBmyIhBL2JNDMWkVqtcorWdBD3SZ4ATTlm6LNLFLhvqHxtrpr0SGR6aMFLPicTWGOHNN3yiY3kxm9DhIl5FE98spEMxnxf5/+7+1mzqorE6b58tNTYtMY79Aw4IByiuf2XKGkdG515wCHV+8//MpW3djx/IoO+2bGTwLGJv5a/6Y2yYyPSATl21kmri5brIs2T2D/BXJFLQDRbEpNQASebyf9TRsJ1Gt6wik0jvz/xsMzb/y0uWIIYlUbZjywBANWbXUC9uilTBHLvdsmRx1iZ5gTVkG0HtsNus6dKPXr+NZAJ0ePI6Bww2h7og1KkMEoUkBts7/a205Ff+e5zzCbAT8DBPlQk+eRnOtaISVZeosLPno5q/GxCB1Rg98h+AbJUKosI+9TNEf51rG1evG9pXDuOnKBgLo5HeZWi5IneiWYnnhC5GpFB80E/0jL/EUnV3EHddLgMrnIySL3Ca5uGYAHQcimqe8lYmAiUbE0ou2f+n6F3+VnXF+xsQ+N8muJWPXTDaawrluKd62mMNkKxHNYPz/MgXgI/1cfvfrFTOg27JQ2LWPxNrZRGnbEVknc/zZ6IWfMRHWaLeWse8X/xd9hqirDmL/m+wtlSF3NBP4jhH06pJmiO1zwH4I9hwWBMMUT/MhAoIHwSt4F+vpjwt5R4mrUwTjrImPYDmZ6k9IXL1e0c7CEpuwUBGgCGlJHf5Vm+WM0/2nEUpVXmKrHojYlVLIOJHuTE 1vh0R3mt 4HJ2ehcusMU09dcTFZBe6q5j9Vq8+VhqJBj3wBzfEdTI7/r3s+yu/RLWDIfnaqx2a5ngNuIs4k7nnGEqAJFQi9XA2PQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:46:26PM +0000, Matthew Wilcox (Oracle) wrote: > We dereference the 'pp' member of struct page, so we must use a netmem > here. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > net/core/xdp.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/net/core/xdp.c b/net/core/xdp.c > index 844c9d99dc0e..7520c3b27356 100644 > --- a/net/core/xdp.c > +++ b/net/core/xdp.c > @@ -375,17 +375,18 @@ EXPORT_SYMBOL_GPL(xdp_rxq_info_reg_mem_model); > void __xdp_return(void *data, struct xdp_mem_info *mem, bool napi_direct, > struct xdp_buff *xdp) > { > + struct netmem *nmem; > struct page *page; > > switch (mem->type) { > case MEM_TYPE_PAGE_POOL: > - page = virt_to_head_page(data); > + nmem = virt_to_netmem(data); > if (napi_direct && xdp_return_frame_no_direct()) > napi_direct = false; > - /* No need to check ((page->pp_magic & ~0x3UL) == PP_SIGNATURE) > + /* No need to check ((nmem->pp_magic & ~0x3UL) == PP_SIGNATURE) > * as mem->type knows this a page_pool page > */ > - page_pool_put_full_page(page->pp, page, napi_direct); > + page_pool_put_full_netmem(nmem->pp, nmem, napi_direct); > break; > case MEM_TYPE_PAGE_SHARED: > page_frag_free(data); > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas